[Mod] Snow Biomes [4.0] [snow]
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
snowing in the desert…
- Attachments
-
- desert_snow.png (372.08 KiB) Viewed 528 times
- Splizard
- Member
- Posts: 227
- Joined: Wed Jan 25, 2012 07:20
- GitHub: Splizard
- IRC: Splizard
- In-game: Splizard
- Location: New Zealand
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
Does it make a difference where you are in the desert?
Snow should only fall in a biome specified area.. which can still be in a desert but it shouldn't be the whole desert..
Snow should only fall in a biome specified area.. which can still be in a desert but it shouldn't be the whole desert..
Games: Builda City, The Hungry Games Mods: Lifters, Snow Biomes and Gates. Also checkout my texture pack Gridtoon!
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
Yes, it's just a part of the desert. But l think that snow falling in a desert next to a cactus and a palm tree is a bit strange.Splizard wrote:Does it make a difference where you are in the desert?
Snow should only fall in a biome specified area.. which can still be in a desert but it shouldn't be the whole desert..
Re: [Mod] Snow Biomes [3.2] [snow]
Since pines are now in default, I think you could replace all
with
Code: Select all
snow:pinetree, snow:needles, snow:sapling_pine
Code: Select all
default:pinetree, default:pine_needles, default:pine_sapling
- Diamond knight
- Member
- Posts: 475
- Joined: Sun Apr 19, 2015 19:50
- GitHub: Diamondknight
- In-game: Ferrumprinceps
- Location: Chilling in Constantinople
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
do you know any seeds that will generate a snow biome at your spawn
My modding team: https://github.com/basilea-rhomaion
-
- Member
- Posts: 940
- Joined: Tue Aug 05, 2014 14:09
- GitHub: MinetestForFun
- IRC: MinetestForFun
- In-game: MinetestForFun
- Location: On earth
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
@Diamond knight
You can also simply set a spawn in snow biome :)
@Splizard
I've also snow falling in desert in my server (mapgenv6, very similar to Carbone default)
You can also simply set a spawn in snow biome :)
@Splizard
I've also snow falling in desert in my server (mapgenv6, very similar to Carbone default)
MinetestForFun Team mods : [spidermob] [fishing]
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
Re: [Mod] Snow Biomes [3.2] [snow]
It wasn't too long ago that Afghanistan had a major snow storm. Snow falls in the desert sometimes
Many of my mods are now a part of Minetest-mods. A place where you know they are maintained!
A list of my mods can be found here
A list of my mods can be found here
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
Shall l disable snowflakes in desert or make it rare?
- mahmutelmas06
- Member
- Posts: 367
- Joined: Mon Mar 02, 2015 13:10
- GitHub: mahmutelmas06
- IRC: mahmutelmas06
- In-game: masum
Re: [Mod] Snow Biomes [3.2] [snow]
In my opinion its better to disable in desert.Hybrid Dog wrote:Shall l disable snowflakes in desert or make it rare?
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
l didn't test it.
https://github.com/Splizard/minetest-mo ... a411be?w=1
https://github.com/Splizard/minetest-mo ... a411be?w=1
-
- Member
- Posts: 115
- Joined: Sun Feb 22, 2015 07:11
- GitHub: melzua
- IRC: melzua
- In-game: melzua
- Location: Catalonia
Re: [Mod] Snow Biomes [3.2] [snow]
I've got crashes like:
Changing the get_snow function code as below solves the crash:
Code: Select all
terminate called after throwing an instance of 'ServerError'
what(): .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: attempt to perform arithmetic on local 'x' (a nil value)
stack traceback:
.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: in function 'get_snow'
.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:191: in function <.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:183>
/usr/share/minetest/builtin/game/register.lua:341: in function </usr/share/minetest/builtin/game/register.lua:329>
Code: Select all
--Get snow at position.
local get_snow = function(pos)
--Legacy support.
if weather_legacy == "snow" then
local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
local x = pos.x
local y = pos.z
if perlin1:get2d({x, y}) <= 0.53 then
return false
end
-- disable falling snow in desert
local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3)
local noise3 = desert_perlin:get2d({x=x+150,y=y+50}) -- Offsets must match minetest mapgen desert perlin.
if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45.
return false
end
return true
end
return false
end
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
thanks, now its not longer untested and should workIvà wrote:I've got crashes like:Changing the get_snow function code as below solves the crash:Code: Select all
terminate called after throwing an instance of 'ServerError' what(): .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: attempt to perform arithmetic on local 'x' (a nil value) stack traceback: .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: in function 'get_snow' .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:191: in function <.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:183> /usr/share/minetest/builtin/game/register.lua:341: in function </usr/share/minetest/builtin/game/register.lua:329>
Code: Select all
--Get snow at position. local get_snow = function(pos) --Legacy support. if weather_legacy == "snow" then local perlin1 = minetest.get_perlin(112,3, 0.5, 150) local x = pos.x local y = pos.z if perlin1:get2d({x, y}) <= 0.53 then return false end -- disable falling snow in desert local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3) local noise3 = desert_perlin:get2d({x=x+150,y=y+50}) -- Offsets must match minetest mapgen desert perlin. if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45. return false end return true end return false end
https://github.com/Splizard/minetest-mo ... 65c046f500
-
- Member
- Posts: 115
- Joined: Sun Feb 22, 2015 07:11
- GitHub: melzua
- IRC: melzua
- In-game: melzua
- Location: Catalonia
Re: [Mod] Snow Biomes [3.2] [snow]
Ehmm... but... I didn't dig into the code so I'm not sure that x and y got the intended values here, for example in noise3 assignment there was a 'z' laying around... :-)
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
l forgot to change "x, z", what l copied from the meru mod.Ivà wrote:Ehmm... but... I didn't dig into the code so I'm not sure that x and y got the intended values here, for example in noise3 assignment there was a 'z' laying around... :-)
- paramat
- Developer
- Posts: 3700
- Joined: Sun Oct 28, 2012 00:05
- GitHub: paramat
- IRC: paramat
- Location: UK
Re: [Mod] Snow Biomes [3.2] [snow]
There's a new bug that was posted as an engine issue on Github https://github.com/minetest/minetest/issues/2672
The latest commit by melzua is wrong, 'get2D()' doesn't have the form '{x = ..., y = ...}':
2D noise always uses abstract variables x and y, these then represent world position x and z.
You left x and z undefined when calculating noise3:
The correct code is:
The latest commit by melzua is wrong, 'get2D()' doesn't have the form '{x = ..., y = ...}':
Code: Select all
if perlin1:get2d({x, y}) <= 0.53 then
You left x and z undefined when calculating noise3:
Code: Select all
local noise3 = desert_perlin:get2d({x=x+150,y=z+50}) -- Offsets must match minetest mapgen desert perlin.
Code: Select all
--Get snow at position.
local get_snow = function(pos)
--Legacy support.
if weather_legacy == "snow" then
local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
if perlin1:get2d({x=pos.x, y=pos.z}) <= 0.53 then
return false
end
-- disable falling snow in desert
local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3)
local noise3 = desert_perlin:get2d({x=pos.x+150,y=pos.z+50}) -- Offsets must match minetest mapgen desert perlin.
if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45.
return false
end
return true
end
return false
end
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
it should be fixed nowparamat wrote:There's a new bug that was posted as an engine issue on Github https://github.com/minetest/minetest/issues/2672
The latest commit by melzua is wrong, 'get2D()' doesn't have the form '{x = ..., y = ...}':2D noise always uses abstract variables x and y, these then represent world position x and z.Code: Select all
if perlin1:get2d({x, y}) <= 0.53 then
Ivà wrote "Changing the get_snow function code as below solves the crash", so l didn't look for such a mistake.
l changed z to y when l did this commit https://github.com/Splizard/minetest-mo ... 65c046f500paramat wrote:You left x and z undefined when calculating noise3
and x and y are defined
Edit:l just tested falling snow and it worked for me.
- paramat
- Developer
- Posts: 3700
- Joined: Sun Oct 28, 2012 00:05
- GitHub: paramat
- IRC: paramat
- Location: UK
Re: [Mod] Snow Biomes [3.2] [snow]
That will work, but is messy and has unnecessary code, faster to use pos.x and pos.z directly as in my post.
Splizard, please can you remove my push access to this repo? I don't have time to be involved as a mod dev anymore.
Optional snow biomes are now added to 0.4.12dev mgv6 C++ mapgen, add "mgv6_spflags = snowbiomes" to your minetest.conf file.
Splizard, please can you remove my push access to this repo? I don't have time to be involved as a mod dev anymore.
Optional snow biomes are now added to 0.4.12dev mgv6 C++ mapgen, add "mgv6_spflags = snowbiomes" to your minetest.conf file.
-
- Member
- Posts: 115
- Joined: Sun Feb 22, 2015 07:11
- GitHub: melzua
- IRC: melzua
- In-game: melzua
- Location: Catalonia
Re: [Mod] Snow Biomes [3.2] [snow]
Apologise for the mistake, was late at night for me and did a quick fix to solve the crash but I didn't dig more into the code.
So sorry.
So sorry.
- paramat
- Developer
- Posts: 3700
- Joined: Sun Oct 28, 2012 00:05
- GitHub: paramat
- IRC: paramat
- Location: UK
Re: [Mod] Snow Biomes [3.2] [snow]
Hey no problem =)
The abstract internal variables x, y used by 2D perlin noise are often confused with world co-ordinates so it's best they only ever appear inside get2d() as [x = ..., y = ...}.
The abstract internal variables x, y used by 2D perlin noise are often confused with world co-ordinates so it's best they only ever appear inside get2d() as [x = ..., y = ...}.
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
Re: [Mod] Snow Biomes [3.2] [snow]
ok, l edited it.paramat wrote:That will work, but is messy and has unnecessary code, faster to use pos.x and pos.z directly as in my post.
- Splizard
- Member
- Posts: 227
- Joined: Wed Jan 25, 2012 07:20
- GitHub: Splizard
- IRC: Splizard
- In-game: Splizard
- Location: New Zealand
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
@Paramat I have removed your push access as you requested.
@Hybrid Dog nice to see you have been working on snow mod :)
let me know if you want me to release a new version!
@Hybrid Dog nice to see you have been working on snow mod :)
let me know if you want me to release a new version!
Games: Builda City, The Hungry Games Mods: Lifters, Snow Biomes and Gates. Also checkout my texture pack Gridtoon!
- Hybrid Dog
- Member
- Posts: 2836
- Joined: Thu Nov 01, 2012 12:46
- GitHub: HybridDog
-
- Member
- Posts: 940
- Joined: Tue Aug 05, 2014 14:09
- GitHub: MinetestForFun
- IRC: MinetestForFun
- In-game: MinetestForFun
- Location: On earth
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
The Sled doesn't work for me, can you check it please ? :)
(i would create a event with it :p)
(i would create a event with it :p)
MinetestForFun Team mods : [spidermob] [fishing]
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
- Splizard
- Member
- Posts: 227
- Joined: Wed Jan 25, 2012 07:20
- GitHub: Splizard
- IRC: Splizard
- In-game: Splizard
- Location: New Zealand
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
@Minetestforfun
Sleds should be fixed in the latest development version :)
Sleds should be fixed in the latest development version :)
Games: Builda City, The Hungry Games Mods: Lifters, Snow Biomes and Gates. Also checkout my texture pack Gridtoon!
-
- Member
- Posts: 940
- Joined: Tue Aug 05, 2014 14:09
- GitHub: MinetestForFun
- IRC: MinetestForFun
- In-game: MinetestForFun
- Location: On earth
- Contact:
Re: [Mod] Snow Biomes [3.2] [snow]
@Splizard
Thank you very much for this fix :)
Thank you very much for this fix :)
MinetestForFun Team mods : [spidermob] [fishing]
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
---
Our Minetest servers :
MinetestForFun (Survival - PvP - Hardcore)[FR/EN]
MinetestForFun HUNGER GAMES
MinetestForFun SKYBLOCK
MinetestForFun CREATIVE
Who is online
Users browsing this forum: Google [Bot] and 46 guests