[Mod] Unified Inventory [git][unified_inventory]

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Unified Inventory [git][unified_inventory]

by bell07 » Post

As I wrote already in bug request: Agree the privileges should not be irrevocable for single player. But the issue in unified inventory is the second one. In singleplayer I do not need to disallow the cheating for me self. I like cheats. But the cheats should be "hacky" and not regular gameplay functionality implemented as buttons in inventory screen. If I play survival the game experience is broken with unified inventory because the "giveme_1-99" buttons are very near to the "craft_1-99" buttons. The chance for wrong-clicks is high.
So my proposal is to disable all cheating buttons in unified inventory by default in non-creative mode to not touch the expected game experience.
I do not like all cheating buttons, my daughter do not need the giveme buttons but like the set_day button. The other daughter like all buttons. So it will be nice to have a user-preferences-configuration for the cheating buttons. If enabled the UI should further check the permission for the cheat.

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Unified Inventory [git][unified_inventory]

by Wuzzy » Post

@bell07: Everything you said is true. But the “cheating” buttons in UI depend on your privileges.
If you have the “settime” priv, you can set time and day. If you have the “home” priv, you can set a home position and teleport back to it. If you have the “give” or “creative” priv, you can give stuff to yourselves. Each feature is unavailable without those privs.

This works just fine in multiplayer, and your suggestion already works, by using privs.
The real problem is that singleplayer has too many irrevokable default privs. If the list of default privs is reduced, all these issues are removed. Just apply my workaround, then you start off without any of those super features, but you can use “/grant singleplayer” all anytime, of course.

I have also posted pull requests for Minetest and Minetest Game to reduce the list of default singleplayer privs. If they get merged, UI will work out of the box. I tested it. So this shows that the issue lies in Minetest and Minetest Game, and NOT in UI.


EDIT: The priv changes got merged into Minetest. If you download the experimental Minetest developer version from now on, you will as singleplayer only start with minimal privileges (but you can always use “/grantme all”). Which fixes the overpoweredness of UI in singleplayer. :-)
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

New features

by Wuzzy » Post

Recent changes in Unified Inventory:

- Buttons which are useless to you becauce you lack privileges are now disabled and look like this:
Image

- Crafting guide result now shows the “real” item name along the itemstring.
- Enabled “Give me” buttons in Creative Mode and with creative privilege as well
- Unified Inventory hard-depends on default now. :-( Sorry, non-Minetest-Game users, Unified Inventory is now useless for you. It was a nice time having you. Good riddance! xD (I think this should be reverted)
- Bag inventories now have a trash slot


PS: I started a poll about Unified Inventory's bags here: viewtopic.php?f=47&t=15957&p=241076
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Unified Inventory [git][unified_inventory]

by mahmutelmas06 » Post

Why not hide buttons completely instead of making them shadow.
My Mods:

Beverage

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Unified Inventory [git][unified_inventory]

by Wuzzy » Post

Because they could be re-enabled when you get new privs, i.e. at any time in the game. The functionality is not completely gone. Also, the positions of the buttons stay the same at all times.
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Unified Inventory [git][unified_inventory]

by mahmutelmas06 » Post

I think they should be optional buttons. We should able to disable them in options.
Like disable_admin_buttons = true

or you can combine them into a menu.
My Mods:

Beverage

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Unified Inventory [git][unified_inventory]

by Wuzzy » Post

No, mahmutelmas06, this is completely unneccessary IMO. The buttons are simply enabled on a privilege basis:
  • Set time to 6:00: settime
  • Set time to 18:00: settime
  • Go home: home (from Minetest Game)
  • Set home: home (from Minetest Game)
  • Clear inventory: creative (from Unified Inventory), or Creative Mode is enabled
The feature is actually not new (the buttons did not work w/o privs previously as well), it is only an interface change to improve visual feedback.
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
xeranas
Member
Posts: 162
Joined: Fri Feb 05, 2016 11:06

Re: [Mod] Unified Inventory [git][unified_inventory]

by xeranas » Post

I would prefer to pixel art based icons as they would look more "naturally" in minetest. But that's maybe just me.

User avatar
Andrey01
Member
Posts: 2464
Joined: Wed Oct 19, 2016 15:18
GitHub: Andrey2470T
In-game: Andrey01
Location: Russia, Moscow

Re: [Mod] Unified Inventory [git][unified_inventory]

by Andrey01 » Post

VanessaE, what did you write the article still about Unifed Inventory for, if that mod was done earlier by RealBadAngel?

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Unified Inventory [git][unified_inventory]

by mahmutelmas06 » Post

xeranas wrote:I would prefer to pixel art based icons as they would look more "naturally" in minetest. But that's maybe just me.
+1
My Mods:

Beverage

User avatar
ManElevation
Member
Posts: 896
Joined: Tue Aug 02, 2016 22:04
GitHub: ManElevation
IRC: ManElevation
In-game: ManElevation
Location: Madrid,Spain

Re: [Mod] Unified Inventory [git][unified_inventory]

by ManElevation » Post

best inventory ever! and i like the creative priv
My Public Mods! Discord: Rottweiler Games#3368

User avatar
cHyper
Member
Posts: 1014
Joined: Fri May 06, 2011 08:49
GitHub: cHyper-0815OL
IRC: cHyper cHyper_de
In-game: cHyper
Location: Austria
Contact:

Re: [Mod] Unified Inventory [git][unified_inventory]

by cHyper » Post

+1 nice mod...

mase
Member
Posts: 63
Joined: Tue Feb 21, 2017 20:16
In-game: mase

Re: [Mod] Unified Inventory [git][unified_inventory]

by mase » Post

I find it confusing, that mobs are in the crafting guide. This makes the crafting guide
bloating. There should only craftable items shown there.

User avatar
Nathan.S
Member
Posts: 1065
Joined: Wed Sep 24, 2014 17:47
GitHub: NathanSalapat
IRC: NathanS21
In-game: NathanS21
Location: Bigsby Texas
Contact:

Re: [Mod] Unified Inventory [git][unified_inventory]

by Nathan.S » Post

unless you are in creative mod it will only show items that have crafts. In creative mod it will show all he nodes that are registered, otherwise you'd have no way of getting those nodes while in creative.
I record Minetest videos, Mod reviews, Modding tutorials, and Lets plays.
Check out my website, and brand new Minetest Modding Course

mase
Member
Posts: 63
Joined: Tue Feb 21, 2017 20:16
In-game: mase

Re: [Mod] Unified Inventory [git][unified_inventory]

by mase » Post

Yes, you are right. I forgot to disable creative mode. I enabled it to test some new mods.

User avatar
AlexYst
Member
Posts: 107
Joined: Fri Mar 20, 2015 01:24
GitHub: y-st
IRC: AlexYst
In-game: AlexYst
Contact:

Re: [Mod] Unified Inventory [git][unified_inventory]

by AlexYst » Post

Is there any chance a function for generating formspecs could be added? I'm trying to build sub-pages, and need something similar to sfinv.make_formspec(), but for unified_inventory.

User avatar
Fixer
Member
Posts: 899
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer
Location: Ukraine

Re: [Mod] Unified Inventory [git][unified_inventory]

by Fixer » Post

Feature request:
+ add button for sorting items in player inventory (say, if there are gaps - items shifted to left, if there are same blocks - they are merged into one stack, etc)

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Unified Inventory [git][unified_inventory]

by Wuzzy » Post

@y.st.: You can already add pages for Unified Inventory, there's even an API for that, but it is completely undocumented.
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
TumeniNodes
Member
Posts: 2879
Joined: Fri Feb 26, 2016 19:49
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes
Location: in the dark recesses of the mind
Contact:

Re: [Mod] Unified Inventory [git][unified_inventory]

by TumeniNodes » Post

Wuzzy wrote:@y.st.: You can already add pages for Unified Inventory, there's even an API for that, but it is completely undocumented.
Whaaaaa? I didn't know this either. Thanks Wuzzy
Ich mag keine grünen Eier und Schinken, ich mag sie nicht Sam I Am

User avatar
Andrey01
Member
Posts: 2464
Joined: Wed Oct 19, 2016 15:18
GitHub: Andrey2470T
In-game: Andrey01
Location: Russia, Moscow

Re: [Mod] Unified Inventory [git][unified_inventory]

by Andrey01 » Post

Hm... Vanessa, what have you publiced the same mod for if it belongs to RealBadAngel?

KCoombes
Member
Posts: 412
Joined: Thu Jun 11, 2015 23:19
In-game: Knatt
Location: SW Florida, USA

Re: [Mod] Unified Inventory [git][unified_inventory]

by KCoombes » Post

Andrey01 wrote:Hm... Vanessa, what have you publiced the same mod for if it belongs to RealBadAngel?
viewtopic.php?f=3&t=14228&hilit=RealBadAngel

Vanessa is kind enough to continue RBA's work.

User avatar
Wuzzy
Member
Posts: 4140
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Unified Inventory [git][unified_inventory]

by Wuzzy » Post

Someone has a problem with your mod (crash bug?).
viewtopic.php?f=3&t=17896
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH

User avatar
Codesound
Member
Posts: 334
Joined: Thu Jun 09, 2016 14:56

Re: [Mod] Unified Inventory [git][unified_inventory]

by Codesound » Post

Hi,

First: many and many thanks for this amazing mod!

I wanted to ask if it was possible to view in root style all used mods:
when the player click (for example) on the "Advanced Trains" mod,
are shown only the items that are included in this mod.

this is helpful because frequently users play on server
with many pages-mod (like 50 pages, for example)
and when the connection is restricted to 128 kb/s (phone tethering)
is very difficult to manage the pages (or download every time the thumbnails)...

Image

I just wanted to ask if it was possible or
whether it was useful to have this feature


Thanks again for all

R

User avatar
Napiophelios
Member
Posts: 1025
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Mod] Unified Inventory [git][unified_inventory]

by Napiophelios » Post

Codesound wrote:Hi,

...I wanted to ask if it was possible to view in root style all used mods:
when the player click (for example) on the "Advanced Trains" mod,
are shown only the items that are included in this mod....

I just wanted to ask if it was possible or
whether it was useful to have this feature...

I hate flipping through all the pages too :)

The search filter does just what you ask.
Type in the mod name and that's usually what you get.

User avatar
Codesound
Member
Posts: 334
Joined: Thu Jun 09, 2016 14:56

Re: [Mod] Unified Inventory [git][unified_inventory]

by Codesound » Post

Napiophelios wrote:
Codesound wrote:Hi,

...I wanted to ask if it was possible to view in root style all used mods:
when the player click (for example) on the "Advanced Trains" mod,
are shown only the items that are included in this mod....

I just wanted to ask if it was possible or
whether it was useful to have this feature...

I hate flipping through all the pages too :)


The search filter does just what you ask.
Type in the mod name and that's usually what you get.
Hi,

thanks for reply...

I use the filter many times but often I do not know the name of the item or simply I'm writing it wrong ... this is the big difficult for new players that did not know the game or the new mod added. ..

or

I downloaded "digtron" mod:

[Url] viewtopic.php?t=16295 [/ url]

I do not know the name of the item or the list for all items that are in this mod: what do I look for with the filter? ... with the "view the mods in root mode" I see all the items that are in this mod, and I select what I need ... this is very useful for new players (and for all..... or?)

Do I think it really useful either?

Many thanks again,

R

Post Reply

Who is online

Users browsing this forum: drixi and 4 guests