[Mod] Crafting Guide [1.11.4] [craftguide]

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by jp » Sun Jan 12, 2020 22:15

Update: craftguide 1.11.1 released!

This version fixes several bugs and the mod only supports Minetest 5.1 and above from now on.
It is highly recommended to use Minetest 5.2 though.
 

User avatar
Wuzzy
Member
 
Posts: 3791
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by Wuzzy » Mon Jan 13, 2020 01:30

What's Minetest 5.2?
My creations. I gladly accept bitcoins: 17fsUywHxeMHKG41UFfu34F1rAxZcrVoqH
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by FreeGamers » Mon Jan 13, 2020 03:05

I updated and tested the new version, it looks great in the sfinv version.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by FreeGamers » Tue Jan 14, 2020 09:06

I saw an error tonight, not sure what the item was that was clicked on.

Code: Select all
2020-01-14 03:01:37: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: attempt to index field 'usages' (a nil value)
2020-01-14 03:01:37: ERROR[Main]: stack traceback:
2020-01-14 03:01:37: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: in function 'fields'
2020-01-14 03:01:37: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1657: in function <...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1656>
2020-01-14 03:01:37: ERROR[Main]:       (tail call): ?
2020-01-14 03:01:37: ERROR[Main]:       ...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:429: in function <...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:413>
 

User avatar
batnoob
Member
 
Posts: 12
Joined: Mon May 14, 2018 21:28
In-game: TheIncredibleHulk

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by batnoob » Tue Jan 21, 2020 22:40

my singleplayer world crashes (the screen goes gray and I have to close it out) when I am using craftguide in progressive mode and sinv only

relevant logs from debug.txt:
Code: Select all
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:948: in function 'get_panels'
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1120: in function 'make_formspec'
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1651: in function 'get_formspec'
2020-01-21 16:19:24: ERROR[Main]:    ...t\minetest\bin\..\games\minetest_game\mods\sfinv/api.lua:125: in function 'set_player_inventory_formspec'
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1129: in function 'show_fs'
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1635: in function 'fields'
2020-01-21 16:19:24: ERROR[Main]:    ...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1667: in function <...aming\.minetest\minetest\bin\..\mods\craftguide\init.lua:1666>
2020-01-21 16:19:24: ERROR[Main]:    ...ming\.minetest\minetest\bin\..\builtin\game\register.lua:429: in function <...ming\.minetest\minetest\bin\..\builtin\game\register.lua:413>
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by jp » Tue Jan 21, 2020 23:00

FreeGamers and batnoob: can you please tell me precisely which actions predate these crashes?

EDIT: batnoob, I think your copy of the mod may be outdated.
 

User avatar
batnoob
Member
 
Posts: 12
Joined: Mon May 14, 2018 21:28
In-game: TheIncredibleHulk

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by batnoob » Wed Jan 22, 2020 05:09

The copy I got was from the content tab on version 5.1.0, my actions were clicking on an ingredient in the recipe shown to see how to make it, after which the whole window was grayed out, and I had to close it.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by FreeGamers » Wed Jan 22, 2020 20:29

Sorry, I can't provide additional information. I had several reports from people using 5.0.1 that the craftguide has disappeared for them and I rolled back to version 1.10.1 in my server. I didn't anticipate it being that big of an issue for players, but it was. I had more 5.0.1. players than I thought.

I had no additional information to share when the bug initially happened as it happened while I was sleeping and I'm not sure who triggered it and what item they had clicked on.
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by jp » Wed Jan 22, 2020 23:25

I fixed that crash in latest commit. Please test it out.

FreeGamers: I do not provide any further support for 5.0. Tell your users to upgrade.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.1] [craftguide]

by FreeGamers » Thu Jan 23, 2020 02:13

I'm going to wait until the version in Google Play updates because I still get a number of mobile players on that platform. https://play.google.com/store/apps/deta ... t&hl=en_US
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by jp » Sun Feb 02, 2020 23:37

Update: craftguide 1.11.2 released!

This is a boring bugfixing release.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by FreeGamers » Thu Feb 06, 2020 04:35

Saw this today on 1.11.2 in my server log

Code: Select all
2020-02-05 09:17:38: ACTION[Main]: Server: Shutting down
2020-02-05 09:17:38: ACTION[Main]: [mana] Server shuts down. Rescuing data into mana.mt
2020-02-05 09:17:38: ACTION[Main]: [mana] Wrote mana data into /var/games/minetest-server/.minetest/worlds/world//mana.mt.
2020-02-05 09:17:38: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: attempt to index field 'usages' (a nil value)
2020-02-05 09:17:38: ERROR[Main]: stack traceback:
2020-02-05 09:17:38: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: in function 'fields'
2020-02-05 09:17:38: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1658: in function <...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1657>
2020-02-05 09:17:38: ERROR[Main]:       (tail call): ?
2020-02-05 09:17:38: ERROR[Main]:       ...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:429: in function <...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:413>


Then it was recreated by a player

Code: Select all
2020-02-05 09:20:26: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: attempt to index field 'usages' (a nil value)
2020-02-05 09:20:26: ERROR[Main]: stack traceback:
2020-02-05 09:20:26: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1555: in function 'fields'
2020-02-05 09:20:26: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1658: in function <...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1657>
2020-02-05 09:20:26: ERROR[Main]:       (tail call): ?
2020-02-05 09:20:26: ERROR[Main]:       ...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:429: in function <...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:413>


I saw instances of this three more times. Bug was triggered by several players. I'm using the sfinv version of the craftguide.

No one is online right now to survey.

One player left a note on a sign in the game: choosing the second recipe of death compas in craftguide causing servercrash


That recipe looks something like
Code: Select all
if not automatic then
   local display_doc = function(itemstack, user)
      local player_name = user:get_player_name()
      minetest.chat_send_player(player_name, documentation .. "\n" .. durationdesc)
   end

   minetest.register_craftitem("death_compass:inactive", {
      description = S("Death Compass"),
      _doc_items_longdesc = documentation,
      _doc_items_usagehelp = durationdesc,
      inventory_image = "death_compass_inactive.png",
      wield_image = "death_compass_inactive.png",
      stack_max = 1,
        on_place = display_doc,
        on_secondary_use = display_doc,
   })

   minetest.register_craft({
      output = 'death_compass:inactive',
      recipe = {
         {'', 'bones:bones', ''},
         {'bones:bones', 'default:mese_crystal_fragment', 'bones:bones'},
         {'', 'bones:bones', ''}
      }
   })
   
   -- Allow a player to deliberately deactivate a death compass
   minetest.register_craft({
      output = 'death_compass:inactive',
        type = "shapeless",
        recipe = {
            'group:death_compass',
      }
   })

end
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by FreeGamers » Thu Feb 06, 2020 06:05

Also, the number in the "Recipe 1 of 12" doesn't cycle properly for recipes or usages. It is always "1".

I'm rolling back again until there is a bugfix because I saw too many crashes today from this. 5 is a lot. Could just be this particular recipe, but I'm not sure.
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by jp » Thu Feb 06, 2020 12:23

FreeGamers:

1. your mod is not up-to-date. There is no such thing as "usages" on line 1555.
2. I cannot reproduce the issue with browsing recipes.

Also give me a link to the mod of the item that crashes.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by FreeGamers » Thu Feb 06, 2020 15:10

it is up to date. I didn't even have it installed until I download and added 1.11.2 release from your repo. See here https://github.com/minetest-mods/craftg ... .lua#L1555

You can't reproduce the behavior of the recipes not showing numbers/usages? I'm on 5.2-dev, a version from a couple weeks ago or so. My client is 5.1.0. I can ask others to see if maybe it just affects specific client versions.

The recipe crashing the server is part of FaceDeer's death_compass
https://github.com/FaceDeer/death_compa ... a06e3ca21d

I'm now on 1.10.1 now.
 

User avatar
Festus1965
Member
 
Posts: 1108
Joined: Sun Jan 03, 2016 11:58
Location: Thailand - Chiang Mai (+5-6h to MEZ)
In-game: Thomas Explorer Thailand

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by Festus1965 » Thu Feb 06, 2020 21:40

in times of youtube and easy vidorecording of own screen,
should be easy to make screenshot of that one behavior, or a short video from that behavior, 20 sec might be enough to halp others to understand it
Server: still up, see some gamer - but there is a new 1st important thread "climate change" for me.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by FreeGamers » Fri Feb 07, 2020 05:29

Is there something that I've written and reported that warrants video recording, uploading, hosting, and distributing? Writing is pretty efficient and I've conveyed the report, error output, and behavior to cause it. You need a video to understand this? I don't understand your comment or I just disagree bigly.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by FreeGamers » Fri Feb 07, 2020 06:14

JP,

On your current commit, this is the bug:

Code: Select all
2020-02-07 00:10:06: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1557: attempt to index field 'usages' (a nil value)
2020-02-07 00:10:06: ERROR[Main]: stack traceback:
2020-02-07 00:10:06: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1557: in function 'fields'
2020-02-07 00:10:06: ERROR[Main]:       ...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1658: in function <...dev-linux/bin/../mods/lib_player/craftguide/init.lua:1657>
2020-02-07 00:10:06: ERROR[Main]:       (tail call): ?
2020-02-07 00:10:06: ERROR[Main]:       ...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:429: in function <...est-5.2.0-dev-linux/bin/../builtin/game/register.lua:413>


Here is the line of which the error is referring to: https://github.com/minetest-mods/craftg ... .lua#L1557

Recipe indexing in sfinv version still doesnt work well in this version either. It always says "Recipe 1 of X" regardless of which recipe is shown. This is on the version of Minetest 5.1, which is allegedly supported.
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by jp » Fri Feb 07, 2020 12:55

Checked the death compass recipe... I cannot reproduce neither of these bugs. I can't help.
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.2] [craftguide]

by jp » Sun Feb 09, 2020 00:55

I finally narrowed down that crash in sfinv mode. This is fixed in latest commit.
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug
 

User avatar
FreeGamers
Member
 
Posts: 478
Joined: Sat May 25, 2019 00:15
Location: United States
GitHub: is proprietary I use NotABug
 

User avatar
jp
Member
 
Posts: 779
Joined: Wed Dec 18, 2013 09:03
Location: France
GitHub: kilbith

Re: [Mod] Crafting Guide [1.11.3] [craftguide]

by jp » Sun Feb 09, 2020 12:40

Update: craftguide 1.11.3 released!

This is another boring bugfixing release.
 

PreviousNext

Return to Mod Releases



Who is online

Users browsing this forum: Google [Bot] and 20 guests