[Mod] Smart shop 7.11 [smartshop]

[gpcf]

I have continued development, they now only accept via pipeworks the items they sell. Also, they alert you if your stock is empty if the mail mod is installed.

Download under:
https://git.gpcf.eu/?p=smartshop.git

[Fixer]

Download link is back

[scottwolff]

Smart shops. One of my go tos. Decent mod.
I can't understand why some mods and administrators don't like this mod. Supposedly it might've added more lag to my server, but unfounded since the other shops mod we're using didn't seem to make a difference for everyone's overall lag. Asthetically, I think this mod is better than other literal full block bulky ones. It has its own light for goodness sakes!

[shivajiva]

Bugs:
* If a player makes a department store with smartshops the sheer volume of entities causes lag
* Smartshops shouldn't accept admin items or maptools nodes
* Use of type as a variable name masks an existing lua function and is a very bad practice in general
* Line length exceeds acceptable standards

There are probably more mistakes but these are the basic issues with this mod. Feel free to point out anything else you can see wrong :)

[gpcf]

I have added the ability to make statistics on item prices, if the currency mod is enabled.

Get it from http://git.bananach.space/smartshop.git/, zip: http://git.bananach.space/smartshop.git ... master.zip

[Sporax]

Hi,

Axinite (my old minetest server which was take back by 2 new admin, Rafi-59 and Aug-Top) is using this mod. However we have some issues with it!

[BUG REPORT]

-Entities which appeared when a player send something, sometimes they disappear. (we've never used the '/clearobects' command)
-When players send used tools or armor, when someone buy it, it is a new one... i mean without it old use...

It's the better shop we found, then we hope that these bugs will be fixed :), Thanks for all!

[ManElevation]

i get this error and my server crashs every couple of hours
what can i do?

Code: Select all

2018-07-10 16:27:04: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Invalid position (expected table got nil).
2018-07-10 16:27:04: ERROR[Main]: stack traceback:
2018-07-10 16:27:04: ERROR[Main]: 	[C]: in function 'get_meta'
2018-07-10 16:27:04: ERROR[Main]: 	...t12/bin/../games/DistrictPvP/mods/smartshop/init.lua:126: in function 'update_info'
2018-07-10 16:27:04: ERROR[Main]: 	...t12/bin/../games/DistrictPvP/mods/smartshop/init.lua:105: in function 'receive_fields'
2018-07-10 16:27:04: ERROR[Main]: 	...t12/bin/../games/DistrictPvP/mods/smartshop/init.lua:118: in function '?'
2018-07-10 16:27:04: ERROR[Main]: 	...critorio/minetest12/bin/../builtin/game/register.lua:420: in function <...critorio/minetest12/bin/../builtin/game/register.lua:400>

[Krock]

Patch for error above (based on HEAD of https://git.bananach.space/smartshop.git/)
-> http://paste.debian.net/plain/1033133

[shivajiva]

it is a known error and results from a lack of checks on the pos table being passed in the function. Ideally you would redefine pos outside of the functions main conditional as the call is valid for any of the conditions, this allows you to check it's valid and return if not, preventing the crash. Simpler than checking each condition and less code.

I see that's exactly what Krock's patch offers :)

[gpcf]

@krock I merged your patch into my branch and changed the mod to unix line endings in the process.

[AiTechEye]

i get this error and my server crashs every couple of hours
what can i do?

Code: Select all

2018-07-10 16:27:04: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Invalid position 

fixed, empty position, caused by players that left when they where using the shop.

note that, this mod is messing in mt 0.5, maybe cuz the version is unstable, idk


+ added to github
Source
Download

[shivajiva]

created an issue for tool repair bug and suggested a fix :)

[piesquared]

Can you make this tubelib compatable too? Just putting items in, not taking them out. And they would need to be a full block... maybe release a different version, thats tubelib compatable.

[AiTechEye]

currently there is 2 different versions,
the modified edition by gcf
and the original edition by me (v7.11)

which one do you mean?

[ManElevation]

i get this error and my server crashs every couple of hours
what can i do?

Code: Select all

2018-07-10 16:27:04: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Invalid position 

fixed, empty position, caused by players that left when they where using the shop.

note that, this mod is messing in mt 0.5, maybe cuz the version is unstable, idk


+ added to github
Source
Download

ha thx allready fix it but thx its what people needed

[piesquared]

currently there is 2 different versions,
the modified edition by gcf
and the original edition by me (v7.11)

which one do you mean?

You talking to me? I’m saying make a new version, that adds tubelib support. But in order to do that, you would need to make the smartshop block a whole block... otherwise it would just look weird.

[gpcf]

Bug tracker for my version is at: https://bugs.linux-forks.de/smartshop/ some bugs may also apply to the original version. Report feature requests for my version there.

[migifg2003]

does the wifi storage have to be physically connected or is it like wifi and "wireless"

[AiTechEye]

its wireless, and can be connected up to 30 blocks away