Page 1 of 2

[Mod] Simple Arcs [pkarcs] updated for 0.4.16

Posted: Sun May 01, 2016 22:57
by PEAK
I wonder if nobody else had this idea so far: Arcs - for all default stone and plank nodes. They behave like stairs.

Image

There are arcs for outer and inner corners too:

Image

Crafting:

Arcs
Image

Inner Arcs
Image

Outer Arcs
Image

A quick example:
Image

depends: default

Download: see attachment

UPDATE:

Reworked the code (I studied "viaduct" viewtopic.php?f=9&t=14559 -- thanks pithy!)

So the api is much more easy:

To make arcs from nodes of your mod, put "pkarcs?" into your depends.txt,
and call this function in your init.lua:

Code: Select all

if minetest.get_modpath("pkarcs") then
	pkarcs.register_node("your_mod:your_nodename")
end
Another update:
added Aspen Wood Arcs - Minetest 0.4.14
License changed to LGPLv2.1+


Update for Minetest 0.4.15:

- Arcs added for the new stone- sandstone- desertstone- and obsidian-blocks.

- mod.conf added.

- Better placing!
(I don't really understand facedir and param2, but with the code I gathered it works...)
When placed, the hollow side of the arc points to the player (similar to stairs).
When placed on ground, the hollow side points upwards, otherwise (placed under a node or on its side) downwards.
For sidewards arcs you need the screwdriver.

- Compatible with older versions of this mod. (!)


Update for Minetest 0.4.16:

added arcs for

- Desert Sandstone
- Desert Sandstone Block
- Desert Sandstone Brick
- Silver Sandstone
- Silver Sandstone Block
- Silver Sandstone Brick

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 00:52
by KCoombes
+10 Beautiful!

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 02:05
by benrob0329
Very cool!

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 08:05
by Onyx
Hi,

Good work! Compatibility with "moreblocks" is it envisaged in the near future?

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 11:17
by PEAK
Onyx wrote:Compatibility with "moreblocks" is it envisaged in the near future?
Do you mean

1. Compatibility with blocks from moreblocks?
or
2. Compatibility with the circular saw?

1. I think there are only a few blocks that would fit for these shapes - maybe worth considering. There are a lot of other mods that could get arcs for their blocks, but I sought to keep it very basic.

It’s a fundamental question, which other mods a mod should take care of. E.g. shall "stairs" optionally depend on "very_special_blocks" or the other way round? Either are possible, but which is more reasonable?

2. For now I’m to lazy to go into the code of the circular saw. For a while I was using it extensive, but it became annoying. I rather prefer to see all available blocks in the inventory (for creative mode). So I like "stairsio" as well.

Nevertheless I would be glad if moreblocks includes the nodeboxes of the arcs...

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 14:17
by oleastre
First, I really like your mod and what you can create with this.

I just had a quick look at your mod code and you can improve it a little bit, allowing external mods to register new materials (and creating new arcs types).
Just wrap the whole recipes and nodes definitions in a function that takes a line of your materials map as argument and creates arcs for that material.
Then just loop over you materials map and call that function.

Also, the node sound and groups can probably be retrieved from the original node by using the minetest.registered_nodes map (just like it's done in the moreblocks/stairsplus mod).

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 18:55
by Krock
Amazing! I would love to see the feature to place the arcs around the corner and the mod will automatically relpace the regular arc with an edge one.

Also: Are there any plans for a mesh version of this yet? But I'm not sure if it would fit well into the blocky buildings.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon May 02, 2016 21:45
by MineYoshi
Nice +100

If you do a temple and you add those arcs to the corners, the building will be more nice and awesome!

Re: [Mod] Simple Arcs [pkarcs]

Posted: Tue May 03, 2016 10:25
by PEAK
just a few nodeboxes... ;-)
oleastre wrote:I just had a quick look at your mod code and you can improve it a little bit
That’s always welcome.
oleastre wrote:Just wrap the whole recipes and nodes definitions in a function that takes a line of your materials map as argument and creates arcs for that material.
Then just loop over you materials map and call that function.
As yet I made it so:

Code: Select all

if minetest.get_modpath("...") then...
but your suggestion is far more better.
And so my thoughts
It’s a fundamental question, which other mods a mod should take care of...
become pointless.
oleastre wrote:Also, the node sound and groups can probably be retrieved from the original node by using the minetest.registered_nodes map
Indeed I didn’t know this two methods. Thank you very much, I will work on it and report in a few days.
oleastre wrote:(just like it's done in the moreblocks/stairsplus mod).
Damn, I must read more code!
Krock wrote:I would love to see the feature to place the arcs around the corner and the mod will automatically relpace the regular arc with an edge one.
No idea how to do that. That would be fine for stairs too--but may not always be intended.
Krock wrote:Also: Are there any plans for a mesh version of this yet?
I don’t think. That’s something I never dealt with.
Krock wrote:But I'm not sure if it would fit well into the blocky buildings.
Yes, meshnodes are great for decorations as in homedecor. Building materials should well integrate into the default blocks.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Tue May 03, 2016 13:39
by Don
Looks nice. If you want to try a mesh node for the arc you could try the one in mymeshnodes.
https://github.com/DonBatman/mymeshnodes.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Wed May 04, 2016 00:59
by PEAK
I applied oleastre’s suggestions viewtopic.php?f=9&t=14541&p=216103#p215959 to the code. (see edited attachment in first post)

OK. Problem solved. Forget all the following stuff...

It was something like this: viewtopic.php?f=47&t=14389#p213433
Spoiler
For itself it works well, but when I try to apply it to another mod I get errors.

I took
pkpoud: viewtopic.php?t=13755

added "pkarcs?" to its depends.txt

added

Code: Select all

if minetest.get_modpath("pkarcs") then
	pkarcs.register_all(
		"poudstone",
		"Poudlard Stone",
		"pkpoud_poudstone",
		"pkpoud:poudstone",
		minetest.registered_nodes["pkpoud:poudstone"].sounds,
		minetest.registered_nodes["pkpoud:poudstone"].groups
	)
end
to its init.lua (line 112)

errors:

Code: Select all

... ERROR[main]: ========== ERROR FROM LUA ===========
... ERROR[main]: Failed to load and run script from 
... ERROR[main]: /home/albert/.minetest/mods/pkpoud/init.lua:
... ERROR[main]: /usr/share/minetest/builtin/game/register.lua:60: Name pkarcs:poudstone_arc does not follow naming conventions: "modname:" or ":" prefix required
... ERROR[main]: stack traceback:
... ERROR[main]: 	[C]: in function 'error'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:60: in function 'check_modname_prefix'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:98: in function 'register_item'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:165: in function 'register_node'
... ERROR[main]: 	/home/albert/.minetest/mods/pkarcs/init.lua:45: in function 'register_all'
... ERROR[main]: 	/home/albert/.minetest/mods/pkpoud/init.lua:113: in main chunk
... ERROR[main]: ======= END OF ERROR FROM LUA ========
... ERROR[main]: Server: Failed to load and run /home/albert/.minetest/mods/pkpoud/init.lua
... ERROR[main]: ModError: ModError: Failed to load and run /home/albert/.minetest/mods/pkpoud/init.lua
... ERROR[main]: Error from Lua:
... ERROR[main]: /usr/share/minetest/builtin/game/register.lua:60: Name pkarcs:poudstone_arc does not follow naming conventions: "modname:" or ":" prefix required
... ERROR[main]: stack traceback:
... ERROR[main]: 	[C]: in function 'error'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:60: in function 'check_modname_prefix'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:98: in function 'register_item'
... ERROR[main]: 	/usr/share/minetest/builtin/game/register.lua:165: in function 'register_node'
... ERROR[main]: 	/home/albert/.minetest/mods/pkarcs/init.lua:45: in function 'register_all'
... ERROR[main]: 	/home/albert/.minetest/mods/pkpoud/init.lua:113: in main chunk
... ERROR[main]: Siehe debug.txt für Details.
I don’t understand this:
Name pkarcs:poudstone_arc does not follow naming conventions: "modname:" or ":" prefix required
But that should be ok???

The same happens with any other mod I tried.

I can’t figure out where it goes wrong.

(Minetest 0.4.13)

EDIT:

When I try it the other way: make pkarcs soft depend on pkpoud and add the corresponding code to init.lua of pkarcs -- then it works. But I think the first approach should be right. The mods which want arcs should access pkarcs.
---
Don wrote:If you want to try a mesh node for the arc you could try the one in mymeshnodes.
Thank you--perhaps later.

Mod updated

Posted: Fri May 06, 2016 17:51
by PEAK
see first post.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Thu May 26, 2016 17:12
by TumeniNodes
Awesome!

Re: [Mod] Simple Arcs [pkarcs]

Posted: Thu May 26, 2016 19:29
by u34
+1

Re: [Mod] Simple Arcs [pkarcs]

Posted: Thu May 26, 2016 21:00
by Damien
Image
. \∼❈∼/ MOTHER
... ||| |||of
... ||| |||ARCHITECTURE

Re: [Mod] Simple Arcs [pkarcs]

Posted: Thu May 26, 2016 22:53
by Fixer
Nice mod! I think you can even adapt for every block like moreblocks mod does.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Wed Jun 08, 2016 21:06
by PEAK
Fixerol wrote:I think you can even adapt for every block like moreblocks mod does.
I tried this, but my attempt didn’t work--my lua skills are not sufficient to understand how to do it.

I must study more code of other mods.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Wed Jun 08, 2016 21:32
by philipbenr
@PEAK: Aren't those weird craft recipes? Just saying... unless the nodes light up, torches are not a very good choice.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Wed Jun 08, 2016 22:06
by PEAK
philipbenr wrote:@PEAK: Aren't those weird craft recipes? Just saying... unless the nodes light up, torches are not a very good choice.
I referenced to stairsio viewtopic.php?t=13018

Re: [Mod] Simple Arcs [pkarcs]

Posted: Wed Jun 08, 2016 23:52
by philipbenr
But that still doesn't make it not odd... Try a something like this:

SSS
S
S

SSS
SS
S

SS
S

Re: [Mod] Simple Arcs [pkarcs]

Posted: Fri Jul 15, 2016 03:13
by Sokomine
Very nice! And the sample building is also quite impressive. Thanks for the mod! And it would be great to have it supported by the circular saw and similar mods.

Re: [Mod] Simple Arcs [pkarcs]

Posted: Fri Jan 20, 2017 03:56
by PEAK
Bump! Update for Minetest 0.4.15

see first post

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon Jun 05, 2017 14:58
by BirgitLachner
Do have your mod on github? It would be nice to follow him :-)

Re: [Mod] Simple Arcs [pkarcs]

Posted: Mon Jun 05, 2017 20:17
by PEAK
Thank you for your interest in my mod.
BirgitLachner wrote:Do have your mod on github? It would be nice to follow him :-)
No, I think such a simple thing is not worth the effort.

By the way: just updated for Minetest 0.4.16! See attachment of first post.

Re: [Mod] Simple Arcs [pkarcs] updated for 0.4.16

Posted: Mon Jun 05, 2017 20:26
by v-rob
This is a really cool mod -- useful for so many things!

I refurbished a dungeon with it. It looks really cool.

http://imgur.com/a/c3WNv