[Mod] Advanced Trains [advtrains] [2.1.4]

hlqkj
Member
Posts: 19
Joined: Wed Dec 11, 2019 20:10
GitHub: hlqkj
IRC: hlqkj
In-game: hlqkj

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by hlqkj » Post

Add ATC "K" command
This command kicks out all passengers when the train is stopped and
its doors are open. In addtion, a wagon:is_driver_stand(seat) function
was added to allow finding out easily if a seat is the driver stand of
the wagon.
Y'all are awesome, thank you so much! : )
Quando omni flunkus, moritati.

User avatar
orwell
Member
Posts: 858
Joined: Wed Jun 24, 2015 18:45
GitHub: orwell96
IRC: orwell96_mt
In-game: orwell
Location: Raxacoricofallapatorius

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by orwell » Post

Version 2.2.0 released

Image

Important changes:
- Redesign of Train Head-Up Display (thanks, ywang)
- New ATC 'K' command to kick all players out of trains (useful for terminal stations, also supported by stop rail) (thanks, gpcf)
- New save format, which eliminates the LuaJIT problem when the save files get too large, and is slightly faster.

Action needed:
- The advtrains package contains a new mod 'serialize_lib', which needs to be enabled, else advtrains will not load.
- Once a world is first started with 2.2.0, save files will be automatically migrated. The new save format is incompatible with previous versions, so you can not downgrade straightforward (it is possible to restore the state before the migration, info on request).
- Optional: to reduce clutter in the world directory (and in backups), once the saves are migrated (e.g. world started and shut down a single time) all "advtrains_*" files except advtrains_version and files ending in .ls are no longer required.

Unrelated announcement:
The bug tracker server (bugs.linux-forks.de) is undergoing maintenance in the next few days, and will probably not be accessible.
Attachments
screenshot_20210113_101616_x.png
(107.89 KiB) Not downloaded yet
Lua is great!
List of my mods
I like singing. I like dancing. I like ... niyummm...

W3RQ01
Member
Posts: 12
Joined: Sat Nov 28, 2020 06:33

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by W3RQ01 » Post

Finally the new release XD

User avatar
amelaye
Member
Posts: 11
Joined: Sun Jun 14, 2020 10:47
GitHub: amelaye
Contact:

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by amelaye » Post

Hi, i got an issue with advtrains_netmapper.
I looked at the version of lua, 5.1 so ok.
The log is ok :

Code: Select all

amelaye@drakarys:~/.minetest/mods/advtrains/lifo-advtrains_netmapper$ luajit main.lua  ../../../worlds/adventure/
nodedb: read	3360	nodes.
Progress 3305+15/3360=98%
Wrote	126	polylines. Processed	3305	track,	15	non-track nodes out of	3360
Drew 11 trains. 10 stopped trains.

 Number of trains moving/total:
1:            1/2
But my image is blank !
Why ?
Thanks !
My server : amelaye.ddns.net:30000 - My website : http://minetest.amelieonline.net

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by Blockhead » Post

amelaye wrote:
Fri Jan 15, 2021 21:09
But my image is blank !
Why ?
Thanks !
Have you checked the actual SVG output file? If that is not blank, the problem is not that it's blank, it's that the lines are so thin you can't see them. Open the SVG in an editor that allows a high level of zoom (so not e.g. Firefox). Zoom in a bit and scroll around. If after this advice you still can't find anything, we may have a bug.

I'm going to take this opportunity to mention my own branch of netmapper that draws more stuff like station/stop rails, scrapes LuaATC rails, handles linetrack, and draws TCBs. However, it is probably not compatible with the latest serialisation format on advtrains master (more info on that here, additional to the 2.2.0 release announcement).

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

2.2.0: remember to enable serialize_lib

by Blockhead » Post

I hope nobody saw this post before I edited it..

Don't forget to enable serialize_lib on your world people!

Image
Attachments
screenshot_20210116_111025.jpg
(400.2 KiB) Not downloaded yet

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

Bug report: windows saving issues with 2.2.0

by Blockhead » Post

Sorry to triple post but.. the bug tracker is still down, and I needed to file this bug report.

Despite good efforts for operating system portability in 2.2.0's
serialize_lib, Windows is having some trouble with the saving. Here
are the relevant parts of my minetest log file after starting my
world, which should be migrating from v3 to v4 saves:

Code: Select all

2021-01-16 12:40:56: WARNING[Main]: Undeclared global variable
"trainblocks_disable_recipes" accessed at
...\minetest-5.2.0-win64\bin\..\mods\trainblocks\init.lua:14
2021-01-16 12:40:56: ACTION[Main]: [advtrains] Loading...
2021-01-16 12:40:56: ACTION[Main]: [advtrains] Loaded in 10ms
2021-01-16 12:40:56: WARNING[Main]: Undeclared global variable
"intllib" accessed at
...4\bin\..\mods\advtrains\advtrains_luaautomation\init.lua:6
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_version
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading savefiles version 3
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_tcbs
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_rs_locks
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_rs_callbacks
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_signalass
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_npr_rails
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_influence_points
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_ts
2021-01-16 12:40:57: ACTION[Main]: World at
[[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain]
2021-01-16 12:40:57: ACTION[Main]: Server for gameid="minetest"
listening on 0.0.0.0:50504.
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_wagon_save
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ptmap
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_version
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atc
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_trains
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines
2021-01-16 12:40:57: ACTION[Server]: [advtrains]nodedb: Loading pre v4 format
2021-01-16 12:40:57: ACTION[Server]: [advtrains]nodedb (ndb2 format):
read 2461 nodes.
2021-01-16 12:40:57: ACTION[Server]: [advtrains][lines][rwt]
Initialized railway time:  215;14;59
2021-01-16 12:40:57: ACTION[Server]: [advtrains][lines][scheduler]
Loaded the schedule queue, 0 items.
2021-01-16 12:40:57: ACTION[Server]: [atlatc] Loading pre-v4 save file
2021-01-16 12:40:57: WARNING[Server]: Undeclared global variable
"advtrains_itm_init" accessed at
...est-5.2.0-win64\bin\..\mods\advtrains\advtrains\init.lua:629
2021-01-16 12:40:57: ACTION[Server]: [advtrains][load_all]Loaded
advtrains save files
2021-01-16 12:40:57: WARNING[Server]: Undeclared global variable
"advtrains_itm_mainloop" accessed at
...est-5.2.0-win64\bin\..\mods\advtrains\advtrains\init.lua:596
2021-01-16 12:41:09: ACTION[Server]: singleplayer [127.0.0.1] joins
game. List of players: singleplayer
2021-01-16 12:41:09: ACTION[Main]: [cs_waypoints] CSM cs_waypoints 2.5
loading...
2021-01-16 12:42:04: ACTION[Server]: [serialize_lib] (?): Enabling
Windows mode for atomic saving...
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls:
No such file or directory
2021-01-16 12:42:04: WARNING[Server]: [advtrains]Saving failed:
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:09: ACTION[Main]: Server: Shutting down
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls:
No such file or directory
2021-01-16 12:42:09: WARNING[Main]: [advtrains]Saving failed:
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory

caosfan
New member
Posts: 1
Joined: Fri Jan 15, 2021 15:21

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by caosfan » Post

Seems amazing

User avatar
amelaye
Member
Posts: 11
Joined: Sun Jun 14, 2020 10:47
GitHub: amelaye
Contact:

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by amelaye » Post

Blockhead wrote:
Fri Jan 15, 2021 23:45
amelaye wrote:
Fri Jan 15, 2021 21:09
But my image is blank !
Why ?
Thanks !
Have you checked the actual SVG output file? If that is not blank, the problem is not that it's blank, it's that the lines are so thin you can't see them. Open the SVG in an editor that allows a high level of zoom (so not e.g. Firefox). Zoom in a bit and scroll around. If after this advice you still can't find anything, we may have a bug.

I'm going to take this opportunity to mention my own branch of netmapper that draws more stuff like station/stop rails, scrapes LuaATC rails, handles linetrack, and draws TCBs. However, it is probably not compatible with the latest serialisation format on advtrains master (more info on that here, additional to the 2.2.0 release announcement).
Ho yes ! I see the lines, they're VERY thin !
I'm gonna edit them with Gimp.
Thank you :)
My server : amelaye.ddns.net:30000 - My website : http://minetest.amelieonline.net

User avatar
orwell
Member
Posts: 858
Joined: Wed Jun 24, 2015 18:45
GitHub: orwell96
IRC: orwell96_mt
In-game: orwell
Location: Raxacoricofallapatorius

Re: Bug report: windows saving issues with 2.2.0

by orwell » Post

Issue with save file migration on windows:
Blockhead wrote:
Sat Jan 16, 2021 07:32
Sorry to triple post but.. the bug tracker is still down, and I needed to file this bug report.

Despite good efforts for operating system portability in 2.2.0's
serialize_lib, Windows is having some trouble with the saving. Here
are the relevant parts of my minetest log file after starting my
world, which should be migrating from v3 to v4 saves:

Code: Select all

2021-01-16 12:42:04: ACTION[Server]: [serialize_lib] (?): Enabling
Windows mode for atomic saving...
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
I have fixed this issue. For anyone who is on windows and has the same problem, please download this version:
EDIT: This doesn't work, see below
Last edited by orwell on Mon Jan 18, 2021 14:22, edited 1 time in total.
Lua is great!
List of my mods
I like singing. I like dancing. I like ... niyummm...

SlavaArduino12345
New member
Posts: 6
Joined: Sun Jan 17, 2021 09:48
In-game: SlavaArduino12345 RomeoRomeo

Re: Bug report: windows saving issues with 2.2.0

by SlavaArduino12345 » Post

Blockhead wrote:
Sat Jan 16, 2021 07:32
Sorry to triple post but.. the bug tracker is still down, and I needed to file this bug report.

Despite good efforts for operating system portability in 2.2.0's
serialize_lib, Windows is having some trouble with the saving. Here
are the relevant parts of my minetest log file after starting my
world, which should be migrating from v3 to v4 saves:

Code: Select all

2021-01-16 12:40:56: WARNING[Main]: Undeclared global variable
"trainblocks_disable_recipes" accessed at
...\minetest-5.2.0-win64\bin\..\mods\trainblocks\init.lua:14
2021-01-16 12:40:56: ACTION[Main]: [advtrains] Loading...
2021-01-16 12:40:56: ACTION[Main]: [advtrains] Loaded in 10ms
2021-01-16 12:40:56: WARNING[Main]: Undeclared global variable
"intllib" accessed at
...4\bin\..\mods\advtrains\advtrains_luaautomation\init.lua:6
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_version
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading savefiles version 3
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_tcbs
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_rs_locks
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_rs_callbacks
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_signalass
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_npr_rails
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_influence_points
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking_ts
2021-01-16 12:40:57: ACTION[Main]: World at
[[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain]
2021-01-16 12:40:57: ACTION[Main]: Server for gameid="minetest"
listening on 0.0.0.0:50504.
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_wagon_save
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ptmap
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_version
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atc
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_trains
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb
2021-01-16 12:40:57: ACTION[Server]: [advtrains] loading
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines
2021-01-16 12:40:57: ACTION[Server]: [advtrains]nodedb: Loading pre v4 format
2021-01-16 12:40:57: ACTION[Server]: [advtrains]nodedb (ndb2 format):
read 2461 nodes.
2021-01-16 12:40:57: ACTION[Server]: [advtrains][lines][rwt]
Initialized railway time:  215;14;59
2021-01-16 12:40:57: ACTION[Server]: [advtrains][lines][scheduler]
Loaded the schedule queue, 0 items.
2021-01-16 12:40:57: ACTION[Server]: [atlatc] Loading pre-v4 save file
2021-01-16 12:40:57: WARNING[Server]: Undeclared global variable
"advtrains_itm_init" accessed at
...est-5.2.0-win64\bin\..\mods\advtrains\advtrains\init.lua:629
2021-01-16 12:40:57: ACTION[Server]: [advtrains][load_all]Loaded
advtrains save files
2021-01-16 12:40:57: WARNING[Server]: Undeclared global variable
"advtrains_itm_mainloop" accessed at
...est-5.2.0-win64\bin\..\mods\advtrains\advtrains\init.lua:596
2021-01-16 12:41:09: ACTION[Server]: singleplayer [127.0.0.1] joins
game. List of players: singleplayer
2021-01-16 12:41:09: ACTION[Main]: [cs_waypoints] CSM cs_waypoints 2.5
loading...
2021-01-16 12:42:04: ACTION[Server]: [serialize_lib] (?): Enabling
Windows mode for atomic saving...
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls:
No such file or directory
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls:
No such file or directory
2021-01-16 12:42:04: WARNING[Server]: [advtrains]Saving failed:
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:09: ACTION[Main]: Server: Shutting down
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_interlocking.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_core.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_lines.ls:
No such file or directory
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls':
2021-01-16 12:42:09: ERROR[Main]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_ndb4.ls:
No such file or directory
2021-01-16 12:42:09: WARNING[Main]: [advtrains]Saving failed:
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
I have same problem!

SlavaArduino12345
New member
Posts: 6
Joined: Sun Jan 17, 2021 09:48
In-game: SlavaArduino12345 RomeoRomeo

Re: Bug report: windows saving issues with 2.2.0

by SlavaArduino12345 » Post

orwell wrote:
Sun Jan 17, 2021 09:37
Issue with save file migration on windows:
Blockhead wrote:
Sat Jan 16, 2021 07:32
Sorry to triple post but.. the bug tracker is still down, and I needed to file this bug report.

Despite good efforts for operating system portability in 2.2.0's
serialize_lib, Windows is having some trouble with the saving. Here
are the relevant parts of my minetest log file after starting my
world, which should be migrating from v3 to v4 saves:

Code: Select all

2021-01-16 12:42:04: ACTION[Server]: [serialize_lib] (?): Enabling
Windows mode for atomic saving...
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?): Unable to
delete old savefile
'[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls':
2021-01-16 12:42:04: ERROR[Server]: [serialize_lib] (?):
[redacted]\minetest-5.2.0-win64\bin\..\worlds\ThereIsNoTrain/advtrains_atlatc.ls:
No such file or directory
I have fixed this issue. For anyone who is on windows and has the same problem, please download this version:
http://git.bananach.space/advtrains.git ... e441b6.zip
Thank you orwell!

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

Actual fix for 2.2.0 on windows

by Blockhead » Post

Hi, I found the root cause of the issue for saving, and I'm honestly not sure why it was working on linux (haven't tested it on there yet). I do know I'm quite sure I know why the save was failing on windows: the file to be renamed was still open.

orwell, I have tried to email my patches to the sourcehut list and to you personally but the email might not arrive due to my name given on the email headers, being the commiter name "Blockhead", not matching my real name as provided by my email provider. Eventually I'm going to sort this out when I get a real website and mail server going..

The changes are: revert 7fa1a402 (useless) and add this one line to serialize_lib:

Code: Select all

---
 serialize_lib/serialize.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/serialize_lib/serialize.lua b/serialize_lib/serialize.lua
index a525e9e..12a26c4 100644
--- a/serialize_lib/serialize.lua
+++ b/serialize_lib/serialize.lua
@@ -190,6 +190,7 @@ local function write_to_fd(root_table, file, config)
 	file:write("LUA_SER v=1\n")
 	write_table(root_table, file, config)
 	file:write("E\nEND_SER\n")
+	file:close()
 end
 
 -- Reads the file contents from the passed file descriptor and returns the table on success
Edit: I've also pushed the fix to a branch fix_ser on my GitHub in case you feel like just pulling from there.

SlavaArduino12345
New member
Posts: 6
Joined: Sun Jan 17, 2021 09:48
In-game: SlavaArduino12345 RomeoRomeo

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by SlavaArduino12345 » Post

2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Unable to replace save file 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls' by direct renaming:
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls.new: Permission denied
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Enabling Windows mode for atomic saving...
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): Unable to delete old savefile 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls':
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls: No such file or directory
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Trying to replace the save file anyway now...
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): Unable to replace save file 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls':
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls.new: Permission denied
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): Unable to delete old savefile 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_interlocking.ls':
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_interlocking.ls: No such file or directory
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Trying to replace the save file anyway now...
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): Unable to replace save file 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_interlocking.ls':
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_interlocking.ls.new: Permission denied
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): Unable to delete old savefile 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_core.ls':
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_core.ls: No such file or directory
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Trying to replace the save file anyway now...
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): Unable to replace save file 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_core.ls':
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_core.ls.new: Permission denied
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): Unable to delete old savefile 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_lines.ls':
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_lines.ls: No such file or directory
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Trying to replace the save file anyway now...
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): Unable to replace save file 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_lines.ls':
2021-01-17 18:59:00: ERROR[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_lines.ls.new: Permission denied
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): Unable to delete old savefile 'D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_ndb4.ls':
2021-01-17 18:59:00: WARNING[Server]: [serialize_lib] (?): D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_ndb4.ls: No such file or directory
2021-01-17 18:59:00: ACTION[Server]: [serialize_lib] (?): Trying to replace the save file anyway now...
2021-01-17 18:59:00: WARNING[Server]: [advtrains]Saving failed: D:\minetest-5.3.0-win64\bin\..\worlds\metro/advtrains_atlatc.ls.new: Permission denied
Hm. Problem is not solved :/

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by Blockhead » Post

SlavaArduino12345 wrote:
Sun Jan 17, 2021 17:06
Hm. Problem is not solved :/
Please try my branch on GitHub. I was getting the same errors. Download here.

User avatar
orwell
Member
Posts: 858
Joined: Wed Jun 24, 2015 18:45
GitHub: orwell96
IRC: orwell96_mt
In-game: orwell
Location: Raxacoricofallapatorius

Re: Actual fix for 2.2.0 on windows

by orwell » Post

Blockhead wrote:
Sun Jan 17, 2021 14:54
Hi, I found the root cause of the issue for saving, and I'm honestly not sure why it was working on linux (haven't tested it on there yet). I do know I'm quite sure I know why the save was failing on windows: the file to be renamed was still open.
Thank you for investigating. I applied your patch in upstream. In fact, I didn't get any emails from you, I just applied it manually since it's damn simple.

However I kept 7fa1a40. The reason is that there exists a corner case that would cause a problem: imagine advtrains_core.ls exists, but advtrains_atlatc.ls does not. It switches to windows mode because moving advtrains_core.ls fails, but is subsequently unable to delete advtrains_atlatc.ls because this file doesn't exist. This can happen when luaautomation (or one of the other modules) was initially disabled and is enabled later, because saves for not-enabled modules are no longer overwritten. Also, it now logs why moving fails in the first term (you see that it's "Permission Denied" what I didn't knew then).

Windows saving issue now really fixed:
Download: http://git.bananach.space/advtrains.git ... d63fa7.zip
Lua is great!
List of my mods
I like singing. I like dancing. I like ... niyummm...

SlavaArduino12345
New member
Posts: 6
Joined: Sun Jan 17, 2021 09:48
In-game: SlavaArduino12345 RomeoRomeo

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by SlavaArduino12345 » Post

Give me, please, .blend model of subway train! I wanna make some textures

User avatar
Blockhead
Member
Posts: 56
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
In-game: Blockhead
Location: Land Down Under

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by Blockhead » Post

SlavaArduino12345 wrote:
Mon Jan 18, 2021 15:46
Give me, please, .blend model of subway train! I wanna make some textures
You don't need the .blend to work on the texture, though it helps. Sadly, the .blend for the current model isn't in the assets directory anywhere. You need to import advtrains/advtrains_train_subway/models/advtrains_subway_wagon.b3d with a b3d importer like the one in blender 2.8x. Having that will help you make the texture.

Mind you, watch out, I have been planning to release this 'bettersubway' branch for a while but never got around to it. here's some screenshots:

Note how the stripe on the inside matches the colour of the line number as display on the front.

Give it a review on my GitHub.

Image
Image
Attachments
screenshot_20210119_200831.jpg
(254.35 KiB) Not downloaded yet
bettersubway_spread.jpg
(301.91 KiB) Not downloaded yet
Last edited by Blockhead on Tue Jan 19, 2021 09:48, edited 1 time in total.

SlavaArduino12345
New member
Posts: 6
Joined: Sun Jan 17, 2021 09:48
In-game: SlavaArduino12345 RomeoRomeo

Re: [Mod] Advanced Trains [advtrains] [2.1.4]

by SlavaArduino12345 » Post

Thank you

User avatar
Sharpik
Member
Posts: 12
Joined: Tue Feb 04, 2020 21:27
GitHub: Sharpik
Location: Prague, Czech Republic

Re: Actual fix for 2.2.0 on windows

by Sharpik » Post

orwell wrote:
Mon Jan 18, 2021 14:40
Blockhead wrote:
Sun Jan 17, 2021 14:54
Hi, I found the root cause of the issue for saving, and I'm honestly not sure why it was working on linux (haven't tested it on there yet). I do know I'm quite sure I know why the save was failing on windows: the file to be renamed was still open.
Thank you for investigating. I applied your patch in upstream. In fact, I didn't get any emails from you, I just applied it manually since it's damn simple.

However I kept 7fa1a40. The reason is that there exists a corner case that would cause a problem: imagine advtrains_core.ls exists, but advtrains_atlatc.ls does not. It switches to windows mode because moving advtrains_core.ls fails, but is subsequently unable to delete advtrains_atlatc.ls because this file doesn't exist. This can happen when luaautomation (or one of the other modules) was initially disabled and is enabled later, because saves for not-enabled modules are no longer overwritten. Also, it now logs why moving fails in the first term (you see that it's "Permission Denied" what I didn't knew then).

Windows saving issue now really fixed:
Download: http://git.bananach.space/advtrains.git ... d63fa7.zip
Hi, please fix it on Content DB too.

Thanks

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests