[Mod] Bonemeal [1.7] [bonemeal]

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

@roscoeb - the above errors seem to come from a 'bone' mod and not bonemeal, and the line numbers in question have nothing to do with the actual errors when compared to bonemeal mod itself. Which version of Minetest are you using ?

roscoeb
Member
Posts: 16
Joined: Fri Jan 21, 2022 22:27

Re: [Mod] Bonemeal [1.1] [bonemeal]

by roscoeb » Post

hi thanks for replying
i am using 5.4.1

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Upodate:

by TenPlus1 » Post

- Added chance of jungle grass when used on rainforest litter (thanks Nixnoxus)

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

Could you add support for dfcaverns plants and trees?

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added initial support for dfcavern's saplings.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: Update:

by alerikaisattera » Post

TenPlus1 wrote:
Thu Jun 30, 2022 08:14
- Added initial support for dfcavern's saplings.
-Nether Cap sapling is missing
-Tunnel Tubes only grow fruiting body without stem or nothing at all
-Growing a Fungiwood does not remove the sapling
-Growing a Tower Cap replaces a few nodes around the base with Tower Cap Stem (this is part of df_trees.spawn_tower_cap)
-Same for Black Caps (possibly also for Goblin Caps but I don't have any to test)

Another problem is that all dfcaverns plants and trees grow in the dark and die in bright light, but this mod requires light level above certain point. Not sure how this should be addressed

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Add initial support for dfcavern's crops
- Restart any crop timers after bonemeal
- Add crop exists and fully grown check
- Fix Fungiwood sapling removal

Note: Some plants/crops have not been added as yet from dfcaverns as they have special growth needs the bonemeal api may need amended to add. As for crops/saplings growing in the dark, lets just say for now that bonemeal needs some light to work :)

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: Update:

by alerikaisattera » Post

TenPlus1 wrote:
Thu Jun 30, 2022 12:03
- Add initial support for dfcavern's crops
- Restart any crop timers after bonemeal
- Add crop exists and fully grown check
- Fix Fungiwood sapling removal

Note: Some plants/crops have not been added as yet from dfcaverns as they have special growth needs the bonemeal api may need amended to add. As for crops/saplings growing in the dark, lets just say for now that bonemeal needs some light to work :)
I have an idea on how to make growing these plants in dark properly. I will write code for it a few days later

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

A way to implement growing dfcaverns plants in dark is replacing this part:

Code: Select all

        if (minetest.get_node_light(pos) or 0) < (12 - (strength * 3)) then
	    return
	end
with this:

Code: Select all

    if minetest.get_item_group(node.name, "light_sensitive_fungus") > 0 then
        if (minetest.get_node_light(pos) or 0) > (strength * 3) then
            return
	end
    else if (minetest.get_node_light(pos) or 0) < (12 - (strength * 3)) then
        return
    end

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added ignore_light flag for crop and sapling growth
- Updated dfcavern saplings and crops to use new flag
- Added ability to use "group:" for sapling soil check
- Added dfcavern's nether cap sapling which uses "group:" check
- Tidied code

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: Update:

by alerikaisattera » Post

TenPlus1 wrote:
Fri Jul 01, 2022 10:25
- Added ignore_light flag for crop and sapling growth
- Updated dfcavern saplings and crops to use new flag
- Added ability to use "group:" for sapling soil check
- Added dfcavern's nether cap sapling which uses "group:" check
- Tidied code
It seems that code for Nether Cap is wrong. This mod implements growing Nether Cap on another Nether Cap blocks, but df_trees requires growing Nether Cap on "cools_lava" group blocks that are not Nether Cap. In addition, much like Tower Cap and Black Cap, the node on which the tree grows is replaced with stem
Last edited by alerikaisattera on Fri Jul 01, 2022 11:11, edited 3 times in total.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: Update:

by alerikaisattera » Post

Accidental double post

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

@alerikaisattera - Oops! I forgot to add the entry for group:cools_lava, has been added now.

As for the node being replaced by the stems, that's up to the growing functions used by the df_trees mod itself.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

TenPlus1 wrote:
Fri Jul 01, 2022 11:32
@alerikaisattera - Oops! I forgot to add the entry for group:cools_lava, has been added now.

As for the node being replaced by the stems, that's up to the growing functions used by the df_trees mod itself.
Good, but growing Nether Caps on other Nether Caps blocks should be removed (ideally prevented much like in df_trees itself, but this may require other modifications).

Could you also add df_primordial_items plants?

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

I only follow the growing mediums set by the mods themselves, and yes I'll try to cover as much plantlife as possible if the mod maker doesn't use the bonemeal api to do so themselves.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

Could you add the remaining dfcaverns plants (Spindlestems, Torchspines, Bloodthorns, Primordial small plants)?

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

The Spindlestems, Torchspine and Bloodthorn have no clear growth function or sapling for use with bonemeal and FaceDeer has been notified of this for future additions. Primordial small plants are added though.
Last edited by TenPlus1 on Fri Jul 08, 2022 08:22, edited 1 time in total.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

TenPlus1 wrote:
Fri Jul 08, 2022 07:25
The Spindlestems, Torchspine and Bloodthorn have no clear growth function or sapling for use with bonemeal and FaceDeer has been notified of this for future additions. Primordial small plants are being looked at though.
Bloodthorns have df_trees.grow_blood_thorn function and are a lot like cacti

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

Could you also add Primordial fungal plants from df_primordial_items? Tunnel Tubes also don't work properly

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added df_trees Bloodthorns
- Added df_primordial_items Fungal deco
- Fixed df_trees Tunnel Tube

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

Does not work on Bloodthorns, they just die

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

@alerikaisattera - remember they are light sensative.

alerikaisattera
Member
Posts: 62
Joined: Mon May 02, 2022 11:03
GitHub: alerikaisattera

Re: [Mod] Bonemeal [1.1] [bonemeal]

by alerikaisattera » Post

They die in dark when bonemeal is used on them

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Bonemeal [1.1] [bonemeal]

by TenPlus1 » Post

I've tested bloodthorn above ground and below and they are still growing even after using bonemeal on them.

User avatar
TenPlus1
Member
Posts: 3714
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added new crops from Farming Redo (asparagus, spinach, eggplant)

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 2 guests