[Mod] Engraving Table - Change Item Descriptions [engrave]

[orwell]

1.0.2
Multiline input is now possible. Of course only with the privilege!

[azekill_DIABLO]

+1

[BBmine]

What mod are you using to show the lag in the corner?

[orwell]

Thats my own mod, i haven't published it
It is mainly a mixture of chat commands I use often and some other utilities. I have contributed the chat commands to the [morecommands] mod

[BBmine]

Thats my own mod, i haven't published it
It is mainly a mixture of chat commands I use often and some other utilities. I have contributed the chat commands to the [morecommands] mod

Are you gonna publish it?

[v-rob]

I got this problem.

Code: Select all

2017-05-17 22:04:22: ERROR[Main]: ServerError: Lua: Runtime error from mod 'default' in callback item_OnPlace(): C:\games\minetest-0.4.15-win64\bin\..\mods\engrave\init.lua:29: attempt to call method 'get_meta' (a nil value)
2017-05-17 22:04:22: ERROR[Main]: stack traceback:
2017-05-17 22:04:22: ERROR[Main]: 	C:\games\minetest-0.4.15-win64\bin\..\mods\engrave\init.lua:29: in function 'on_rightclick'
2017-05-17 22:04:22: ERROR[Main]: 	...test-0.4.15-win64\bin\..\builtin\common\misc_helpers.lua:381: in function 'rotate_and_place'
2017-05-17 22:04:22: ERROR[Main]: 	...test-0.4.15-win64\bin\..\builtin\common\misc_helpers.lua:464: in function <...test-0.4.15-win64\bin\..\builtin\common\misc_helpers.lua:463>

I am using 0.4.15 stable.

[wilkgr76]

Use a dev/daily build

[echosa]

I added this to my game to label a specific item, but that item doesn't work with the engraving table. I'm hoping this can be fixed.

The item that doesn't work is the mirror of returning, from this mod: viewtopic.php?f=11&t=11224

The problem is, you have to right-click the engraving table with the item, but the mirror already does something on right-click (it sets the mirror's teleport location).

Can the engraving table be made to work with items that already have a right-click? Unfortunately, this seems to be a general issue with Minetest, as you can't open chests when holding an item with a right-click function, either. :-(

Also, if you right-click the engraving table when not holding anything, it says to hold something then click again. It should probably say to hold something then "right-click again" instead, for clarity. Just a thought.

[wilkgr76]

echosa, try holding sneak while rightclicking the table

[echosa]

I did try holding sneak, and I tried it again just now. It doesn't work.

[texmex]

I belive the engraving table would gain from looking much more apart from the well established crafting tables available. I've looked for real counterpart engraving tables and they don't seem common. What does seem common are engraving machines, and for the low-tech version that would fit MT I imagine something like this:

.

It would be fun if it hade some voxel style moving parts and that engraving tool some time for it to finish.

Just some feedback.

[orwell]

I added this to my game to label a specific item, but that item doesn't work with the engraving table. I'm hoping this can be fixed.

The item that doesn't work is the mirror of returning, from this mod: viewtopic.php?f=11&t=11224

The problem is, you have to right-click the engraving table with the item, but the mirror already does something on right-click (it sets the mirror's teleport location).

Can the engraving table be made to work with items that already have a right-click? Unfortunately, this seems to be a general issue with Minetest, as you can't open chests when holding an item with a right-click function, either. :-(

You are right. Calling the on_rightclick function of the node lies in the responsibility of the on_place callback of the item. If this is overridden, the mod has to manually check whether there is a on_rightclick callback.
Please report the issue at the [returnmirror] mod, they may contact me if they want.

[Wolfshippie]

Will there be a posibility to colour the text ingame maybe?

[orwell]

Hm, I didn' think about this yet...

[Wolfshippie]

Hm, I didn' think about this yet...

Would be a cool feature :)

[GamingAssociation39]

Can we also get a proper working interface? Or could you contribute this type of code to an anvil???

[orwell]

Hm, I didn' think about this yet...

Would be a cool feature :)

I've added an issue on github, as personal reminder.

[lazerbeak12345]

Nevermind me. I had misunderstood something. LGPLv2.1 is apparently compatible with GPLv3. nothing to worry about.

In other news, i'm making a PR to include the licence text, and this PR would fix issue #2 on the github for this project..

Spoiler

License:
Both media and code licensed under LGPLv2.1

Should this be taken to mean LGPLv2.1 only or LGPLv2.1 or-later?

I'm asking because I'm currently drafting up a pull request for this mod to include the licence text. This PR would fix issue #2 on the github for this project..

If you licence under LGPLv2.1-or-later (as opposed to only) then this will allow GPLv3 or later projects to make use of this mod.

One such example is Minetest WhyNot (of which I am a maintainer), which (by restriction of several mods within that game being GPLv3 only) is under the GPLv3-only licence right now. Here's the relevant issue on the WhyNot repo.