[Mod] Fancy Stained Glass [glass_stained]

Post Reply
User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

[Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Stained Glass

This mod adds adaptable, fancy stained glass to Minetest. There are nine different, unique designs with two different color schemes per glass type. This mod utilizes a design that allows the glass to fit underneath arches, upside-down stairs, or nearly any sort of decoration.

Along with the stained glass, this mod has normal glass, obsidian glass, and steel bars that use the same design as the stained glass. Also, there is spiked steel railing, which works great combined with the default steel bars.

Image

Embedding in Arches

As the first screenshot shows, the glass can be placed inside of arched windows. This mod does that by employing double high windows and other such shapes. In the following diagram, as viewed from the side, the parts with the O cannot be fit in another node, whereas the X can go inside any type of node:

Code: Select all

  | X | X  | XX | XXX
O | O | OX | OX | XOX
  |   |    |    | XXX
There is one more node, which can be placed into a window slot from the side. This has the advantage of not having to have a larger than one node window, but the disadvantage is that nothing else can be placed in the actual position of the node. The diagram is the same as the one above, but viewed from the top. X is where the node appears to be, but O is where it actually is:

Code: Select all

X
O
This picture should illustrate the nodes a bit better:

Image

Notice the offset on in the back on the far right. It appears to be one node behind the rest, but in reality, it is aligned with the rest of them.

And you thought a simple stained glass mod couldn't be that complex ;-)

And now for some more screenshots!

+ Spoiler

Important Info

License: MIT for code; CC BY-SA for textures
Dependencies: default, xpanes, dye

The arches used in the mod are from the mod "pkarcs", which can be found here: viewtopic.php?f=11&t=14541.

Download

Zip: https://github.com/v-rob/glass_stained/ ... master.zip
GitHub: https://github.com/v-rob/glass_stained

Please report any issues on this thread. You may make a GitHub issue, but I check the forums more than GitHub.

As always, I'm always open to suggestions.
Last edited by v-rob on Sat Jan 05, 2019 07:41, edited 3 times in total.

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Fancy Stained Glass [glass_stained]

by Chibi ghost » Post

damn nice the glass looks really good
once I do some major clean up of another mod I'll give it a go

User avatar
azekill_DIABLO
Member
Posts: 7494
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [Mod] Fancy Stained Glass [glass_stained]

by azekill_DIABLO » Post

okay, i must say... this is the finest glass i ever see of my whole life.

User avatar
TumeniNodes
Member
Posts: 2853
Joined: Fri Feb 26, 2016 19:49
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes
Location: in the dark recesses of the mind
Contact:

Re: [Mod] Fancy Stained Glass [glass_stained]

by TumeniNodes » Post

Looks very nice.
I especially like the spiked railing, I never got around to doing that

any chance of adding this to github?
Ich mag keine grünen Eier und Schinken, ich mag sie nicht Sam I Am

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

TumeniNodes wrote:any chance of adding this to github?
What for? I don't see a need to do so.

And I'm too lazy to get an account and set up stuff :)

Windspar
New member
Posts: 8
Joined: Fri May 26, 2017 18:34
GitHub: DrakeMagi
In-game: Windspar

Re: [Mod] Fancy Stained Glass [glass_stained]

by Windspar » Post

nice but now doors need to be twice as large to go with windows.

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Windspar wrote:nice but now doors need to be twice as large to go with windows.
Huh?

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Three new designs of stained glass, two color schemes for each one! See first post for updated screenshot.

(If you do not like one or more of my new designs, I will remove them.)

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Fancy Stained Glass [glass_stained]

by Chibi ghost » Post

sod that keep them you can't please everyone
it's helps that I like them a lot and have plans brewing

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Fancy Stained Glass [glass_stained]

by Chibi ghost » Post

I have added this mod to my own little world
and I have had no issues I love the arch’s and how the stained glass fits so well inside them
it was a bit fiddly learning how to use that side of the mod but once I worked it out
no problem what so ever
Image
in fact I partially re-skined my house to make the round window work
Attachments
screenshot_20170722_201539.png
(183.2 KiB) Not downloaded yet

lilo
Member
Posts: 54
Joined: Sat May 27, 2017 14:45

Re: [Mod] Fancy Stained Glass [glass_stained]

by lilo » Post

Hi,

what is the trick to get a combination between parcs and your glass, as you can see in the example pictures?

greets

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

lilo wrote:Hi,

what is the trick to get a combination between parcs and your glass, as you can see in the example pictures?

greets
You have to use the double high glass. You place the arch, and then place the double high glass one block below it.

lilo
Member
Posts: 54
Joined: Sat May 27, 2017 14:45

Re: [Mod] Fancy Stained Glass [glass_stained]

by lilo » Post

Ok, I can now build the stone arches with your glass, but how do you fill the bottom part of a circle as seen on the last picture?

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Fancy Stained Glass [glass_stained]

by Chibi ghost » Post

9x9 hole the glass is screwdriver friendly

User avatar
h-v-smacker
Member
Posts: 110
Joined: Wed Nov 29, 2017 23:04
GitHub: h-v-smacker
In-game: Smacker

Re: [Mod] Fancy Stained Glass [glass_stained]

by h-v-smacker » Post

It appears I've been working on the same mod as well (I forked whatever we had deployed at linuxforks, which originally came as a zip archive). I cleaned up the code, it went from over a 1000 loc to under 500. Also I introduced more glass shapes — not just vertical double, but also L-shaped, 2x2 and 3x3 squares. Those are often needed when the frame is both small and non-rectangular, and there is no place to position enough rotated doubles. Oh and I also tweaked the yield of some recipes to better reflect the input/output ratio from other mods. E.g. if 6 glass blocks give you 16 xpanes, similar ratio should be true here.

Check it out: https://github.com/h-v-smacker/glass_stained
Linux Forks, the Best Forks: linux-forks.de // Play @ LinuxWorks Next Generation

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Yea, I've been meaning to clean up the code for a while. I'll have a look at yours sometime soon. Sorry I can't do it immediately, but I've got a few other things to do.

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Update:
  • I've cleaned up the code majorly (~1000 lines to ~350).
  • Three more styles of glass were added with two color schemes each.
  • Obsidian glass xpanes were added for 0.4.x versions.
  • Spiked railing was added for the glass version instead of just xpanes.
  • More glass shapes were added besides single and double. These are triple, quadruple, noncuple, and offset. See first post for details
  • Edit: I also fixed Stained Glass #2 having transparency lower than every other glass, making it look wrong in the creative inventory.
Please report any compatibility issues. There shouldn't be any, but report them anyway.

User avatar
TumeniNodes
Member
Posts: 2853
Joined: Fri Feb 26, 2016 19:49
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes
Location: in the dark recesses of the mind
Contact:

Re: [Mod] Fancy Stained Glass [glass_stained]

by TumeniNodes » Post

Nice job on that code reduction v-rob
The new additions are nice too
Ich mag keine grünen Eier und Schinken, ich mag sie nicht Sam I Am

Chibi ghost
Member
Posts: 845
Joined: Fri Jan 08, 2016 21:17
In-game: Ghost

Re: [Mod] Fancy Stained Glass [glass_stained]

by Chibi ghost » Post

looks good

User avatar
v-rob
Member
Posts: 745
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
Location: Right behind you.

Re: [Mod] Fancy Stained Glass [glass_stained]

by v-rob » Post

Quick update: I fixed the nodeboxes on the spiked iron railing, which were too thin and didn't match up with the rest of the spiked railing.

Post Reply

Who is online

Users browsing this forum: No registered users and 7 guests