[Mod] Skinsdb [skinsdb]

User avatar
sirrobzeroone
Member
Posts: 206
Joined: Mon Jul 16, 2018 07:56

Re: [Mod] Skinsdb [skinsdb] HELP

by sirrobzeroone » Post

CC0/Public Domain

Image
castaway_female.png
(3.64 KiB) Not downloaded yet
castway_female_preview.png
(1.12 KiB) Not downloaded yet
Attachments
castway_female_preview_preview.png
(1.33 KiB) Not downloaded yet

User avatar
sirrobzeroone
Member
Posts: 206
Joined: Mon Jul 16, 2018 07:56

Re: [Mod] Skinsdb [skinsdb] HELP

by sirrobzeroone » Post

CC0/Public Domain

Image
rogue.png
(3.87 KiB) Not downloaded yet
rogue_preview.png
(1.15 KiB) Not downloaded yet
Attachments
rogue_preview_preview.png
(1.37 KiB) Not downloaded yet

User avatar
sirrobzeroone
Member
Posts: 206
Joined: Mon Jul 16, 2018 07:56

Re: [Mod] Skinsdb [skinsdb] HELP

by sirrobzeroone » Post

CC0/Public Domain

Image
rogue_female.png
(1.26 KiB) Not downloaded yet
rogue_female_preview.png
(1.18 KiB) Not downloaded yet
Attachments
rogue_female_preview_preview.png
(1.12 KiB) Not downloaded yet

User avatar
sirrobzeroone
Member
Posts: 206
Joined: Mon Jul 16, 2018 07:56

Re: [Mod] Skinsdb [skinsdb] HELP

by sirrobzeroone » Post

CC0/Public Domain

Image
prince.png
(3.72 KiB) Not downloaded yet
prince_preview.png
(1.11 KiB) Not downloaded yet
Attachments
prince_preview_preview.png
(5.2 KiB) Not downloaded yet

User avatar
sirrobzeroone
Member
Posts: 206
Joined: Mon Jul 16, 2018 07:56

Re: [Mod] Skinsdb [skinsdb] HELP

by sirrobzeroone » Post

CC0/Public Domain

Image
princess.png
(3.7 KiB) Not downloaded yet
princess_preview.png
(1.11 KiB) Not downloaded yet
Thats it for now :)
Attachments
princess_preview_preview.png
(5.25 KiB) Not downloaded yet

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb] HELP

by bell07 » Post

Big thanks @sirrobzeroone !!! I did not get forum notification :-( therefore I seen the provided skins today for the first time :-(
I'll add all of them to the mod (new "contentdb" branch) next days and push the mod to the contentdb ;-)

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

For now the mod is available in the latest version on content-db with pre-installed 8 @sirrobzeroone skins. Thank you again!

On github the master branch is still without skins, but new branch "contentdb" was created.

Fixed also issue with list sorting if skin names are in filenames.

vtwindsurfer
Member
Posts: 10
Joined: Sun Oct 01, 2017 14:57
Location: Vermont, USA

Re: [Mod] Skinsdb [skinsdb]

by vtwindsurfer » Post

So, currently, my server is crashing when I try to change skins. I'm running the latest Stable Minetest v5.1.0 and I'm trying to change skins via the button in the unified inventory window. On clicking "Change skins" in the formspec, the server crashes with the following log output:

Code: Select all

2019-10-27 18:02:49: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): ...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:79: attempt to compare nil with string
2019-10-27 18:02:49: ERROR[Main]: stack traceback:
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:79: in function <...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:73>
2019-10-27 18:02:49: ERROR[Main]: 	[C]: in function 'sort'
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:73: in function 'skins_sort'
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:107: in function 'get_skinlist_for_player'
2019-10-27 18:02:49: ERROR[Main]: 	...etest_server/.minetest/mods/skinsdb-master/formspecs.lua:38: in function 'get_skin_selection_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:20: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:26: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	...est_server/.minetest/mods/unified_inventory/internal.lua:84: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	...est_server/.minetest/mods/unified_inventory/internal.lua:263: in function 'set_inventory_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:46: in function <....minetest/mods/skinsdb-master/unified_inventory_page.lua:31>
2019-10-27 18:02:49: ERROR[Main]: 	/usr/share/minetest/builtin/game/register.lua:429: in function </usr/share/minetest/builtin/game/register.lua:413>
If my understanding is correct, there is an issue sorting the list of skins. I'm wondering, is this a bug or is this happening because I have not created meta/character.txt files for all of my manually added skins? I added a few custom skins borrowed from the Minecraft Skindex and still have to create the text files.

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

Thank you for bug report. Can you please test the latest git version? I did a fix that should help.

vtwindsurfer
Member
Posts: 10
Joined: Sun Oct 01, 2017 14:57
Location: Vermont, USA

Re: [Mod] Skinsdb [skinsdb]

by vtwindsurfer » Post

unfortunately, it didn't work. updated the mod from git and I finished creating the meta txt files but when I try to change skins, it still crashes with the same output.

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

@vtwindsurfer I tried to reproduce the issue today again, but it does not appear for me. Can you please provide the files list how the files are called in textures and meta folder? Or maybe just zip your skinsdb mod folder with the issue and provide it to me so I can look for the reason.

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Skinsdb [skinsdb]

by FreeGamers » Post

Can functionality to generate previews without preview.png's please be added?

I've seen bell07 talk about this before and its been mentioned here:
viewtopic.php?p=349669#p349669
FreeGamers.org has moved to MeseCraft.net | FreeGamers on the forum is now MeseCraft

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

You can try the GreenXenith fork: https://github.com/GreenXenith/skinsdb

But beware the hint
### WARNING:
**Cannot guarantee compatibillity with anything other than unified_inventory. Not tested without character_creator.**
If the change does work with sfinv, I can consolidate to merge the changes to upstream.

Since I do not use the skinsdb byself anymore, I got the change and merged them to my current fork "skinsdb5" in
[modpack][MT-5]Player API skins enhancements modpack

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Skinsdb [skinsdb]

by FreeGamers » Post

Thank you for following up bell07, that is very kind of you.

I ended up taking some time this evening to add support for this in simple_skins.

You can view the result here, I'm a bit proud of it because its the first time I've really worked with sfinv element modification, it was not as bad as I thought.
viewtopic.php?p=362482#p362482
FreeGamers.org has moved to MeseCraft.net | FreeGamers on the forum is now MeseCraft

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

New noteworhy update appears on github: The skinsdb can now generate the preview textures for skins, so no *_preview.png files are required anymore. The support for preview files is still there for the case of any performance issues with generation.
Thanks again to @GreenXenith, which implementation I got from.

User avatar
FreeGamers
Member
Posts: 651
Joined: Sat May 25, 2019 00:15
GitHub: is proprietary I use NotABug
Location: United States
Contact:

Re: [Mod] Skinsdb [skinsdb]

by FreeGamers » Post

I'm very happy to see those changes added. Very nice method that will save some data transfer on networks. :) Thank you belle :)
FreeGamers.org has moved to MeseCraft.net | FreeGamers on the forum is now MeseCraft

User avatar
Inocudom
Member
Posts: 3096
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

Re: [Mod] Skinsdb [skinsdb]

by Inocudom » Post

How about adding a playermodel with arms that are only 3 x 3 pixels in circumference (instead of 3 x 4 or 4 x 4?) It will make them stand out from the body and legs better.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

cronvel
Member
Posts: 41
Joined: Fri Jan 11, 2019 16:50
GitHub: cronvel

Re: [Mod] Skinsdb [skinsdb]

by cronvel » Post

player_[playername]_[name or number].png for private skins available to the specific player
For private skins, using a number works but using a name seems to crash the game (Mintest 5.3.0).
+Log

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

@cronvel, I was not able to get the same issue. All private skin namings does work for me

Code: Select all

$ ls textures/player_*
textures/player_1.png  textures/player_Alex.png  textures/player_Alex_1.png  textures/player_Alex_TEST.png
The player_1.png is faulty, there is no player with name "1". But there is no issue, the skin is just not visible. THe other 3 skins the player Alex is able to see.

Can you please provide your textures names and if you have any meta files in meta folder?

Do you use the contendtb version or github version?

User avatar
daret
Member
Posts: 34
Joined: Tue Nov 12, 2019 20:36
GitHub: daretmavi
In-game: Daretmavi

Re: [Mod] Skinsdb [skinsdb]

by daret » Post

Hi,
there is a new Character Animation mod https://github.com/appgurueu/character_anim, but it is not working with current version of Skindb.
Is it possible to let skindb to use default 3d armor model (or implement support for Character Animations)?
- This could solve the problem (viewtopic.php?p=381914#p381914)
XAPSB6eWQGiebFxD8Af5CUUg58iQxBAj

User avatar
daret
Member
Posts: 34
Joined: Tue Nov 12, 2019 20:36
GitHub: daretmavi
In-game: Daretmavi

Re: [Mod] Skinsdb [skinsdb]

by daret » Post

Skindb is now supported with character_anim, but I got some another problem with Painted 3D Armor mod (https://github.com/evrooije/painted_3d_armor).

It looks like the problem is again custom 3D model.
Using 3D armor model should be at least an option.
I do not even know what it means - supported skin format 1.0 and 1.8. I suppose, this is the reason for custom model, or?
XAPSB6eWQGiebFxD8Af5CUUg58iQxBAj

bell07
Member
Posts: 599
Joined: Sun Sep 04, 2016 15:15
GitHub: bell07

Re: [Mod] Skinsdb [skinsdb]

by bell07 » Post

Skinsdb uses the 3D-Model with support for 1.8-er Skins, 3d_armor and clothing. So you can use the https://github.com/stujones11/clothing/ with skinsdb + 3d_armor instead of outdated 3d_armor multiskin branch. The v1.8 skins are with additional layer, like skins on https://minecraft.novaskin.me/ supported by skinsdb.

The used model is from https://github.com/stujones11/minetest- ... kin_branch

Looked trough painted_3d_armor. The painted_3d_armor still uses default.player_set_textures() and does not support the v1.8 texture ...
The beter way is to use the 3d_armor API in painted_3d_armor instead. Just manipulate the self.textures[name].armor and do armor:update_player_visuals(player) {ok, the update_player_visuals trigger the "on_update" callback so the endless loop needs to be solved}

The armor:update_player_visuals(player) overridden and is adjusted in skinsdb to support the 1.8 layer and provided model.

User avatar
daret
Member
Posts: 34
Joined: Tue Nov 12, 2019 20:36
GitHub: daretmavi
In-game: Daretmavi

Re: [Mod] Skinsdb [skinsdb]

by daret » Post

Thanx for information and all the links.
XAPSB6eWQGiebFxD8Af5CUUg58iQxBAj

Post Reply

Who is online

Users browsing this forum: Google [Bot] and 10 guests