[Mod] Skinsdb [skinsdb]

[sirrobzeroone]

CC0/Public Domain

castaway_female.png

(3.64 KiB) Not downloaded yet

castway_female_preview.png

(1.12 KiB) Not downloaded yet

[sirrobzeroone]

CC0/Public Domain

rogue.png

(3.87 KiB) Not downloaded yet

rogue_preview.png

(1.15 KiB) Not downloaded yet

[sirrobzeroone]

CC0/Public Domain

rogue_female.png

(1.26 KiB) Not downloaded yet

rogue_female_preview.png

(1.18 KiB) Not downloaded yet

[sirrobzeroone]

CC0/Public Domain

prince.png

(3.72 KiB) Not downloaded yet

prince_preview.png

(1.11 KiB) Not downloaded yet

[sirrobzeroone]

CC0/Public Domain

princess.png

(3.7 KiB) Not downloaded yet

princess_preview.png

(1.11 KiB) Not downloaded yet

Thats it for now :)

[bell07]

Big thanks @sirrobzeroone !!! I did not get forum notification :-( therefore I seen the provided skins today for the first time :-(
I'll add all of them to the mod (new "contentdb" branch) next days and push the mod to the contentdb ;-)

[bell07]

For now the mod is available in the latest version on content-db with pre-installed 8 @sirrobzeroone skins. Thank you again!

On github the master branch is still without skins, but new branch "contentdb" was created.

Fixed also issue with list sorting if skin names are in filenames.

[vtwindsurfer]

So, currently, my server is crashing when I try to change skins. I'm running the latest Stable Minetest v5.1.0 and I'm trying to change skins via the button in the unified inventory window. On clicking "Change skins" in the formspec, the server crashes with the following log output:

Code: Select all

2019-10-27 18:02:49: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): ...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:79: attempt to compare nil with string
2019-10-27 18:02:49: ERROR[Main]: stack traceback:
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:79: in function <...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:73>
2019-10-27 18:02:49: ERROR[Main]: 	[C]: in function 'sort'
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:73: in function 'skins_sort'
2019-10-27 18:02:49: ERROR[Main]: 	...netest_server/.minetest/mods/skinsdb-master/skinlist.lua:107: in function 'get_skinlist_for_player'
2019-10-27 18:02:49: ERROR[Main]: 	...etest_server/.minetest/mods/skinsdb-master/formspecs.lua:38: in function 'get_skin_selection_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:20: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:26: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	...est_server/.minetest/mods/unified_inventory/internal.lua:84: in function 'get_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	...est_server/.minetest/mods/unified_inventory/internal.lua:263: in function 'set_inventory_formspec'
2019-10-27 18:02:49: ERROR[Main]: 	....minetest/mods/skinsdb-master/unified_inventory_page.lua:46: in function <....minetest/mods/skinsdb-master/unified_inventory_page.lua:31>
2019-10-27 18:02:49: ERROR[Main]: 	/usr/share/minetest/builtin/game/register.lua:429: in function </usr/share/minetest/builtin/game/register.lua:413>

If my understanding is correct, there is an issue sorting the list of skins. I'm wondering, is this a bug or is this happening because I have not created meta/character.txt files for all of my manually added skins? I added a few custom skins borrowed from the Minecraft Skindex and still have to create the text files.

[bell07]

Thank you for bug report. Can you please test the latest git version? I did a fix that should help.

[vtwindsurfer]

unfortunately, it didn't work. updated the mod from git and I finished creating the meta txt files but when I try to change skins, it still crashes with the same output.

[bell07]

@vtwindsurfer I tried to reproduce the issue today again, but it does not appear for me. Can you please provide the files list how the files are called in textures and meta folder? Or maybe just zip your skinsdb mod folder with the issue and provide it to me so I can look for the reason.

[FreeGamers]

Can functionality to generate previews without preview.png's please be added?

I've seen bell07 talk about this before and its been mentioned here:
viewtopic.php?p=349669#p349669

[bell07]

You can try the GreenXenith fork: https://github.com/GreenXenith/skinsdb

But beware the hint

### WARNING:
**Cannot guarantee compatibillity with anything other than unified_inventory. Not tested without character_creator.**

If the change does work with sfinv, I can consolidate to merge the changes to upstream.

Since I do not use the skinsdb byself anymore, I got the change and merged them to my current fork "skinsdb5" in
[modpack][MT-5]Player API skins enhancements modpack

[FreeGamers]

Thank you for following up bell07, that is very kind of you.

I ended up taking some time this evening to add support for this in simple_skins.

You can view the result here, I'm a bit proud of it because its the first time I've really worked with sfinv element modification, it was not as bad as I thought.
viewtopic.php?p=362482#p362482

[bell07]

New noteworhy update appears on github: The skinsdb can now generate the preview textures for skins, so no *_preview.png files are required anymore. The support for preview files is still there for the case of any performance issues with generation.
Thanks again to @GreenXenith, which implementation I got from.

[FreeGamers]

I'm very happy to see those changes added. Very nice method that will save some data transfer on networks. :) Thank you belle :)

[Inocudom]

How about adding a playermodel with arms that are only 3 x 3 pixels in circumference (instead of 3 x 4 or 4 x 4?) It will make them stand out from the body and legs better.

[cronvel]

player_[playername]_[name or number].png for private skins available to the specific player

For private skins, using a number works but using a name seems to crash the game (Mintest 5.3.0).

+Log

2020-08-23 15:28:19: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): /home/cedric/.minetest/mods/skinsdb/skinlist.lua:78: attempt to compare string with nil
2020-08-23 15:28:19: ERROR[Main]: stack traceback:
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/skinlist.lua:78: in function </home/cedric/.minetest/mods/skinsdb/skinlist.lua:72>
2020-08-23 15:28:19: ERROR[Main]: [C]: in function 'sort'
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/skinlist.lua:72: in function 'skins_sort'
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/skinlist.lua:106: in function 'get_skinlist_for_player'
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/formspecs.lua:41: in function 'get_skin_selection_formspec'
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/sfinv_page.lua:7: in function 'get_formspec'
2020-08-23 15:28:19: ERROR[Main]: /home/cedric/.minetest/mods/skinsdb/sfinv_page.lua:15: in function 'get_formspec'
2020-08-23 15:28:19: ERROR[Main]: /app/share/minetest/games/minetest_game/mods/sfinv/api.lua:125: in function 'set_player_inventory_formspec'
2020-08-23 15:28:19: ERROR[Main]: /app/share/minetest/games/minetest_game/mods/sfinv/api.lua:141: in function 'set_page'
2020-08-23 15:28:19: ERROR[Main]: /app/share/minetest/games/minetest_game/mods/sfinv/api.lua:179: in function </app/share/minetest/games/minetest_game/mods/sfinv/api.lua:159>
2020-08-23 15:28:19: ERROR[Main]: /app/share/minetest/builtin/game/register.lua:429: in function </app/share/minetest/builtin/game/register.lua:413>

[bell07]

@cronvel, I was not able to get the same issue. All private skin namings does work for me

Code: Select all

$ ls textures/player_*
textures/player_1.png  textures/player_Alex.png  textures/player_Alex_1.png  textures/player_Alex_TEST.png

The player_1.png is faulty, there is no player with name "1". But there is no issue, the skin is just not visible. THe other 3 skins the player Alex is able to see.

Can you please provide your textures names and if you have any meta files in meta folder?

Do you use the contendtb version or github version?

[daret]

Hi,
there is a new Character Animation mod https://github.com/appgurueu/character_anim, but it is not working with current version of Skindb.
Is it possible to let skindb to use default 3d armor model (or implement support for Character Animations)?
- This could solve the problem (viewtopic.php?p=381914#p381914)

[daret]

Skindb is now supported with character_anim, but I got some another problem with Painted 3D Armor mod (https://github.com/evrooije/painted_3d_armor).

It looks like the problem is again custom 3D model.
Using 3D armor model should be at least an option.
I do not even know what it means - supported skin format 1.0 and 1.8. I suppose, this is the reason for custom model, or?