[Modpack] Display Modpack [1.3] [display_modpack]

User avatar
BuckarooBanzay
Member
Posts: 435
Joined: Tue Apr 24, 2018 05:58
GitHub: BuckarooBanzay
IRC: BuckarooBanzai
In-game: BuckarooBanzai

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by BuckarooBanzay » Post

Maybe an issue with improper time-values on the client:
https://github.com/pyrollo/display_modp ... es.lua#L45
¯\_(ツ)_/¯ Not active here anymore, contact me on the minetest discord, irc, lemmy or github (for programming issues)

User avatar
DancingWombat
Member
Posts: 14
Joined: Tue Nov 14, 2017 12:53

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by DancingWombat » Post

Cool more colours for street signs, thanks. Love the blackboard too.

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

Thanks a lot !

Good news, it seems that I identified the problem. Things explained here: https://github.com/pyrollo/display_modp ... -442634918

A fixed version will be available soon.
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

Riverty, can you test with this version and tell me if it solves the issue on your side ?
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

riverty
New member
Posts: 7
Joined: Wed Nov 21, 2018 03:14
In-game: riverty

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by riverty » Post

Pyrollo,

I checked your test version on my server.

First, on first login to the game the one "Unknown Object" I kept for testing was gone! Good sign.
I mounted two new clocks (Gold & White) = OK.
Ran away then back check = OK.
Log out, log back in check = OK.
Reboot server, log in and check = OK.
Mounted 2 new signs = OK.
Server load check = OK.
Server log check = OK.

I would say you've fixed it my friend! Nice job! Should we expect a version 1.3 then?

Thank you for your work in addressing this issue. I'm glad I could help out.

Regards,

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

Hurray \o/

Not sure for 1.3 as this is a "simple" bugfix, but I'll merge the fixed version very soon.

Thanks to you and Sbrl on Github for your feed backs and help on testing.
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

Miner123/Miner12
New member
Posts: 3
Joined: Tue Feb 27, 2018 06:51
IRC: Miner123
In-game: Miner123 Miner12

Re: [Modpack] Display Modpack [1.0] [display_modpack]

by Miner123/Miner12 » Post

BuckarooBanzay wrote:
Pyrollo wrote: You can already use OldWizard font as the default font_api font. I'm developing something to be able to choose font per sign.
I'm glad to hear that, old-style font, future-font and default font would be a nice addition :)
I don't know if anyone's suggested it but maybe also a symbols font like Webdings?

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.0] [display_modpack]

by Pyrollo » Post

Miner123/Miner12 wrote:I don't know if anyone's suggested it but maybe also a symbols font like Webdings?
Hi !

I don't like symbol fonts. They don't follow standard char codepoints. Moreover, signs_api is not able to handle several fonts on one sign. That means that you wont be able to mix webdings and normal letters.

A much smarter solution would be to add some unicode blocks or chars. You can search in unicode tables to find some interresting chars, for example miscellaneous symbols and have a look at metro font to check if those chars are included. Including those chars is quite easy.
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
GamingAssociation39
Member
Posts: 858
Joined: Mon Apr 25, 2016 16:09
GitHub: Gerold55
IRC: Gerold55
In-game: Gerold55
Location: Maryland, USA

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by GamingAssociation39 » Post

@pyrollo any chance you could help add (digital) clocks into the furniture mod?
Jesus Is Lord and Savior!!!

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

GamingAssociation39 wrote:@pyrollo any chance you could help add (digital) clocks into the furniture mod?
Hi, for digital clock you only need the display_api mod + ontime_clock mod. You can add them in any modpack, or try to include them in your mod. But if you include them into a mod, you have to maintain it according to further improvements (actually display_api does not evolve too much).
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
Linuxdirk
Member
Posts: 3217
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [Modpack] Display Modpack [1.0] [display_modpack]

by Linuxdirk » Post

Pyrollo wrote:I just added a simple wooden sign :)
Does it replace the default signs? This would make a good replacement for pure signs_lib then.

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.0] [display_modpack]

by Pyrollo » Post

Linuxdirk wrote:
Pyrollo wrote:I just added a simple wooden sign :)
Does it replace the default signs? This would make a good replacement for pure signs_lib then.
No, I don't remember why but replacing default sign was a mess. Maybe that was a matter of concurrence with signs_lib, I don't remember.

The thing I can do is a specific "default sign replacement" mod in display_modpack.
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
Linuxdirk
Member
Posts: 3217
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Linuxdirk » Post

Nah, don't worry. Just wondering.

The problem I have with signs_lib is that the text is not properly aligned and on your screenshot it looks just much better. I think I'll give it a try anyways :)

Edit: Just removed signs_lib and properly implemented the Display Modpack into my world. Works like charm and looks very clean, fresh, and modern.

User avatar
BirgitLachner
Member
Posts: 393
Joined: Thu May 05, 2016 10:18
In-game: Bibs

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by BirgitLachner » Post

Hi everybody ...

I hope you can help me with an error thats shows a conneciton to the display_mod:

I created an offline worlds and copied it to an online-server. Display-Mod is working, but I cannot change the font. If try to change the font, minetest crashes immedeatly.
There is the output:
2019-03-04 10:12:07: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback node_on_receive_fields(): ...st/bin/../mods/display_modpack/font_api/fontform.lua:160: attempt to call field 'is_player' (a nil value)
2019-03-04 10:12:07: ERROR[Main]: stack traceback:
2019-03-04 10:12:07: ERROR[Main]: ...st/bin/../mods/display_modpack/font_api/fontform.lua:160: in function 'show_font_list'
2019-03-04 10:12:07: ERROR[Main]: ...etest/bin/../mods/display_modpack/signs_api/init.lua:84: in function <...etest/bin/../mods/display_modpack/signs_api/init.lua:77>
2019-03-04 10:12:26: WARNING[Main]: Couldn't find a locale directory!
2019-03-04 10:12:26: ERROR[Main]: The following mods could not be found: "display_lib" "font_lib"


An other problem ... after the last player leaves, there is a crash, too.
2019-03-04 10:52:15: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'font_api' in callback on_leaveplayer(): ...st/bin/../mods/display_modpack/font_api/fontform.lua:24: attempt to call field 'is_player' (a nil value)
2019-03-04 10:52:15: ERROR[Main]: stack traceback:
2019-03-04 10:52:15: ERROR[Main]: ...st/bin/../mods/display_modpack/font_api/fontform.lua:24: in function '?'
2019-03-04 10:52:15: ERROR[Main]: /minetest/bin/../builtin/game/register.lua:412: in function </minetest/bin/../builtin/game/register.lua:392>
Can you help me and give me a hint, what the problem is?

Thanks, Birgit

Thomas-S
Member
Posts: 115
Joined: Sun Sep 06, 2015 12:23
GitHub: Thomas--S
IRC: Thomas-S
In-game: Thomas-S
Location: Bavaria, Germany

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Thomas-S » Post

Are you sure you are using the latest stable version of the 0.4 branch?

User avatar
BirgitLachner
Member
Posts: 393
Joined: Thu May 05, 2016 10:18
In-game: Bibs

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by BirgitLachner » Post

Oh ... you are right ... I think I need to update the server software ... :-0

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

Yes, "is_player" is some kind of new in the API (actually, already a bit old, an update should help ;) )
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
BirgitLachner
Member
Posts: 393
Joined: Thu May 05, 2016 10:18
In-game: Bibs

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by BirgitLachner » Post

Hm ... what is "new"? A 0.4.x version oder 5.0?

Thomas-S
Member
Posts: 115
Joined: Sun Sep 06, 2015 12:23
GitHub: Thomas--S
IRC: Thomas-S
In-game: Thomas-S
Location: Bavaria, Germany

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Thomas-S » Post

As far as I know, 0.4.17 should be enough.

User avatar
BirgitLachner
Member
Posts: 393
Joined: Thu May 05, 2016 10:18
In-game: Bibs

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by BirgitLachner » Post

Okay ...
I needed some help to get the version information and it seems to be 0.4.17. But the problem seems to be still the same.
Any idea?

Birgit

Thomas-S
Member
Posts: 115
Joined: Sun Sep 06, 2015 12:23
GitHub: Thomas--S
IRC: Thomas-S
In-game: Thomas-S
Location: Bavaria, Germany

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Thomas-S » Post

Now that Minetest 5.0.0 is released, I suggest to try this version.

User avatar
Pyrollo
Developer
Posts: 385
Joined: Mon Jan 08, 2018 15:14
GitHub: pyrollo
In-game: Naj
Location: Paris

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Pyrollo » Post

BirgitLachner wrote:Okay ...
I needed some help to get the version information and it seems to be 0.4.17. But the problem seems to be still the same.
Any idea?

Birgit
Hi, tested with success on version 0.4.17.1. Can't find out when minetest.is_player has been added but maybe for this version.
[ Display Modpack ] - [ Digiterms ] - [ Crater MG ] - [ LATE ]

User avatar
sorcerykid
Member
Posts: 1841
Joined: Fri Aug 26, 2016 15:36
GitHub: sorcerykid
In-game: Nemo
Location: Illinois, USA

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by sorcerykid » Post

My server runs a fork of 0.4.14-dev, and it has the is_player method. So it's been part of the official API since at least 2016.

Thomas-S
Member
Posts: 115
Joined: Sun Sep 06, 2015 12:23
GitHub: Thomas--S
IRC: Thomas-S
In-game: Thomas-S
Location: Bavaria, Germany

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by Thomas-S » Post

sorcerykid wrote:My server runs a fork of 0.4.14-dev, and it has the is_player method. So it's been part of the official API since at least 2016.
https://github.com/minetest/minetest/pull/7013

According to this PR, this function is from early 2018.

User avatar
jas
Member
Posts: 593
Joined: Mon Jul 24, 2017 18:15
IRC: Freenode
Location: IRC

Re: [Modpack] Display Modpack [1.2] [display_modpack]

by jas » Post

Is `minetest.is_player' separate from `ObjectRef:is_player'?

Post Reply

Who is online

Users browsing this forum: No registered users and 30 guests