Page 34 of 42

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 12:27
by Andrey01
VanessaE wrote:This is not a home decor bug. You're just trying to install too many mods that create too many nodes. Nothing more.
But how?? How can mods create 32768 blocks??? I have not over 74 mods and modpacks. Before i had more mods. Probably it causes "summer" or "nodeu" mods that i installed yesterday. They have many nodes. I will look at these new mods.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 12:57
by VanessaE
Simple - nested loops and third-party APIs. Consider the following extremely contrived example:

Suppose you want to create a basic type of object, bricks let's say, so you code up a basic node.

Now suppose you want to create 20 variations of it, with different base textures. So, you create a table with a list of textures, then bury the original register_node() call in a loop, wherein you read from that table, and apply what you get to create a new node for each entry in the table.

Now let's say you want each one to be available with one of 10 different mortar/stone/brick patterns on top of the base texture.

So, you bury the original different-textures loop in a second loop. There, you read from another table, which contains the info you need to define the mortar patterns, and apply that to the register_node() call in the middle of it all, compositing the mortar pattern onto the base texture.

Now you have 20 * 10 = 200 nodes. Not too terrible, and you've only written a few dozen lines of code and tables, and composed a few dozen base images.

Now let's say you want to pass each of those to Stairsplus, which creates an additional 40 or so different shapes from the one node you passed to it. Moreblocks, which supplies Stairsplus, creates like 1000 nodes on its own, before your example mod even runs.

Now you have (~1000 Moreblocks nodes) + (your mod's initial 200) + (200 * 40 more created via Stairsplus) == ~9200 nodes.

All of that from two mods.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 14:18
by Andrey01
Other question: can i anyhow set up Minetest Game that it to allow to register over 32678 nodes?

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 14:27
by VanessaE
It's a limit in the engine - check the issue list, there's a proposal to raise the limit.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 14:29
by Andrey01
VanessaE wrote:It's a limit in the engine - check the issue list, there's a proposal to raise the limit.
Where is issue list being?
I don`t know where that "issue list" is being about that you are saying.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Mon Apr 30, 2018 15:36
by VanessaE

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Sun May 20, 2018 00:28
by viper121
I have modified the spiral staircase to fit my needs. Perhaps you are interested?

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Sun May 20, 2018 01:17
by VanessaE
What modification did you do exactly? I may be interested, but please submit your changes as a pull request via github.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Sun May 20, 2018 01:47
by viper121
I haven't used github enough to understand the pull request. I modified the staircase to be one node tall so it could be built to any height desired. I also moved the nodeboxes around to fit the modified model.

Im using the modified model on my alpha server if you wanted to see it btw

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Sun May 20, 2018 06:36
by VanessaE
github's easy. The short version: Just fork homedecor there, clone your fork to your PC, make your changes (you can probably copy the changes from your zip), commit and push back to your fork, then go back to the website to create a pull request against my repo.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 06, 2018 07:12
by Andrey01
Vanessa, please put all your mods (Home Decor, Pipeworks, More Trees, Plantlife, Gloopblocks, Nixie Tubes, Biome Lib, Ilights...) to content.minetest.net users to be able to see in game menu your mods list and download them there in next 0.5 version.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 06, 2018 07:58
by VanessaE
Most of the ones you listed are already on there (nixie tubes and ilights are missing). Maybe later.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 06, 2018 11:45
by VanessaE
This project has been moved to Gitlab.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Thu Jun 07, 2018 13:36
by Dan2018
Just had a server crash trying to remove a sink

Code: Select all

2018-06-07 14:44:26: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'homedecor' in callback node_on_dig(): Runtime error from mod 'homedecor' in callback node_on_destruct(): ...homedecor_modpack\homedecor/handlers/water_particles.lua:112: bad argument #2
2018-06-07 14:44:26: ERROR[Main]: to 'set_int' (number expected, got nil)
2018-06-07 14:44:26: ERROR[Main]: stack traceback:
2018-06-07 14:44:26: ERROR[Main]:       [C]: in function 'set_int'
2018-06-07 14:44:26: ERROR[Main]:       ...homedecor_modpack\homedecor/handlers/water_particles.lua:112: in function 'stop_particle_spawner'
2018-06-07 14:44:26: ERROR[Main]:       ...mods\homedecor_modpack\homedecor/bathroom_sanitation.lua:112: in function <...mods\homedecor_modpack\homedecor/bathroom_sanitation.lua:111>
2018-06-07 14:44:26: ERROR[Main]:       [C]: in function 'remove_node'
2018-06-07 14:44:26: ERROR[Main]:       C:\minetest-0.4.17\bin\..\builtin\game\item.lua:595: in function <C:\minetest-0.4.17\bin\..\builtin\game\item.lua:541>
2018-06-07 14:44:26: ERROR[Main]: stack traceback:
2018-06-07 14:44:26: ERROR[Main]:       [C]: in function 'remove_node'
2018-06-07 14:44:26: ERROR[Main]:       C:\minetest-0.4.17\bin\..\builtin\game\item.lua:595: in function <C:\minetest-0.4.17\bin\..\builtin\game\item.lua:541>
Happens to all things water.
On 0.4.17.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Thu Jun 07, 2018 13:55
by chatinbed
I have the same problem with the kitchen faucet...
Right clicking ( using ) it or "destroying it" gives the same kind of error message, setting a "nil" value where an integer is expected.
I made a new directory of the new 0.4.17 version so i still could go back to the old version.
After copying the world back to the "old" version of minetest it worked fine, In the "4.16" version i had no problems, something changed in the new version of minetest that makes it crash...

from my debug.txt >>

2018-06-07 13:14:24: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'default' in callback item_OnPlace(): ...homedecor_modpack\homedecor/handlers/water_particles.lua:33: bad argument #2 to 'set_int' (number expected, got nil)
2018-06-07 13:14:24: ERROR[Main]: stack traceback:
2018-06-07 13:14:24: ERROR[Main]: [C]: in function 'set_int'
2018-06-07 13:14:24: ERROR[Main]: ...homedecor_modpack\homedecor/handlers/water_particles.lua:33: in function 'start_particle_spawner'
2018-06-07 13:14:24: ERROR[Main]: ....\mods\homedecor_modpack\homedecor/kitchen_furniture.lua:136: in function 'on_rightclick'
2018-06-07 13:14:24: ERROR[Main]: C:\Games\minetest-0.4.17-win64\bin\..\builtin\game\item.lua:423: in function <C:\Games\minetest-0.4.17-win64\bin\..\builtin\game\item.lua:416>

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Thu Jun 07, 2018 14:25
by VanessaE
Fixed in git (I think :-P )

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Tue Jun 12, 2018 15:35
by chatinbed
I downloaded it after you posted that message... but still the same error.
I downloaded it two more times, 3 days later and today , but still the same error occurs.
I don't see any remarks or changes either on github, latest change was "proper handle stairs group".
Am i looking on the wrong location or are the changes not submitted yet or did the fix not work ?

https://github.com/minetest-mods/homedecor_modpack

This is the correct location, right ? Sorry to bother you about this and it is not a matter of life or dead, but is it going to be fixed ?

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Tue Jun 12, 2018 16:00
by VanessaE
No, that's the wrong repo. Get it from https://gitlab.com/VanessaE/homedecor_modpack

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Tue Jun 12, 2018 16:42
by chatinbed
I get : 500 server error, either on
https://gitlab.com/vanessaE
or
https://gitlab.com/VanessaE/homedecor_modpack

An internal server error occured.
Please contact your GitLab administrator.

I will try again later

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Tue Jun 12, 2018 16:55
by VanessaE
That'll be a web server error, probably growing pains from the mass influx of former github users (gitlab got slammed all to hell from it initially). Nothing I can do about it; you'll just have to wait a bit and re-try.

Check their status feed on Twitter: https://twitter.com/gitlabstatus

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 13, 2018 00:56
by chatinbed
It worked..... after a long wait i could download the new set.

Now for something completely different, coins for the soda vending machine.
It does not even show in the crafting guide. I used to make 50 , gold block and mese sword is the recipe for that. The recipe won't work and it is not showing in the crafting guide.
The coin exists in creative mode but i play in survival mode.
In 4.16 ( i still have that ) it works fine, but not in 4.17.

Any idea ?

It makes me wonder, should i just go back to 4.16 and forget the whole new 4.17 version........
So many slight changes.... I started a new world on the day version 4.17 was released so i did not create many of home decor items yet.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 13, 2018 02:35
by VanessaE
I seem to recall merging a pull request to remove the crafting recipe for coins, for the sake of game balance.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 13, 2018 10:29
by III
Hi,
I has some crash with 0.4.17 so y tried updating all my mods.
While I updated homedecor, now minetest server doesn't start any more.
Debug say:
2018-06-13 12:26:15: ERROR[Main]: ModError: Failed to load and run script from /home/olivier/.minetest/mods/homedecor/homedecor/init.lua:
2018-06-13 12:26:15: ERROR[Main]: .../olivier/.minetest/mods/homedecor/homedecor/wardrobe.lua:32: attempt to call field 'get_skin_format' (a nil value)
2018-06-13 12:26:15: ERROR[Main]: stack traceback:
2018-06-13 12:26:15: ERROR[Main]: .../olivier/.minetest/mods/homedecor/homedecor/wardrobe.lua:32: in main chunk
2018-06-13 12:26:15: ERROR[Main]: [C]: in function 'dofile'
2018-06-13 12:26:15: ERROR[Main]: /home/olivier/.minetest/mods/homedecor/homedecor/init.lua:118: in main chunk

any idea ?

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 13, 2018 11:37
by VanessaE
Please try it with 0.4.17.1 (note the ".1"), and file an issue on the gitlab repository if it still crashes.

Re: [Modpack] Home Decor [git] [homedecor_modpack]

Posted: Wed Jun 13, 2018 12:36
by III
thanks for fast reply,

I'm ubuntu user. It does not seem that 0.4.17.1 has been released