[Mod] i3 [1.16] [i3]

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

I would like to create my own mod depended on i3 only, but I'm only a hobby programmer and this is my first experiment with formspec. [...]
You can do all of that in a separate mod. The progressive filter can be removed after it's checked against the creative setting of the server.

And like you said, you'll need i3.override_tab to change the components of the inventory.
This mod is licensed under a very permissive licence, so you can actually import the functions you need in your mod.

0X0120F
New member
Posts: 2
Joined: Tue Aug 03, 2021 00:26
In-game: 0X0120F

Re: [Mod] i3 [1.3.2] [i3]

by 0X0120F » Post

This mod is great, I have been enjoying it so far, but I have some suggestions regarding the sorting functionalities: I think it should not "touch" the things that are in the player's hotbar slots since the items and tools there are often deliberately placed in that order and must remain like that, for example: my sword at slot 1 gets replaced by some berries, my pickaxe at slot 2 by a bucket and so on. I think it should also be possible to sort chests.

Edit: another thing has occurred to me after posting this message, which is the really useful feature of being able to "lock" items in crafting slots so that you only need to place the ingredients once to craft several of the item, like to craft some paper I need to place 3 papyrus in a line, to craft 54 papers I would need to place 18 papyrus in each slot, with this feature I would only need to place 1 papyrus per slot and be able to remain crafting without the need to add more papyrus to the crafting slots until I have either reached the amount I want or ran out of ingredients, there could be a little checkbox next to the crafting slots that would toggle the "locking" feature on and off.

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

There's already a "Quick Crafting" feature that craft multiple times in a single click. And you don't need to place items in the grid, it's automatically detected.

0X0120F
New member
Posts: 2
Joined: Tue Aug 03, 2021 00:26
In-game: 0X0120F

Re: [Mod] i3 [1.3.2] [i3]

by 0X0120F » Post

jp wrote:
Tue Aug 03, 2021 01:32
There's already a "Quick Crafting" feature that craft multiple times in a single click. And you don't need to place items in the grid, it's automatically detected.
Oh, this is pretty cool, how do I use it?

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

You have to gather all required materials in your inventory to craft some item. Then an arrow will appear in the top-right side of the recipe/usage panels.

User avatar
Ghaydn
Member
Posts: 54
Joined: Sat Sep 26, 2020 11:58
In-game: ghaydn
Location: Moscow, Russia

Re: [Mod] i3 [1.3.2] [i3]

by Ghaydn » Post

Very nice mod! I like it more than other inventories.
Found some issues:
1. When I have a recipe opened and taking an item from drawer ("drawers" mod) it waits for 3-4 seconds before showing quick crafting icon.
2. Some recipes, like ones using buckets of water, don't work propertly: they must leave an empty bucket but instead they just a full one.
3. basic_materials:oil_extract sometimes don't spend leaves, so I can create infinitely much oil. Maybe some other recipes that use groups have similar bug.
4. Sometimes a person preview twitches every n seconds and when this happens, it erases any typed text from search and waypoints fields.
5. Sometimes lib_trm and toolranks reset tool properties on crafts like {recipe = {"pickaxe", "pickaxe"}, result = "pickaxe"}. Sometiles not. Maybe this is not because if i3, idk.
Nobody understands me... — вРН БШ ЯЙЮГЮКХ?

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

These things are not related to the i3 inventory.

SFENCE
Member
Posts: 274
Joined: Sun Sep 29, 2019 07:13
GitHub: SFENCE
In-game: SFENCE

Re: [Mod] i3 [1.3.2] [i3]

by SFENCE » Post

When I use i3 mod with morelights mod and I click to Vintage Oil Lamp in non creative mode, game failed with error:

Code: Select all

2021-08-09 22:02:47: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_playerReceiveFields(): /home/sfence/.minetest/mods/i3/init.lua:1553: bad argument #3 to 'fmt' (number expected, got nil)
2021-08-09 22:02:47: ERROR[Main]: stack traceback:
2021-08-09 22:02:47: ERROR[Main]:       [C]: in function 'fmt'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:1553: in function 'get_model_fs'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:1618: in function 'get_header'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:1832: in function 'get_panels'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:2190: in function 'make_fs'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:2208: in function 'fields'
2021-08-09 22:02:47: ERROR[Main]:       /home/sfence/.minetest/mods/i3/init.lua:3102: in function </home/sfence/.minetest/mods/i3/init.lua:3073>
2021-08-09 22:02:47: ERROR[Main]:       /usr/share/minetest/builtin/game/register.lua:422: in function </usr/share/minetest/builtin/game/register.lua:406>
It is probably because of missing support of tile animation type "sheet_2d".
See morelights_vintage/init.lua line 238 and below.
cdb_3P0AYqjEIn68

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

SFENCE wrote:
Tue Aug 10, 2021 08:37
When I use i3 mod with morelights mod and I click to Vintage Oil Lamp in non creative mode, game failed with error
Fixed.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

urgent error:
2021-08-21 08:14:35: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua:
Runtime error from mod 'i3' in callback on_leaveplayer(): ...netest/MeseCraft/ga
mes/mesecraft/mods/PLAYER/i3/init.lua:3050: attempt to index a nil value
2021-08-21 08:14:35: ERROR[Main]: stack traceback:
2021-08-21 08:14:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods
/PLAYER/i3/init.lua:3050: in function 'save_data'
2021-08-21 08:14:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods
/PLAYER/i3/init.lua:3061: in function <...netest/MeseCraft/games/mesecraft/mods/
PLAYER/i3/init.lua:3059>
2021-08-21 08:14:35: ERROR[Main]: /home/minetest/MeseCraft/builtin/game/re
gister.lua:422: in function </home/minetest/MeseCraft/builtin/game/register.lua:
406>


its being used in progressive mode. Also, Why dont players get the "you unlocked a recipe" HUD msg in multiplayer mode?

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

MisterE wrote:
Sat Aug 21, 2021 06:16
urgent error
Fixed.
Why dont players get the "you unlocked a recipe" HUD msg in multiplayer mode?
Because the sliding pop-up uses a hack and it might cause too much lag in multiplayer.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

Players on my server reported that you can get more items than you normally could craft by using the quick crafting feature selecting the 1x setting, and spamclicking the craft button. I had 99 cobble, and 6 cobble give 6 stone walls. I followed this method and ended up with 102 stone walls. Apparently this feature works with other crafts as well :P

Thx for fixing the crash above... For now I have disabled the ability to use the quickcrafting until this new issue is fixed

EDIT: and another fatal crash:

2021-08-21 23:22:35: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'skinsdb' in callback on_joinplayer(): ...netest/MeseCraft/games/m
esecraft/mods/PLAYER/i3/init.lua:1724: attempt to get length of local 'items' (a nil value)
2021-08-21 23:22:35: ERROR[Main]: stack traceback:
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1724: in function 'get_items_fs'
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1830: in function 'get_panels'
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1724: in function 'get_items_fs' [456/1407]
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1830: in function 'get_panels'
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:2190: in function 'make_fs'
2021-08-21 23:22:35: ERROR[Main]: ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:2208: in function 'func'
2021-08-21 23:22:35: ERROR[Main]: ...aft/games/mesecraft/mods/ITEMS/3d_armor/3d_armor/api.lua:172: in function 'run_callbacks'
2021-08-21 23:22:35: ERROR[Main]: ...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/init.lua:49: in function 'update_player_visuals'
2021-08-21 23:22:35: ERROR[Main]: ...aft/games/mesecraft/mods/ITEMS/3d_armor/3d_armor/api.lua:328: in function 'set_player_armor'
2021-08-21 23:22:35: ERROR[Main]: ...st/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/api.lua:44: in function 'update_player_skin'
2021-08-21 23:22:35: ERROR[Main]: ...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/init.lua:61: in function <...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/i
nit.lua:60>
2021-08-21 23:22:35: ERROR[Main]: /home/minetest/MeseCraft/builtin/game/register.lua:422: in function </home/minetest/MeseCraft/builtin/game/register.lua:406>


that only happens when skinsdb is installed.

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

MisterE wrote:
Sat Aug 21, 2021 18:33
Players on my server reported that you can get more items than you normally could craft by using the quick crafting feature selecting the 1x setting, and spamclicking the craft button.
I'm unable to reproduce this bug in singleplayer. It might be possible to have a desynchronization between the inventory state and the GUI update, but in this case it's only fixable in the engine.
EDIT: and another fatal crash
I pushed a potential fix. Tell me if the crash still occurs.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

There is a simple fix to prevent crafting too much due to server desync:

When the player selects the amount and then crafts, the quickcrafting dialogue closes
to craft again, they have to press the quickcrafting button again. Theres no reason that you should be able to craft 1 recipe over and over again with the amt set at one, when you could just increase the amount and craft a bunch at once

the other option is to enforce a delay between clicking the craft button

Edit: the fatal error remains;

Code: Select all

2021-08-22 19:42:38: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'skinsdb' in callback on_joinplayer(): ...netest/MeseCraft/games/m
esecraft/mods/PLAYER/i3/init.lua:1724: attempt to get length of local 'items' (a nil value)                                      
2021-08-22 19:42:38: ERROR[Main]: stack traceback:                                                                                                                       
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1724: in function 'get_items_fs'                                     
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1830: in function 'get_panels'   
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1724: in function 'get_items_fs'                           [456/1808]
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:1830: in function 'get_panels'                     
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:2190: in function 'make_fs'                         
2021-08-22 19:42:38: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:2208: in function 'func'                                             
2021-08-22 19:42:38: ERROR[Main]:       ...aft/games/mesecraft/mods/ITEMS/3d_armor/3d_armor/api.lua:172: in function 'run_callbacks'                                     
2021-08-22 19:42:38: ERROR[Main]:       ...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/init.lua:49: in function 'update_player_visuals'                              
2021-08-22 19:42:38: ERROR[Main]:       ...aft/games/mesecraft/mods/ITEMS/3d_armor/3d_armor/api.lua:328: in function 'set_player_armor'                                  
2021-08-22 19:42:38: ERROR[Main]:       ...st/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/api.lua:44: in function 'update_player_skin'                                 
2021-08-22 19:42:38: ERROR[Main]:       ...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/init.lua:61: in function <...t/MeseCraft/games/mesecraft/mods/PLAYER/skinsdb/i
nit.lua:60>                                                                                                                                                              
2021-08-22 19:42:38: ERROR[Main]:       /home/minetest/MeseCraft/builtin/game/register.lua:422: in function </home/minetest/MeseCraft/builtin/game/register.lua:406>     

A hint is that this only occurs when a player joins the game, and it does not occur every time a player joins the game. It usually happens when the second or third player joins, but not always; sometimes players can join without a crash for quite a while.

-------------------------------------------
Also a feature request: this mod expands the player's inv. while I dont have a problem with that, when you look in a chest you can't see your full inv. I suggest an option to overwrite default inventory nodes, and in the readme give a code snippet to replace the usual players' inv formspec definition with one compatible with the new inventory.

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

MisterE wrote:
Sun Aug 22, 2021 15:47
There is a simple fix to prevent crafting too much due to server desync:

When the player selects the amount and then crafts, the quickcrafting dialogue closes
to craft again, they have to press the quickcrafting button again. Theres no reason that you should be able to craft 1 recipe over and over again with the amt set at one
I agree, pushed just now.
Edit: the fatal error remains;
Which commit are you on?
I suggest an option to overwrite default inventory nodes
An inventory mod is not responsible for that.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

Which commit are you on? I just downloaded it from the main repo. Will try again monday.

Players noticed that when you die the bag is gone... Id like it if the bag was added as an item to the world also, if this was intentional, could you add a settingtype pls?

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

I got another error. I dont know if it applies to the latest version but I suspect it does. I have not "tried again" yet as I said I would do today. Since its a nil value error it should be a simple fix.

Code: Select all


2021-08-23 17:12:37: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'i3' in callback on_leaveplayer(): ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:3050: attempt to index a nil value                                                                                                                                                        2021-08-23 17:12:37: ERROR[Main]: stack traceback:                                                                                                                                              2021-08-23 17:12:37: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:3050: in function 'save_data'                                                               2021-08-23 17:12:37: ERROR[Main]:       ...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:3061: in function <...netest/MeseCraft/games/mesecraft/mods/PLAYER/i3/init.lua:3059>        2021-08-23 17:12:37: ERROR[Main]:       /home/minetest/MeseCraft/builtin/game/register.lua:422: in function </home/minetest/MeseCraft/builtin/game/register.lua:406>  


User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

Well it seems like your version of i3 is not up-to-date.

Also, provide some steps to reproduce and details of your setup if you can (preferably on GitHub as it's best to track issues).

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

Ok... just updated i3. Will inform of any errors.

Also put skinsdb in again, and made sure that I got the version from contentdb: its possible that I got the wrong version of that too.

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

You must test i3 from the git tree: https://github.com/minetest-mods/i3/arc ... s/main.zip

And not from ContentDB which is not patched yet.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

I downloaded it directly from the repo, main branch.
https://github.com/minetest-mods/i3/


I downloaded *skinsdb* from contentdb to be sure I got the official version, a few hrs ago

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

Wellp, either you fixed the error crash or it was caused by using a wrong version of skinsdb. I dont know which. I would like to report another bug with the latest version: When you type in the item searchbar and then try to use the backspace key it works, but then as soon as you start typing again all the letters you deleted with the backspace key reappear. The only way to enter something else if you mistype is to either clear the searchbar with the x, or close the formspec. I think, using the x doesnt alwys work, either, but it might have been lag, or mis-remembering

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] i3 [1.3.2] [i3]

by jp » Post

That's an issue related to the engine.

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

ok, well, thank you for your hard work

User avatar
MisterE
Member
Posts: 693
Joined: Sun Feb 16, 2020 21:06
GitHub: MisterE123
IRC: MisterE
In-game: MisterE

Re: [Mod] i3 [1.3.2] [i3]

by MisterE » Post

feature suggestion: a craftgrid to inv button that transfers all items to the main inv if they can fit... also an "empty trash" button, or move the trash, I just threw away a stack of wood that I crafted by clicking on the trash as I crafted. It could have been something a bit more valuable

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot] and 10 guests