Minetest Forums

Code: Select all

2015-11-20 11:48:24: ERROR[Main]: ServerError: Runtime error from mod 'firearmslib' in callback environment_Step(): .../rubenwardy/.minetest/mods/mt-firearms/firearmslib/bullet.lua:20: attempt to compare nil with number
2015-11-20 11:48:24: ERROR[Main]: stack traceback:
2015-11-20 11:48:24: ERROR[Main]: 	.../rubenwardy/.minetest/mods/mt-firearms/firearmslib/bullet.lua:20: in function 'is_inside'
2015-11-20 11:48:24: ERROR[Main]: 	.../rubenwardy/.minetest/mods/mt-firearms/firearmslib/bullet.lua:72: in function 'find_collision_point'
2015-11-20 11:48:24: ERROR[Main]: 	.../rubenwardy/.minetest/mods/mt-firearms/firearmslib/bullet.lua:110: in function 'on_step'
2015-11-20 11:48:24: ERROR[Main]: 	....minetest/mods/mt-firearms/firearmslib/pureluaentity.lua:45: in function '__do_step'
2015-11-20 11:48:24: ERROR[Main]: 	....minetest/mods/mt-firearms/firearmslib/pureluaentity.lua:197: in function <....minetest/mods/mt-firearms/firearmslib/pureluaentity.lua:194>
2015-11-20 11:48:24: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:355: in function </usr/local/share/minetest/builtin/game/register.lua:335>

Code: Select all

local function is_inside(px, py, pz, x1, y1, z1, x2, y2, z2)
        --print(("*** DEBUG: Is inside? p=(%f,%f,%f), minp=(%f,%f,%f), maxp=(%f,%f,%f)"):format(px, py, pz, x1, y1, z1, x2, y2, z2))
        if px and py and pz and x1 and y1 and z1 and x2 and y2 and z2 then
                return (
                        (px >= x1) and (px <= x2)
                        and (py >= y1) and (py <= y2)
                        and (pz >= z1) and (pz <= z2)
                )
        else
                print("Error: " .. dump({ px=px, py=py, pz=pz, x1=x1, y1=y1, z1=z1, x2=x2, y2=y2, z2=z2 }))
                return false
        end
end

Code: Select all

local function find_collision_point(objtype, pos, node_or_obj)
        -- TODO:
        -- This should return the actual point where the bullet
        -- "collided" with it's target, or nil if it did not "hit".
        if objtype == "node" then
                local boxes
                local def = minetest.registered_nodes[node_or_obj.name]
                if not (def and def.walkable) then return end
                if (def.drawtype == "nodebox") and def.node_box and def.node_box.fixed then
                        boxes = def.node_box.fixed
                else
                        boxes = full_box
                end
                local px, py, pz =
                        pos.x - math.floor(pos.x) + 0.5,
                        pos.y - math.floor(pos.y) + 0.5,
                        pos.z - math.floor(pos.z) + 0.5
                if type(boxes[1]) == "number" then
                        local x1, y1, z1, x2, y2, z2 = unpack(boxes)
                        if is_inside(px, py, pz, x1, y1, z1, x2, y2, z2) then
                                return pos
                        end
                else
                         for _, box in ipairs(boxes) do
                                local x1, y1, z1, x2, y2, z2 = unpack(box)
                                if is_inside(px, py, pz, x1, y1, z1, x2, y2, z2) then
                                        return pos
                                end
                        end
                end
        elseif objtype == "object" then
                local objpos = node_or_obj:getpos()
                local px, py, pz =
                        pos.x - objpos.x,
                        pos.y - objpos.y,
                        pos.z - objpos.z
                local x1, y1, z1, x2, y2, z2
                if node_or_obj:is_player() then
                         x1, y1, z1, x2, y2, z2 = -0.25, -0.5, -0.25, 0.25, 1.25, 0.25
               else
                        local e = node_or_obj:get_luaentity()
                        if not (e and e.collisionbox) then
                                return
                        end
                        x1, y1, z1, x2, y2, z2 = unpack(e.collisionbox)
                end
                -- this is where it is called from:
                if is_inside(px, py, pz, x1, y1, z1, x2, y2, z2) then
                        return pos
                end
        end
end

Code: Select all

Error: {
	pz = -1.8512248349521,
	px = 0.52047790073571,
	py = 1.0474177973035
}