[Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

User avatar
Lone_Wolf
Member
 
Posts: 1509
Joined: Sun Apr 09, 2017 05:50
Location: Hometown server
GitHub: LoneWolfHT
IRC: Lone_Wolf
In-game: Lone_Wolf or Somebody

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Lone_Wolf » Wed Jun 14, 2017 05:56

Could I have the code for the admin armor set stu? With the shield? I'm having trouble figuring out what to seperate xD
 

User avatar
GreenDimond
Member
 
Posts: 947
Joined: Wed Oct 28, 2015 01:26
Location: Just outside of existence.
GitHub: GreenXenith
IRC: GreenDimond
In-game: GreenDimond

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by GreenDimond » Wed Jun 14, 2017 06:10

Lone_Wolf wrote:Could I have the code for the admin armor set stu? With the shield? I'm having trouble figuring out what to seperate xD

Admin armor: https://github.com/stujones11/minetest-3d_armor/blob/master/3d_armor/armor.lua#L6-L48
Admin shield: https://github.com/stujones11/minetest-3d_armor/blob/master/shields/init.lua#L28-L41
My YouTube channel. I moderate the HOMETOWN Server. My Mods: Tac Nayn - Sandplus - Waffles - Pumpkin Spice ✂️- - - - - -
 

User avatar
Lone_Wolf
Member
 
Posts: 1509
Joined: Sun Apr 09, 2017 05:50
Location: Hometown server
GitHub: LoneWolfHT
IRC: Lone_Wolf
In-game: Lone_Wolf or Somebody
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Sat Jul 22, 2017 14:26

For those wishing to use the latest minetest development builds, I have made the necessary changes to the armor player model. The files are available here and will need to be manually substituted for now. I will add a new feature branch to the repo as soon as possible, however, I am currenty experiencing build problems and am unable to test anything right now.
 

User avatar
TenPlus1
Member
 
Posts: 2072
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1
 

lonestar
Member
 
Posts: 36
Joined: Mon Jul 17, 2017 03:25
Location: Texas,USA

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by lonestar » Sat Jul 22, 2017 23:15

Loving the mod. I have made a few edits for my own personal use and I'm trying to get in contact with the original dev of the textures to see if I can release these to public.
Image
 

User avatar
Lone_Wolf
Member
 
Posts: 1509
Joined: Sun Apr 09, 2017 05:50
Location: Hometown server
GitHub: LoneWolfHT
IRC: Lone_Wolf
In-game: Lone_Wolf or Somebody

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Lone_Wolf » Sun Jul 23, 2017 01:24

lonestar wrote:Loving the mod. I have made a few edits for my own personal use and I'm trying to get in contact with the original dev of the textures to see if I can release these to public.
Image

Those are awesome! O_O
Do you really have to ask the dev of the textures though? I just put a link to the textures for mine. I'm going to redo from scratch soon though.
 

User avatar
TumeniNodes
Member
 
Posts: 2120
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by TumeniNodes » Sun Jul 23, 2017 02:48

lonestar wrote:Loving the mod. I have made a few edits for my own personal use and I'm trying to get in contact with the original dev of the textures to see if I can release these to public.


Those are beautiful!!!! Look like a wee bit more than "a few edits".
Of course you can release them to the public, as long as these are your own work... choose you're own license for them (CC BY-SA 3.0) is an option.

But do it quickly, I love them and want to use them!!! :P

<edit> wait... NVM I just now realized you mean you are waiting to hear from the dev of the textures you posted...
I thought you meant that you created these textures to replace the original ones from this mod, and were waiting to hear from daviddoesminetest who did the original 3d armor mod textures :P
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Wed Jul 26, 2017 18:05

Those are very nice textures indeed!

I just thought I would mention that the new MT 0.5.0 models have now been re-exported with vertex normals and split edges to work with the proposed advanced lighting feature #6165
 

User avatar
Beerholder
Member
 
Posts: 154
Joined: Wed Aug 03, 2016 20:23
In-game: Beerholder

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Beerholder » Sat Jul 29, 2017 10:37

Hi stu, my painted armor kept disappearing, and one of the culprits seems to be switching the wielded item. I noticed that there is no call being made to on_update when the wielded item is switched (in wieldview.update_wielded_item) and was wondering, shouldn't it do that in that case... I added an issue on GitHub as well. For now I just bluntly did an override of the method in my own code like this:

Code: Select all
if self.wielded_item[name] then
   if self.wielded_item[name] == item then
      return
   end
   armor.textures[name].wielditem = self:get_item_texture(item)
   armor:update_player_visuals(player)
   armor:run_callbacks("on_update", player) -- I ADDED THIS
end

Let me know what you think about this change... Or maybe I completely missed something and need more coffee? In any case, hope to get rid of that override, as replacing another mod's code could potentially break that other mod's internals of course O_o
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Sat Jul 29, 2017 14:10

Beerholder wrote:Hi stu, my painted armor kept disappearing, and one of the culprits seems to be switching the wielded item. I noticed that there is no call being made to on_update when the wielded item is switched (in wieldview.update_wielded_item) and was wondering, shouldn't it do that in that case... I added an issue on GitHub as well. For now I just bluntly did an override of the method in my own code like this:

Code: Select all
if self.wielded_item[name] then
   if self.wielded_item[name] == item then
      return
   end
   armor.textures[name].wielditem = self:get_item_texture(item)
   armor:update_player_visuals(player)
   armor:run_callbacks("on_update", player) -- I ADDED THIS
end

Let me know what you think about this change... Or maybe I completely missed something and need more coffee? In any case, hope to get rid of that override, as replacing another mod's code could potentially break that other mod's internals of course O_o


See my reply on #113, I will make this change as soon as possible.
 

User avatar
Beerholder
Member
 
Posts: 154
Joined: Wed Aug 03, 2016 20:23
In-game: Beerholder
 

Chem871
Member
 
Posts: 124
Joined: Sat Aug 19, 2017 21:49
Location: Ankh-Morpork
GitHub: Chemguy99
In-game: Chem

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Chem871 » Fri Aug 25, 2017 16:24

Stu, how do you think I should go about applying the time of day to a set of armor? I'm trying to make Day/Night armors, but I'm having difficulties with the code. Day armor should be strong in the day, but weak in the night, and Night armor should be the reverse.Any ideas?
 

User avatar
Hamlet
Member
 
Posts: 183
Joined: Sat Jul 29, 2017 21:09
Location: Italy, E.U.
GitHub: H4mlet
IRC: H4mlet

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Hamlet » Fri Aug 25, 2017 19:21

Chem871 wrote:Stu, how do you think I should go about applying the time of day to a set of armor? I'm trying to make Day/Night armors, but I'm having difficulties with the code. Day armor should be strong in the day, but weak in the night, and Night armor should be the reverse.Any ideas?


I'm working on a mod using the time of day check, so far I've gathered these informations:

To get the time of day:

Code: Select all
local time = minetest.get_timeofday(val)


lua_api.txt wrote:* `val` is between `0` and `1`; `0` for midnight, `0.5` for midday


Not very good for fine tuning, then it could be better to convert it in the same /time command's format:

Code: Select all
time = time * 24000


Doing some inworld tests with the /time command I've discovered that basically it's the same as military time, e.g.:

0000 = 00:00 / midnight
5000 = 05:00 / 5 am
12000 = 12:00 / midday
19000 = 19:00 / 7 pm

and so on.

Thus I would do something like this:

Code: Select all
PSEUDOCODE

local armor_rating = 100

minetest.register_abm(is it daytime or not?, check every X seconds)

if (time >= 5000) and (time < 19000) -- from dawn to dusk
   armor_rating = 100
else
   armor_rating = 50
end


MirceaKitsune's moonflower mod is a good example; I hope that these informations can help you in some way.
 

User avatar
azekill_DIABLO
Member
 
Posts: 6303
Joined: Wed Oct 29, 2014 20:05
Location: Pixelator
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 

User avatar
Grossam
Member
 
Posts: 11
Joined: Sun Apr 02, 2017 07:21
Location: Bourges
GitHub: Grossam
IRC: Grossam
In-game: Grossam

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Grossam » Mon Sep 04, 2017 10:17

Hi !

I'm using you api to create a new armor, but I'm lost in all those groups : How the use_armor and the damage_groups work and what physics groups are available.

Is there a place where all these informations are gathered ?

TY !
Gloire à qui, n'ayant pas d'idéal sacro-saint,
Se borne à ne pas trop emmerder ses voisins.
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Fri Sep 08, 2017 20:44

Grossam wrote:Hi !

I'm using you api to create a new armor, but I'm lost in all those groups : How the use_armor and the damage_groups work and what physics groups are available.

Is there a place where all these informations are gathered ?

TY !

From what I recall, the damage_groups determine the amount of damage the armor takes based on the weapons respective level. It uses the same algo as node damage, more or less.

I apologise for the poor documentation, improving that is on my todo list :)
 

User avatar
Edward
New member
 
Posts: 6
Joined: Tue Sep 26, 2017 15:20

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Edward » Mon Oct 02, 2017 03:27

Hello,

I'm having an issue with this mod, where the damage received from mob attacks is always reduced to 0 and the durability of armor parts isn't affected. This happens to me in Minetest 0.4.16-stable (Linux amd64), using just minetest_default, 3d_armor(from git in this topic), mobs_redo and ... well... mobs.

My tests with git bisect showed me the very first commit where this problem happens to be this one. If I had more information about the concept and inner workings of the armors it might help me pinpoint the problem and issue a pull request sooner.
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Tue Oct 03, 2017 17:49

Edward wrote:Hello,

I'm having an issue with this mod, where the damage received from mob attacks is always reduced to 0 and the durability of armor parts isn't affected. This happens to me in Minetest 0.4.16-stable (Linux amd64), using just minetest_default, 3d_armor(from git in this topic), mobs_redo and ... well... mobs.

My tests with git bisect showed me the very first commit where this problem happens to be this one. If I had more information about the concept and inner workings of the armors it might help me pinpoint the problem and issue a pull request sooner.


Unfortunately, this is quite often the case with mobs. I have introduced a number of new features that should allow other mods/mobs to damage the armor even if the player is unharmed but it is up to other modders to make use of these. However, since you can narrow this down to one specific commit then it does suggest that something got changed in the armor level algorithm at that time.

This should be easy enough to trace though it will likely be the weekend before I can get a test environment set up. In the meantime you could try adjusting the `armor_level_multiplier` config to decrease the overall armor effectiveness and/or inspect the player's actual armor levels before and after the breaking commit using something like this:

Code: Select all
   print(dump(player.get_armor_groups()))

Thank you for the report.
 

User avatar
ExeterDad
Member
 
Posts: 1537
Joined: Sun Jun 01, 2014 20:00
Location: New Hampshire U.S.A
In-game: ExeterDad

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by ExeterDad » Tue Oct 03, 2017 18:10

This is good news! Hopefully you guys nail it down. The armor being OP when it comes to mobs is why I was resistant to adding armor to our server in the beginning. But of course player demand made me cave and add it. Heh heh... this is gonna be fun :)
 

User avatar
stu
Member
 
Posts: 805
Joined: Sat Feb 02, 2013 02:51
Location: United Kingdom
GitHub: stujones11

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by stu » Tue Oct 03, 2017 18:32

ExeterDad wrote:This is good news! Hopefully you guys nail it down. The armor being OP when it comes to mobs is why I was resistant to adding armor to our server in the beginning. But of course player demand made me cave and add it. Heh heh... this is gonna be fun :)


It's really quite a tricky problem to overcome because decreasing armor effectiveness makes it useless against players, while increasing mob damage would be unsuitable for those not using armor. The only real solution is for the mob writers to either self-adjust for armor or at least expose some sort of global damage coefficient, much like this mod does ;)
 

User avatar
Edward
New member
 
Posts: 6
Joined: Tue Sep 26, 2017 15:20

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Edward » Tue Oct 03, 2017 20:00

stu wrote:Unfortunately, this is quite often the case with mobs. I have introduced a number of new features that should allow other mods/mobs to damage the armor even if the player is unharmed but it is up to other modders to make use of these.


Every time I assembled mod collections for my own personal enjoyment in the past, I always got confused as to why certain combinations resulted in bug-fests and server crashes while others just plainly worked. Then I noticed a pattern, that seemed to indicate that as the number of different authors on the collection grows, so would the chance of issues... it always ended up being about how much issues I was willing to tolerate to get a game as close to what I wanted at the time.
 

User avatar
TumeniNodes
Member
 
Posts: 2120
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by TumeniNodes » Tue Oct 03, 2017 21:04

Edward wrote:Every time I assembled mod collections for my own personal enjoyment in the past, I always got confused as to why certain combinations resulted in bug-fests and server crashes while others just plainly worked. Then I noticed a pattern, that seemed to indicate that as the number of different authors on the collection grows, so would the chance of issues... it always ended up being about how much issues I was willing to tolerate to get a game as close to what I wanted at the time.


One aspect some do not think about is this..., when someone creates a mod, they create it to work with MTG, not to work with other mods (for the most part) so, yes, your statement is true in regards to various mod authors.

But, when a single individual is working on a mod, chances are they have other mods they have created in the pot already, which is why one of their mods, will work seamlessly with their other mods.

As stu has stated, he has done preemptive work related to his mod, to help creators of related mods close the seam between theirs and his, if they don't use it, it is on them.

The work is never complete until every possible combination of other enabled mods is tried (which kinda means, never really :P ) and bugs/conflicts are reported.

note: "it doesn't work for me" is not a bug/conflict report ; )

looking back my comment seems confusing but, there it is. It is the best I can put thoughts and words together today, sorry.
 

User avatar
Edward
New member
 
Posts: 6
Joined: Tue Sep 26, 2017 15:20

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Edward » Tue Oct 03, 2017 22:56

No problem. Like I have hinted earlier, I do plan on contributing and helping to solve these problems with multiple mods. 3d_armor is one of them. I just let stu know about the problem and didn't do much more than a git bisect because I am prioritizing my subgame project right now. It's still crap, and not really more than just an, apparently random, collection of roughly 100 mods... but I intend to work together as much as I can with original mod authors, in order to do various things: from simple code maintenance to trying to fix things in a way that benefits both my forks as well as the original upstream. So, once I get to take a close look at 3d_armor's code, if stu hasn't figured out something by then I will try my best and forward my solutions for 3d_armor to him if I have them.
 

User avatar
Aerozoic
Member
 
Posts: 13
Joined: Mon Jul 24, 2017 15:04
GitHub: aerozoic
In-game: Aerozoic cessna151

Re: [Modpack] 3D Armor [0.4.9] [minetest-3d_armor]

by Aerozoic » Tue Oct 10, 2017 13:15

stu, support for your 3d armor was completely removed from xdecor's enchanting: https://github.com/minetest-mods/xdecor/issues/81
“For once you have tasted flight, you will forever walk the earth with your eyes turned skyward, for there you have been, and there you will always long to return.”
 

PreviousNext

Return to Mod Releases



Who is online

Users browsing this forum: No registered users and 8 guests