[Mod] Item frames and pedestal [github] [itemframes]

[jojoa1997]

A bug I found making this http://forum.minetest.net/viewtopic.php ... 616#p84616 was when I exited the items were not saved. Maybe you should have it ,make an entity form each item.

[Zeg9]

The items are saved inside the node itself, it should reappear after 5 seconds IIRC.
EDIT: fixed the abm, now it should reappear after 2 seconds. The problem was that it had 1/2 chance of happening.

[Inocudom]

Is this mod still being worked on? If so, would it be possible to make locked frames and frames capable of having more than one item in them?

[Zeg9]

Is this mod still being worked on? If so, would it be possible to make locked frames and frames capable of having more than one item in them?

Frames are locked by default, but I may work on having more items (if I get enough motivation ).

[Inocudom]

You could make display pedestals to go along with the frames.

With some items (like the doors of the homedecor mod) the game crashes and the stack-traceback-nil-value error comes up when you try to display them in frames.

[Zeg9]

You could make display pedestals to go along with the frames.

With some items (like the doors of the homedecor mod) the game crashes and the stack-traceback-nil-value error comes up when you try to display them in frames.

I like the idea of pedestals. Should items auto-rotate when placed above ?
Thanks for bug reporting. I'll try to fix it this afternoon.

[Inocudom]

They could auto-rotate on one type of pedestal and be still on another type.

[Zeg9]

UPDATE:
Add pedestals and use staticdata for entity
This breaks existing item frames, just take the item out and put it back.
Items are NOT lost, only the visual will show "unknown node" or similar.

[Zeg9]

Are the items rotating?

Yes, they are. if you want it might be changed.

[webdesigner97]

When I try to put a "mahagony Closet door (homedecor) into an itemframe or pedestal, the game crashes saying:

itemframes/init.lua:125 attempt to index local 'itemstack' (a nil value)

But I like the idea of the mod! It's great!

[Zeg9]

When I try to put a "mahagony Closet door (homedecor) into an itemframe or pedestal, the game crashes saying:

itemframes/init.lua:125 attempt to index local 'itemstack' (a nil value)

But I like the idea of the mod! It's great!

I'll try to fix this. But maybe the only way to do is to forbid placing these items (still better than crashing).
Will edit this post when done...
EDIT: done, it won't crash server anymore, but you still won't be able to place them.
EDIT2: actually the bug is in homedecor.
It should work if you add ", itemstack" after "placer" at the end of line 297 of doors_and_gates.lua:
https://github.com/VanessaE/homedecor/b ... s.lua#L297

[Inocudom]

When I try to put a "mahagony Closet door (homedecor) into an itemframe or pedestal, the game crashes saying:

itemframes/init.lua:125 attempt to index local 'itemstack' (a nil value)

But I like the idea of the mod! It's great!

I'll try to fix this. But maybe the only way to do is to forbid placing these items (still better than crashing).
Will edit this post when done...
EDIT: done, it won't crash server anymore, but you still won't be able to place them.
EDIT2: actually the bug is in homedecor.
It should work if you add ", itemstack" after "placer" at the end of line 297 of doors_and_gates.lua:
https://github.com/VanessaE/homedecor/b ... s.lua#L297

The signs of the homedecor mod also cause the itemstack error. It looks like you and VanessaE will have to go through the homedecor mod and see what can be done.

[Zeg9]

The signs of the homedecor mod also cause the itemstack error. It looks like you and VanessaE will have to go through the homedecor mod and see what can be done.

EDIT: It should work now (just update homedecor), thanks to VanessaE for fixing it !

[VanessaE]

For others in this thread, the itemstack issue in homedecor has been fixed.

[webdesigner97]

For others in this thread, the itemstack issue in homedecor has been fixed.

Great!

[lonely]

Forget creative mode. Mainly when you place an item in a frame the item is taken.

not to me

[Froggy]

I found a bug.

I crafted an itemframe, and put it on a wall. When I tried to put a diamond on it, it crashed the server I was on. I tested with other materials, and I had no problems. So, I crafted another itemframe and put it next to the original that caused the crash, and when I put a diamond in it, nothing out of the ordinary happened. I'm not sure if it's the itemframe, its placement, or the material placed in it that caused the crash, but all I know is that a diamond on that specific itemframe crashes the server I was on.

[Zeg9]

I found a bug.

I crafted an itemframe, and put it on a wall. When I tried to put a diamond on it, it crashed the server I was on. I tested with other materials, and I had no problems. So, I crafted another itemframe and put it next to the original that caused the crash, and when I put a diamond in it, nothing out of the ordinary happened. I'm not sure if it's the itemframe, its placement, or the material placed in it that caused the crash, but all I know is that a diamond on that specific itemframe crashes the server I was on.

Do you have any log (debug.txt) of what happened?
Does putting an itemframe at the exact same place cause the same crash?

[yohanes828]

how to make a image
=_ = |p

[VanessaE]

You need to embed the image address in img tags

[Chinchow]

Zeg9 is it possible to change how far the Item is from the pedestal and is it possible to stop the spinning?

[VanessaE]

Can you make it so that just anyone (or say, someone with a given privilege) can punch these to update them, e.g. if the original owner isn't around after a /clearobjects ?

[CraigyDavi]

Can you make it so that just anyone (or say, someone with a given privilege) can punch these to update them, e.g. if the original owner isn't around after a /clearobjects ?

That's a good idea. I'd like too see this too, on this mod, if it is still being worked on.

[falsegrayburger]

Great mod

[VanessaE]

[02-15 12:41] <VE-Survival> <AspireMint> month ago i put bannana to frame, and today/yesterday i right-clicked on frame, and then put bannana to frame
[02-15 12:41] <VE-Survival> <AspireMint> so i updated this old frame

He told me of this error after the fact. The banana probably got removed due to /clearobjects at some point after the first add event. This was the resultant error in the log:

terminate called after throwing an instance of 'ServerError' what(): .../games/vanessae_game/mods/itemframes/itemframes/init.lua:69: attempt to index local 'posad' (a nil value)
stack traceback:
.../games/vanessae_game/mods/itemframes/itemframes/init.lua:69: in function 'update_item'
.../games/vanessae_game/mods/itemframes/itemframes/init.lua:124: in function 'on_rightclick'
/usr/local/share/minetest/builtin/item.lua:326: in function </usr/local/share/minetest/builtin/item.lua:319>
/home/minetest/Scripts/minetestserver-survival.sh: line 25: 10535 Aborted