[Mod] Mesecons (= redstone) [GitHub] [minetest-mod-mesecons]

Gatharoth · by **Gatharoth** » Fri Mar 16, 2012 08:38 Post

Okay, I'm getting a weird error. mesecon:register_on_signal_on isn't working anymore for me.

I've been working on an addon to temperest's code. (see here) When all of a sudden I get this error.

Code: Select all

01:31:14: ERROR[main]: [LUA] ...inetest\bin\..\data\mods\mesecons_temperest\init.lua:323: attempt to call method 'register_on_signal_on' (a nil value)

This happens even when I put the function inside it.

So like

Code: Select all

mesecon:register_on_signal_on(function(pos, node)
    if node.name=="mesecons_temperest:duali" then
    minetest.chat_send_player("Gatharoth", "running check.")
        if check_dual(pos) then
            local lnode = minetest.env:get_node({x=pos.x-1, y=pos.y, z=pos.z}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x-2, y=pos.y, z=pos.z}) end
        
            local lnode = minetest.env:get_node({x=pos.x+1, y=pos.y, z=pos.z}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x+2, y=pos.y, z=pos.z}) end
        
            local lnode = minetest.env:get_node({x=pos.x, y=pos.y, z=pos.z-1}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x, y=pos.y, z=pos.z-2}) end
        
            local lnode = minetest.env:get_node({x=pos.x, y=pos.y, z=pos.z+1}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x, y=pos.y, z=pos.z+2}) end
        end
    end
end)

Still ends with the same error.

by **sfan5** » Fri Mar 16, 2012 13:44 Post

Gatharoth wrote:Okay, I'm getting a weird error. mesecon:register_on_signal_on isn't working anymore for me.

I've been working on an addon to temperest's code. (see here) When all of a sudden I get this error.

Code: Select all

01:31:14: ERROR[main]: [LUA] ...inetest\bin\..\data\mods\mesecons_temperest\init.lua:323: attempt to call method 'register_on_signal_on' (a nil value)

This happens even when I put the function inside it.

So like

Code: Select all

mesecon:register_on_signal_on(function(pos, node)
    if node.name=="mesecons_temperest:duali" then
    minetest.chat_send_player("Gatharoth", "running check.")
        if check_dual(pos) then
            local lnode = minetest.env:get_node({x=pos.x-1, y=pos.y, z=pos.z}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x-2, y=pos.y, z=pos.z}) end
        
            local lnode = minetest.env:get_node({x=pos.x+1, y=pos.y, z=pos.z}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x+2, y=pos.y, z=pos.z}) end
        
            local lnode = minetest.env:get_node({x=pos.x, y=pos.y, z=pos.z-1}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x, y=pos.y, z=pos.z-2}) end
        
            local lnode = minetest.env:get_node({x=pos.x, y=pos.y, z=pos.z+1}) --a node between this node and the one two nodes away
            if lnode.name=="air" then set_node_on({x=pos.x, y=pos.y, z=pos.z+2}) end
        end
    end
end)

Still ends with the same error.

The Function just don't exist.
Something must be wrong with the Mesecons init.lua

Hackeridze · by **Hackeridze** » Fri Mar 16, 2012 14:24 Post

Fix:
https://github.com/Hackeridze/Ru-true-m ... 1fac67c997
And fix of fix:
https://github.com/Hackeridze/Ru-true-m ... c329a67681

Gatharoth · by **Gatharoth** » Fri Mar 16, 2012 18:14 Post

sfan5 wrote:The Function just don't exist.
Something must be wrong with the Mesecons init.lua

The problem is, it does exist; And it works. If I take out my code, and let it load, calling that function works. I mean, if you want proof, here it is in the movesontes.

Code: Select all

mesecon:register_on_signal_on(function (pos, node)
    if node.name=="mesecons_movestones:movestone" then
        local direction=mesecon:get_movestone_direction({x=pos.x, y=pos.y, z=pos.z})
        local checknode={}
        local collpos={x=pos.x, y=pos.y, z=pos.z}
        repeat -- Check if it collides with a stopper
            collpos={x=collpos.x+direction.x, y=collpos.y+direction.y, z=collpos.z+direction.z}
            checknode=minetest.env:get_node(collpos)
            if mesecon:is_mvps_stopper(checknode.name) then 
                return 
            end
        until checknode.name=="air"
        or checknode.name=="ignore" 
        or checknode.name=="default:water" 
        or checknode.name=="default:water_flowing" 
        minetest.env:remove_node(pos)
        nodeupdate(pos)
        minetest.env:add_entity(pos, "mesecons_movestones:movestone_entity")
    end
end)

by **sfan5** » Fri Mar 16, 2012 18:26 Post

Weird!

Temperest · by **Temperest** » Fri Mar 16, 2012 18:36 Post

Gatharoth wrote:

sfan5 wrote:The Function just don't exist.
Something must be wrong with the Mesecons init.lua

The problem is, it does exist; And it works. If I take out my code, and let it load, calling that function works. I mean, if you want proof, here it is in the movesontes.

Code: Select all

mesecon:register_on_signal_on(function (pos, node)
    if node.name=="mesecons_movestones:movestone" then
        local direction=mesecon:get_movestone_direction({x=pos.x, y=pos.y, z=pos.z})
        local checknode={}
        local collpos={x=pos.x, y=pos.y, z=pos.z}
        repeat -- Check if it collides with a stopper
            collpos={x=collpos.x+direction.x, y=collpos.y+direction.y, z=collpos.z+direction.z}
            checknode=minetest.env:get_node(collpos)
            if mesecon:is_mvps_stopper(checknode.name) then 
                return 
            end
        until checknode.name=="air"
        or checknode.name=="ignore" 
        or checknode.name=="default:water" 
        or checknode.name=="default:water_flowing" 
        minetest.env:remove_node(pos)
        nodeupdate(pos)
        minetest.env:add_entity(pos, "mesecons_movestones:movestone_entity")
    end
end)

I think it might be helpful if you posted the entire file somewhere, maybe the issue is with where it was put? I'm no Lua expert, but that code looks perfectly fine to me by itself.

Gatharoth · by **Gatharoth** » Fri Mar 16, 2012 18:37 Post

sfan5 wrote:Weird!

Could it be that I'm calling it, after it's already called?

I'm adding to temperest's code; just something that will strickly be used for things like in his OGAM. And it's called there once already.

But then again, it was working fine until I tried to set the mesecon_on to a local and see if that would fix the problem I was having before this. Which was "if" functions were failing even though everything should have matched up correctly.

@Temperest

All of the code is at here

The only changes to it are names, and its put right under your code.

EDIT: Alright, for what every reason its all working now. Everything!!

Temperest · by **Temperest** » Fri Mar 16, 2012 19:40 Post

Gatharoth wrote:EDIT: Alright, for what every reason its all working now. Everything!!

Must be the magical code gremlins again.

Gatharoth · by **Gatharoth** » Fri Mar 16, 2012 19:43 Post

Temperest wrote:
Gatharoth wrote:EDIT: Alright, for what every reason its all working now. Everything!!
Must be the magical code gremlins again.

IKR!? Scary little bastards. lol

by **celeron55** » Sat Mar 17, 2012 09:40 Post

Missing license information; please fill in ASAP.

Jeija · by **Jeija** » Sun Mar 18, 2012 11:06 Post

Filled in the license; as you might have noticed I'm currently away; if there is anything that has to be changed, could please sfan5 or Temperest commit it on GitHub?
I did not read the whole thread since then but I think there was some bug and there is another thread with an AND gate; if there is any code to commit please do it!

by **sfan5** » Sun Mar 18, 2012 11:22 Post

Jeija wrote:Filled in the license; as you might have noticed I'm currently away; if there is anything that has to be changed, could please sfan5 or Temperest commit it on GitHub?
I did not read the whole thread since then but I think there was some bug and there is another thread with an AND gate; if there is
any code to commit please do it!

Welcome back!

Temperest · by **Temperest** » Sun Mar 18, 2012 15:28 Post

Hackeridze wrote:Fix:
https://github.com/Hackeridze/Ru-true-m ... 1fac67c997
And fix of fix:
https://github.com/Hackeridze/Ru-true-m ... c329a67681

Commited to upstream.

by **sfan5** » Sun Mar 18, 2012 15:32 Post

xyz · by **xyz** » Sun Mar 18, 2012 16:45 Post

Meselamps do not work, fix it please.

Temperest · by **Temperest** » Sun Mar 18, 2012 17:49 Post

xyz wrote:Meselamps do not work, fix it please.

Fixed.

bgsmithjr · by **bgsmithjr** » Tue Mar 20, 2012 19:51 Post

Idea for wireless.
Have a number on the inverter, transmitter, or receiver. Every time you punch the block it increases by one; this is it's channel. A transmitter on channel 1, is received by inverters and receivers on channel 1.

Temperest · by **Temperest** » Tue Mar 20, 2012 22:12 Post

bgsmithjr wrote:Idea for wireless.
Have a number on the inverter, transmitter, or receiver. Every time you punch the block it increases by one; this is it's channel. A transmitter on channel 1, is received by inverters and receivers on channel 1.

We already have channels; if you place a transmitter on glass, only receivers placed on glass will receive signals from this transmitter. I personally think this is easier to use than explicit numbers.

Gatharoth · by **Gatharoth** » Tue Mar 20, 2012 22:27 Post

Temperest wrote:
bgsmithjr wrote:Idea for wireless.
Have a number on the inverter, transmitter, or receiver. Every time you punch the block it increases by one; this is it's channel. A transmitter on channel 1, is received by inverters and receivers on channel 1.
We already have channels; if you place a transmitter on glass, only receivers placed on glass will receive signals from this transmitter. I personally think this is easier to use than explicit numbers.

Easier to use, yes. But purposes a limit, where as explicit numbers wouldn't have this limit, but wouldn't be very easy on the end-user.

With numbers, you could have a channel for every node in the entire world, which is roughly 238,328,000,000,000(1) channels. Course that would roughly be the entire world of nothing but transmitters, and no room for a player, or any other nodes.

Both cases have strong points and weak points.

notes:
(1): Rough estimate based on the statement "Almost infinite world (limited to +-31000 blocks in all directions at the moment)" 62,000^3

Gatharoth · by **Gatharoth** » Tue Mar 20, 2012 22:57 Post

Here's a bug I noticed while playing in singleplayer (not advanced!). For what ever reason, I cannot dig any of the mesecons' nodes. Tried all tools in default, as well as barehanded. Cannot dig them up.

bgsmithjr · by **bgsmithjr** » Tue Mar 20, 2012 23:59 Post

replace all the digprop blah blah stonelike
with groups = {snap=1, crackle=2, pop=3}
lol. cracky, snappy, crumbly

Sartan · by **Sartan** » Wed Mar 21, 2012 08:25 Post

Can give on a reference on the working version of transmitters, receivers and Inverters?

Temperest · by **Temperest** » Thu Mar 22, 2012 21:52 Post

Gatharoth wrote:Here's a bug I noticed while playing in singleplayer (not advanced!). For what ever reason, I cannot dig any of the mesecons' nodes. Tried all tools in default, as well as barehanded. Cannot dig them up.

This has been fixed, and mesecons is now compatible with the latest build.

Jeija · by **Jeija** » Fri Mar 23, 2012 15:24 Post

Wow thanks a lot Temperest!! This must have been a lot of work!!!
Btw I'm back now and I'm really surprised and happy about the progress that minetest has made.

mrgasp · by **mrgasp** » Fri Mar 23, 2012 16:28 Post

Temperest wrote:
Gatharoth wrote:Here's a bug I noticed while playing in singleplayer (not advanced!). For what ever reason, I cannot dig any of the mesecons' nodes. Tried all tools in default, as well as barehanded. Cannot dig them up.
This has been fixed, and mesecons is now compatible with the latest build.

Thank you, my server is fixed now

Minetest Forums

[Mod] Mesecons (= redstone) [GitHub] [minetest-mod-mesecons]

join me

join me

Who is online