[Modpack] Animals Modpack [2.5] -- 2.6 approaching

[deivan]

I thinking in many small monsters like the slime mod.

[Jouster27]

I noticed that the ostrich eggs were displaying as "Unknown". I took a look at the files and found the following:

animalmaterials init.lua

minetest.register_craftitem("animalmaterials:egg_big", {
description = "Egg (big)",
image = "animalmaterials_egg_big.png",
stack_max=5

...

animalmaterialsdata["animalmaterials_egg_big"] = {
graphics_3d = {
visual = "mesh",
mesh = "animalmaterials_egg_ent.b3d",
textures = { "animalmaterials_egg_ent_mesh.png" },
collisionbox = { -0.24,-0.25,-0.24,0.24,0.25,0.24 },
visual_size = {x=2,y=2,z=2},
}

mob_ostrich init.lua

random_drop = {
result="animalmaterials:big_egg",
min_delay=300,
chance=0.1

Not sure if it's supposed to be "big_egg" or "egg_big" but I've got a strong suspicion they're supposed to match. Would someone fix this, please?

[korkut]

I've just released first preview version of 2.1 plz start testing
known Issues:
mobf_settings -> Tools menu doesn't work correct (bugfix in minetest required)
fighting -> no harm is done to mobs ... not quite sure what I did wrong when switching to new damage mechanism ... any suggestions?

let's look at old vombie

Code: Select all

 armor_groups= {
   fleshy=3,
   daemon=1,
 }

Each key describe the "element" that can damage the mob. Number indicates the purity of the element, i.e. vombie has a "3" fleshiness which is ordinary, while "1" is highly daemonic. Lower the rating, lesser affected the mob by the element. My workaround maps ratings something like {33,50,100,133}. New code replaces ratings with straight percentages, so it is basicaly a damage multiplier for the given element now.

Now the steel sword in default common:

Code: Select all

tool_capabilities = {
full_punch_interval = 0.8,
max_drop_level=1,
groupcaps={
  snappy={times={[1]=2.5, [2]=1.20, [3]=0.35}, uses=30, maxlevel=2},
},
damage_groups = {fleshy=6},
}

It simply says 6 damage to ordinary flesh targets. So a hypotetical daemonic weapon with damage_groups = {daemon=9} would deal 33% * 9 = 3 damage and the steel sword will 100%*6=6 damage. You can add an "angelic" key with value 1000 to vombie and a garlic mallet with {angelic=1} would deal 10 damage.

Correct fix would be replacing rating definitions of all the mobs with balanced percentages.

[sapier]

Jouster27 you're right I'll fix this thx
korkut thx too I think I may have just to do some fine tuning with the values ... at least stone sword seams to do some damage

[Jouster27]

I'm getting errors while trying to capture a wolf (or dog, whichever the grey one is):

22:21:26: ACTION[ServerThread]: Jouster punches object 2: LuaEntitySAO at (-177.395,24,89.1855)
22:21:26: ACTION[ServerThread]: LuaEntitySAO at (-177.395,24,89.1855) punched by player Jouster, damage 0 hp, health now 5 hp
22:21:26: ACTION[ServerThread]: Jouster leaves game. List of players: Elzzira
22:21:27: ERROR[main]: ServerError: LuaError: error running function 'on_punch': ...dmods/animals_modpack-mobf_2_1_dev/mobf/fighting.lua:194: attempt to compare number with nil
22:21:27: ERROR[main]: stack traceback:

I got similar errors when trying to punch a vombie as well.

[sapier]

I've just released a new prerelease version of mobf.

Plz have a closer look at behaviour of vombie if you have latest core with pathfinding support.

2.0.81 is now feature complete, only polishing will be done until 2.1

@Jouster27 this bug should be fixed in 2.0.81 too

[Jouster27]

Sorry Sapier, dev 2.1 gives the following error:

21:38:14: ERROR[main]: ========== ERROR FROM LUA ===========
21:38:14: ERROR[main]: Failed to load and run script from
21:38:14: ERROR[main]: /home/jouster/.minetest/worlds/Jasoom/worldmods/animals/mobf/init.lua:
21:38:14: ERROR[main]: ...netest/worlds/Jasoom/worldmods/animals/mobf/init.lua:54: module 'luatrace' not found:
21:38:14: ERROR[main]: no field package.preload['luatrace']
21:38:14: ERROR[main]: no file './luatrace.lua'
21:38:14: ERROR[main]: no file '/usr/local/share/lua/5.1/luatrace.lua'
21:38:14: ERROR[main]: no file '/usr/local/share/lua/5.1/luatrace/init.lua'
21:38:14: ERROR[main]: no file '/usr/local/lib/lua/5.1/luatrace.lua'
21:38:14: ERROR[main]: no file '/usr/local/lib/lua/5.1/luatrace/init.lua'
21:38:14: ERROR[main]: no file './luatrace.so'
21:38:14: ERROR[main]: no file '/usr/local/lib/lua/5.1/luatrace.so'
21:38:14: ERROR[main]: no file '/usr/local/lib/lua/5.1/loadall.so'
21:38:14: ERROR[main]: stack traceback:
21:38:14: ERROR[main]: [C]: in function 'require'
21:38:14: ERROR[main]: ...netest/worlds/Jasoom/worldmods/animals/mobf/init.lua:54: in main chunk
21:38:14: ERROR[main]: =======END OF ERROR FROM LUA ========

I'll try the new 2.0.82 now...

[Jouster27]

Well, I tried 2.0.82. At least I can get this version to run but it still has the same problem. When I click the wolf with a lasso, the game crashes:

22:11:45: ERROR[ServerThread]: LuaEntity name "animal_vombie:vombie_spawner_at_night" not defined
22:11:45: ERROR[ServerThread]: LuaEntity name "animal_vombie:vombie_spawner_at_night" not defined
22:11:50: ACTION[ServerThread]: singleplayer punches object 5: LuaEntitySAO at (-181.972,24,91.3924)
22:11:50: ACTION[ServerThread]: LuaEntitySAO at (-181.972,24,91.3924) punched by player singleplayer, damage 0 hp, health now 5 hp
22:11:50: ACTION[ServerThread]: singleplayer leaves game. List of players:
22:11:51: ERROR[main]: ServerError: LuaError: error running function 'on_punch': ...m/worldmods/animals_modpack-2.0.82/mobf/fighting.lua:194: attempt to compare number with nil
22:11:51: ERROR[main]: stack traceback:

In addition, I had the vombie spawning turned-on at one point but turned it off. Now I've got an unknown object that I can't get rid of.

[sapier]

Jouster27 fixed fighting crash in git version will be included in 2.0.83
thanks for your bug report

[clarksallador]

i have a question:
why cant i kill a mob?i tried hitting them with every item but still no damage ... can you help me please

[Calinou]

i have a question:
why cant i kill a mob?i tried hitting them with every item but still no damage ... can you help me please

Update Minetest to 0.4.6 -- see http://minetest.net/download.

[clarksallador]

i have the latest update .. but still cannot kill a mob

[jojoa1997]

Do you have the dev version or stable?

[clarksallador]

@jojoa1997- yeah i have it

[sapier]

@all
if you have found a bug plz try to add following information:
(exact) Minetest version
(exact) Mobf version
Last lines of console trace (everything that may be related, number of lines varies dependig on error)

[Nebucad]

i have the latest update .. but still cannot kill a mob

your problem sounds for me familiar. Go to post 936.

[Jonathan]

I love this mod, and the flexibility to modify, add, and remove creatures. For my personal use, I removed most creatures and I modified the npc trader so guards and archers could be purchased with wood (to be able to easy rebuild armies after destroyed). I also tweaked so one player's soldiers can defeat another player's soldiers (originally they would fight forever). In the Minetest game I played with my brothers, I seized my brother's castle by placing around 25 soldiers in the courtyard and outside lol.

Unfortunately, my brother is having issues joining the game now (minetest 0.4.5) that I have to figure out how to fix it (probably too many soldiers in one location and/or his player got in some odd state lol).

[deivan]

Is a very nice idea to a mod, have your code in some place to download Jonathan?

[Jonathan]

Is a very nice idea to a mod, have your code in some place to download Jonathan?

No, I don't. Besides, this is sapier's mod which might include some of these type of changes in the future. Although below is what I replaced:

In the mob_npc init.lua I replaced the trader_inventory group:

Code: Select all

trader_inventory = {
                goods = {
                            { "mob_archer:archer 1","default:tree 4",nil},
                            { "mob_guard:guard 1","default:tree 4",nil},
                        },
                random_names = {"Honest Hank","Hungry Hungry Hans","Flip Flop Franz","Tough Tom","Frantic Fritz","Timid Thomas","Marvelous Martin","Furry Frank","Bobblehead Bobby","Sticky Stinky Steve"},
            }
        }

In the mobf fighting.lua around line 845:

Code: Select all

        --TODO call punch instead of manually setting health for player too
        if target:is_player() then
            local target_health = target:get_hp()

            --do damage
            target:set_hp(target_health -damage_done)
        else
--Jonathan added
            local target_health = target:get_hp()
            target:set_hp(target_health -damage_done)
            if target:get_hp() <= 0 then
                target:remove()
            end

--Jonathan commented out
--            target:punch(entity.object, 1.0, {
--                            full_punch_interval=1.0,
--                            groupcaps={
--                                fleshy={times={    [1]=1/(damage_done-2), 
--                                                [2]=1/(damage_done-1), 
--                                                [3]=1/damage_done}},
--                                snappy={times={    [1]=1/(damage_done-2), 
--                                                [2]=1/(damage_done-1), 
--                                                [3]=1/damage_done}},
--                            }
--                        }, nil)
        end

In the mobf fighting.lua line 928 remove "+1" added to mob_pos.y+dir.y:

Code: Select all

y=mob_pos.y+dir.y,

In the mobf weapons.lua around line 395:

Code: Select all

    if self.timer>0.2 then
--Jonathan changed radius area from 2 to 1.
        local objs = minetest.env:get_objects_inside_radius({x=pos.x,y=pos.y,z=pos.z}, 1)
        for k, obj in pairs(objs) do
            if obj:get_luaentity() ~= nil and
                obj ~= self.owner then
                if obj:get_luaentity().name ~= "mobf:arrow_entity" and 
                    obj:get_luaentity().name ~= "__builtin:item" then
--Jonathan added
                    local target_health = obj:get_hp()
                    obj:set_hp(target_health -self.damage)
                    if obj:get_hp() <= 0 then
                        obj:remove()
                    end
--Jonathan commented out
--                    obj:punch(self.object, 1.0, {
--                        full_punch_interval=1.0,
--                        groupcaps={
--                            fleshy={times={    [1]=1/(self.damage-2), 
--                                            [2]=1/(self.damage-1), 
--                                            [3]=1/self.damage}},
--                            snappy={times={    [1]=1/(self.damage-2), 
--                                            [2]=1/(self.damage-1), 
--                                            [3]=1/self.damage}},
--                        }
--                    }, nil)
                    self.object:remove()
                end
            else
--Jonathan added
                local target_health = obj:get_hp()
                obj:set_hp(target_health -self.damage)
                if obj:get_hp() <= 0 then
                    obj:remove()
                end

--Jonathan commented out
                --punch a player
--                obj:punch(self.object, 1.0, {
--                    full_punch_interval=1.0,
--                    groupcaps={
--                        fleshy={times={    [1]=1/(self.damage-2), 
--                                        [2]=1/(self.damage-1), 
--                                        [3]=1/self.damage}},
--                        snappy={times={    [1]=1/(self.damage-2), 
--                                        [2]=1/(self.damage-1), 
--                                        [3]=1/self.damage}},
--                    }
--                }, nil)
                self.object:remove()
            end
        end
    end

Some of the changes I made were to improve the arrows some. the arrow originally could always hurt you behind a wall if you were directly beside it. Now it only can hurt you behind the wall sometimes (due to going through the wall/ceiling corner!):P. It also makes it to where the arrow has to more directly hit you.

FYI: my code is very possibly not the most efficient, and I don't understand the punch function or armor groups very well. You might want to adjust the health of the archer and guard as well.

Note: Before I made some of the changes, arrows did not even hurt me (version minetest-0.4.6-1f42479-bugfixes-win32). Also, before I made some of the changes, one player's soldiers could not hurt another player's soldiers.

[deivan]

Nice. I will test it ASAP.
-*-
I don't found the "mob_archer:archer" or the other one in my sources, have another version fo this mod?

[Jonathan]

Nice. I will test it ASAP.
-*-
I don't found the "mob_archer:archer" or the other one in my sources, have another version fo this mod?

I used the version 2.0.82 from the first post:

Prerelease Download
Primary : Version 2.0.82 - finding a way out

Hope you enjoy it

[deivan]

I found. Thanks.

[sapier]

@Jonathan thanks for your contributions. I think I've fixed the damage issues for 2.0.83 ... I don't wonder you didn't understand the damage system it's quite strange I had to debug c++ code to understand how this works now too.

I'll add a configurable trader inventory to 2.2, I'm sorry but for 2.1 it's to late to add a feature like that, as I need to write a gui to add this in a conveniant way.

I don't quite understand what you want to achieve by removing the +1 in fighting.lua? It's quite some time since I wrote that but I believe to remember this was required to get a clear target. Am I wrong with this assumption?

[Jonathan]

Well if I remember right, I removed the "+1" so the arrow would still be able to hit the player after changing line 396 in weapons.lua

Weapons.lua line 396:
From:

Code: Select all

local objs = minetest.env:get_objects_inside_radius({x=pos.x,y=pos.y,z=pos.z}, 2)

To:

Code: Select all

local objs = minetest.env:get_objects_inside_radius({x=pos.x,y=pos.y,z=pos.z}, 1)

I changed the radius value from 2 to 1 so the arrow had to hit the player more accurately in order to hurt him. Also, with a radius of 2 it was easier for it to hurt a player behind a wall. (Although there might have been a better way to accomplish this)

Thanks for your work on this mod. I really enjoy it. I also like all your work you have been doing on pathfinding. It would be awesome to have creatures that can use path-finding efficiently, and that could open wood doors!

[sapier]

Hmm maybe 1.5 is a good value to use ... I'll have a try.

I've just updated download link for 2.0.83, main enhancements:
-Updated trader inventory
-hirelings can be rotated by punching them
-naked sheeps get wool again
-mobf_settings is working for non admin players (at least those parts they should be able to use)
-damage should work now as expected plz have a try!
-many other small fixes, see changelog or github commit list