[Mod] Trash Can [0.2.3] [trash_can]

User avatar
Linuxdirk
Member
Posts: 3218
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: [Mod] Trash Can [github] [trash_can]

by Linuxdirk » Post

Evergreen wrote:But how is one supposed to throw items in it if it were that size? :P
Good aim :D

Throwing items in seems not to work anyway with Carbone :)

User avatar
Evergreen
Member
Posts: 2135
Joined: Sun Jan 06, 2013 01:22
GitHub: 4Evergreen4
IRC: EvergreenTree
In-game: Evergreen
Location: A forest in the midwest
Contact:

Re: [Mod] Trash Can [github] [trash_can]

by Evergreen » Post

Linuxdirk wrote:
Evergreen wrote:But how is one supposed to throw items in it if it were that size? :P
Good aim :D

Throwing items in seems not to work anyway with Carbone :)
That's true. It doesn't work correctly sometimes, and I'm not sure why.
Back from the dead!

User avatar
Evergreen
Member
Posts: 2135
Joined: Sun Jan 06, 2013 01:22
GitHub: 4Evergreen4
IRC: EvergreenTree
In-game: Evergreen
Location: A forest in the midwest
Contact:

Re: [Mod] Trash Can [0.2] [trash_can]

by Evergreen » Post

Update:
  • New dumpster nodebox and textures. The nodebox is now only 2x1x1 in size.
  • Fixed the issue of the dumpster merging into nodes when placed. (won't fix existing dumpsters)
  • Added screenshot.png and description.txt
  • Make items thrown into trash can simply add themselves to the inventory of the trash can instead of removing themselves. If the trash can is full, the item(s) will not be added. If the trash can is almost full and more than enough item(s) are dropped, the trash can will take what it can and leave the left over item(s).
Note that this mod has been migrated to the minetest-mods github group. Please use the new repo instead,
Back from the dead!

User avatar
jp
Banned
Posts: 947
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: [Mod] Trash Can [0.2.1] [trash_can]

by jp » Post

There's a weird thing in your code : https://github.com/minetest-mods/trash_ ... #L122-L124

You can get rid of the loop and use inv:set_list("trashlist", {}) for emptying efficiently your list.

User avatar
Evergreen
Member
Posts: 2135
Joined: Sun Jan 06, 2013 01:22
GitHub: 4Evergreen4
IRC: EvergreenTree
In-game: Evergreen
Location: A forest in the midwest
Contact:

Re: [Mod] Trash Can [0.2.1] [trash_can]

by Evergreen » Post

@jp I noticed that but didn't have time to fix it. Thanks for bringing it to my attention.

EDIT:
Fixed.
Back from the dead!

Sokomine
Member
Posts: 4276
Joined: Sun Sep 09, 2012 17:31
GitHub: Sokomine
IRC: Sokomine
In-game: Sokomine

Re: [Mod] Trash Can [0.2.2] [trash_can]

by Sokomine » Post

Evergreen wrote: Make items thrown into trash can simply add themselves to the inventory of the trash can instead of removing themselves. If the trash can is full, the item(s) will not be added. If the trash can is almost full and more than enough item(s) are dropped, the trash can will take what it can and leave the left over item(s).
Nice feature. Could be entertaining for normal 3d chests as well.
A list of my mods can be found here.

User avatar
lightonflux
Member
Posts: 384
Joined: Mon Nov 11, 2013 07:22
In-game: lof
Location: Germany

Re: [Mod] Trash Can [0.2] [trash_can]

by lightonflux » Post

Evergreen wrote:Update:

Note that this mod has been migrated to the minetest-mods github group. Please use the new repo instead,

Can you link it? If you search for it you find many repos.

Is it this group: https://github.com/minetest-mods ? And this repo: https://github.com/minetest-mods/trash_can

User avatar
Evergreen
Member
Posts: 2135
Joined: Sun Jan 06, 2013 01:22
GitHub: 4Evergreen4
IRC: EvergreenTree
In-game: Evergreen
Location: A forest in the midwest
Contact:

Re: [Mod] Trash Can [0.2] [trash_can]

by Evergreen » Post

lightonflux wrote:
Evergreen wrote:Update:

Note that this mod has been migrated to the minetest-mods github group. Please use the new repo instead,

Can you link it? If you search for it you find many repos.

Is it this group: https://github.com/minetest-mods ? And this repo: https://github.com/minetest-mods/trash_can
I updated the links in the main post already, so use those.
Back from the dead!

User avatar
TailsTheFoxDoes MT
Member
Posts: 415
Joined: Mon Jan 18, 2016 20:50
In-game: TailsTheFox
Location: Mobius

Re: [Mod] Trash Can [0.2.2] [trash_can]

by TailsTheFoxDoes MT » Post

Uh, this mod and my mob_pack would have a bad time. Because
C:\Minetest\mods\mob_pack\trash_can
C:\Minetest\mods\trash_can
I'm the TailsTMM of minetest, in other words, i rock.
BRAAAAAZZZZAAAA!!!!!!!!!!!!!!!!!!!!!!!!!!!
BTW it means TailsTheMeseMinecart, but that isn't my name, it's just a way of saying that i basically do the same thing Dantdm does but i do it with minetest And you problably can't see the invisible ink.
My mods:
My first mod:tails_boss

Mob_pack now has voice acting! Do you want YOUR VOICE included? Look in my posts for the thread!

KCoombes
Member
Posts: 427
Joined: Thu Jun 11, 2015 23:19
In-game: Knatt
Location: SW Florida, USA

Re: [Mod] Trash Can [0.2.2] [trash_can]

by KCoombes » Post

TailsTheFoxDoes MT wrote:Uh, this mod and my mob_pack would have a bad time. Because
C:\Minetest\mods\mob_pack\trash_can
C:\Minetest\mods\trash_can
Nope, two totally different mod names - one is mob_pack, the other is trash_can.

User avatar
TailsTheFoxDoes MT
Member
Posts: 415
Joined: Mon Jan 18, 2016 20:50
In-game: TailsTheFox
Location: Mobius

Re: [Mod] Trash Can [0.2.2] [trash_can]

by TailsTheFoxDoes MT » Post

KCoombes wrote:
TailsTheFoxDoes MT wrote:Uh, this mod and my mob_pack would have a bad time. Because
C:\Minetest\mods\mob_pack\trash_can
C:\Minetest\mods\trash_can
Nope, two totally different mod names - one is mob_pack, the other is trash_can.
mob_pack is a MODPACK so any of it's contents can do that.
I'm the TailsTMM of minetest, in other words, i rock.
BRAAAAAZZZZAAAA!!!!!!!!!!!!!!!!!!!!!!!!!!!
BTW it means TailsTheMeseMinecart, but that isn't my name, it's just a way of saying that i basically do the same thing Dantdm does but i do it with minetest And you problably can't see the invisible ink.
My mods:
My first mod:tails_boss

Mob_pack now has voice acting! Do you want YOUR VOICE included? Look in my posts for the thread!

KCoombes
Member
Posts: 427
Joined: Thu Jun 11, 2015 23:19
In-game: Knatt
Location: SW Florida, USA

Re: [Mod] Trash Can [0.2.2] [trash_can]

by KCoombes » Post

My bad - didn't realize yours was a modpack

User avatar
TailsTheFoxDoes MT
Member
Posts: 415
Joined: Mon Jan 18, 2016 20:50
In-game: TailsTheFox
Location: Mobius

Re: [Mod] Trash Can [0.2.2] [trash_can]

by TailsTheFoxDoes MT » Post

KCoombes wrote:My bad - didn't realize yours was a modpack
It's fine.
I'm the TailsTMM of minetest, in other words, i rock.
BRAAAAAZZZZAAAA!!!!!!!!!!!!!!!!!!!!!!!!!!!
BTW it means TailsTheMeseMinecart, but that isn't my name, it's just a way of saying that i basically do the same thing Dantdm does but i do it with minetest And you problably can't see the invisible ink.
My mods:
My first mod:tails_boss

Mob_pack now has voice acting! Do you want YOUR VOICE included? Look in my posts for the thread!

minerdudetest
Member
Posts: 38
Joined: Mon Jul 02, 2018 17:16

Re: [Mod] Trash Can [0.2.2] [trash_can]

by minerdudetest » Post

@Evergreen Hello! I have enhanced this mod (ver. 0.2.2) with ability to run under MineClone2 game. You are very welcome to pull the changes into your master! Details. Thank you!

User avatar
Blockhead
Member
Posts: 1623
Joined: Wed Jul 17, 2019 10:14
GitHub: Montandalar
IRC: Blockhead256
In-game: Blockhead Blockhead256
Location: Land Down Under
Contact:

Re: [Mod] Trash Can [github] [trash_can]

by Blockhead » Post

Evergreen wrote:
Fri Nov 14, 2014 16:20
Linuxdirk wrote:
Evergreen wrote:But how is one supposed to throw items in it if it were that size? :P
Good aim :D

Throwing items in seems not to work anyway with Carbone :)
That's true. It doesn't work correctly sometimes, and I'm not sure why.
There were some issues with newer versions of Minetest. Also, the settingtypes.txtdefinition was opposite to what the code actually did. I've revised the throwing-in functionality and put it in a pull request.
/˳˳_˳˳]_[˳˳_˳˳]_[˳˳_˳˳\ Advtrains enthusiast | My map: Noah's Railyard | My Content on ContentDB ✝️♂

Post Reply

Who is online

Users browsing this forum: No registered users and 16 guests