[Mod] 3d visible wielded items [0.4.0] [wield3d]

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

Got this error today:

15:30:56: ERROR[main]: ERROR: An unhandled exception occurred: ServerError: LuaError: error: ...test/.minetest/games/vanessae_game/mods/wield3d/init.lua:65: calling 'add_entity' on bad self (table expected, got nil)
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

VanessaE wrote:Got this error today:

15:30:56: ERROR[main]: ERROR: An unhandled exception occurred: ServerError: LuaError: error: ...test/.minetest/games/vanessae_game/mods/wield3d/init.lua:65: calling 'add_entity' on bad self (table expected, got nil)
I have no idea why that can be, afaik minetest.env has not been removed yet although I should update this sometime soon.
My only guess is that it is in some way related to that damned entity dupe bug.

Sorry that I am unable to help.

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

In the meantime, I've had to remove this mod from my servers to prevent the crash. :-(

Possibly related: I still occasionally see my or someone else's wield item not attached to their hand, but rather attached to where that player spawned. E.g. if I'm holding a pick when I sign on, sometimes I will see a copy of that pick "embedded" into the ground where I spawned at.
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

VanessaE wrote:In the meantime, I've had to remove this mod from my servers to prevent the crash. :-(

Possibly related: I still occasionally see my or someone else's wield item not attached to their hand, but rather attached to where that player spawned. E.g. if I'm holding a pick when I sign on, sometimes I will see a copy of that pick "embedded" into the ground where I spawned at.
I will make some updates to this mod and at least see if I can make it fail more gracefully. The other problem you mention is alomst certainly related to the entity bug, the mod itself is really quite simple. The magic (as it were) is all in the model.

In the meantime you could try using the current-git version of wieldview, though it doesn't look quite as good as wield3d, it does now have a 3d look and unlike the old version, supports any texture resolution.

Edit: Of course you would lose the split-limb effect character model using wieldview.
Last edited by stu on Wed Oct 02, 2013 21:01, edited 1 time in total.

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

Update, I just made a small commit that should hopefully prevent the crash. If you get a lot of logged attachment errors then you will need to increase the attachment delay time. I shall make this more easily configurable in a future update.

User avatar
jojoa1997
Member
Posts: 2890
Joined: Thu Dec 13, 2012 05:11
Location: Earth

by jojoa1997 » Post

VanessaE wrote:In the meantime, I've had to remove this mod from my servers to prevent the crash. :-(

Possibly related: I still occasionally see my or someone else's wield item not attached to their hand, but rather attached to where that player spawned. E.g. if I'm holding a pick when I sign on, sometimes I will see a copy of that pick "embedded" into the ground where I spawned at.
Also when the item in your hand changes the entity changes
Coding;
1X coding
3X debugging
12X tweaking to be just right

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

Ok, I've updated and re-installed it.
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
Ikishida
Member
Posts: 107
Joined: Sat Aug 17, 2013 08:02
Location: (secret)

by Ikishida » Post

again,how can you see yourself?
When life hands you lemons,throw it back at life saying "I don't need your goddamn lemons!" =D

User avatar
Topywo
Member
Posts: 1721
Joined: Fri May 18, 2012 20:27

by Topywo » Post

Ikishida wrote:again,how can you see yourself?
Starting an extra game:
viewtopic.php?pid=114636#p114636

or

Using this mod:
viewtopic.php?id=7283

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

Mod Updated, version 0.2.0

Pretty much a complete re-write that hopefully fixes the non-attachment issues that were reported by VanessaE.
Perhaps slightly less efficient code than before though it should now be much more robust.

Other changes include removing the wielded item bone from the model, wield entities now attach directly to the player armature.
This allows for custom bone positioning along with full 6d rotations.

VannesaE, If you are still interested, I have also updated the split-limb version of the model.

split_limb.zip
Last edited by stu on Wed Nov 06, 2013 21:40, edited 1 time in total.

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

This update (with the split limb zip you linked to) crashes the server as soon as a player joins.

Backtrace, thanks to an engine patch by ShadowNinja:

19:49:20: ERROR[main]: ServerError: LuaError: /usr/local/share/minetest/builtin/vector.lua:5: Invalid vector
19:49:20: ERROR[main]: stack traceback:
19:49:20: ERROR[main]: [C]: in function 'assert'
19:49:20: ERROR[main]: /usr/local/share/minetest/builtin/vector.lua:5: in function 'assert_vector'
19:49:20: ERROR[main]: /usr/local/share/minetest/builtin/vector.lua:20: in function 'equals'
19:49:20: ERROR[main]: ...essa/.minetest/games/vanessae_game/mods/wield3d/init.lua:67: in function <...essa/.minetest/games/vanessae_game/mods/wield3d/init.lua:47>
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

Meanwhile, you should put the split limb code on github also, or add it to your wield3d mod in such a way that the server admin can simply set a config option somewhere to select the right model.
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

VanessaE wrote:This update (with the split limb zip you linked to) crashes the server as soon as a player joins.

Backtrace, thanks to an engine patch by ShadowNinja:

19:49:20: ERROR[main]: ServerError: LuaError: /usr/local/share/minetest/builtin/vector.lua:5: Invalid vector
19:49:20: ERROR[main]: stack traceback:
19:49:20: ERROR[main]: [C]: in function 'assert'
19:49:20: ERROR[main]: /usr/local/share/minetest/builtin/vector.lua:5: in function 'assert_vector'
19:49:20: ERROR[main]: /usr/local/share/minetest/builtin/vector.lua:20: in function 'equals'
19:49:20: ERROR[main]: ...essa/.minetest/games/vanessae_game/mods/wield3d/init.lua:67: in function <...essa/.minetest/games/vanessae_game/mods/wield3d/init.lua:47>
That is very helpful, turned out I needed to update in order to reproduce that. The problem was my bad but would have gone un-noticed before the recent(ish) changes to builtin/vector.lua. Bug is now fixed.
VanessaE wrote:Meanwhile, you should put the split limb code on github also, or add it to your wield3d mod in such a way that the server admin can simply set a config option somewhere to select the right model.
I don't like the idea of including unnecessary character.x models due to their filesize, additionally I have realized that the bone attachment and positioning also require modification to get the best out of the split-limb model.

Instead I have created a split-limb branch on github with all the necessary changes made. I may regret this someday if I have to make further updates, it just seemed like the easiest way to go for now.

Thank you once again for all your support with this Vanessa.

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

Glad I could help :-)
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

That attempt to position the items differently for the split model does not work quite right. Um, oops? :-)

http://digitalaudioconcepts.com/vanessa ... s/oops.png
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

VanessaE wrote:That attempt to position the items differently for the split model does not work quite right. Um, oops? :-)
oops indeed! :D

Should be fixed now, it was just a typo in the default bone name.

Sorry, I should have retested it before pushing.

User avatar
VanessaE
Moderator
Posts: 4510
Joined: Sun Apr 01, 2012 12:38
GitHub: VanessaE
IRC: VanessaE
In-game: VanessaE
Location: Western NC
Contact:

by VanessaE » Post

Much better :)
You might like some of my stuff: Plantlife ~ More Trees ~ Home Decor ~ Pipeworks ~ HDX Textures (64-512px)

User avatar
TenPlus1
Member
Posts: 2727
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

by TenPlus1 » Post

Great mod, should be included in MineTest itself :)

User avatar
jojoa1997
Member
Posts: 2890
Joined: Thu Dec 13, 2012 05:11
Location: Earth

by jojoa1997 » Post

TenPlus1 wrote:Great mod, should be included in MineTest itself :)
I say no because some other mods are incompatible and iirc this changes the player model.
Coding;
1X coding
3X debugging
12X tweaking to be just right

User avatar
Dopium
Member
Posts: 233
Joined: Sat Jun 09, 2012 15:43
Location: Australia

by Dopium » Post

Personally i think it would make Minetest that little bit more complete, would be a nice feature if all mods were compatible.
Running @1.19 MHz, 128 bytes of RAM and interchangeable 4kb ROM carts!

User avatar
jojoa1997
Member
Posts: 2890
Joined: Thu Dec 13, 2012 05:11
Location: Earth

by jojoa1997 » Post

Does this change the player model?
Coding;
1X coding
3X debugging
12X tweaking to be just right

User avatar
Evergreen
Member
Posts: 2135
Joined: Sun Jan 06, 2013 01:22
GitHub: 4Evergreen4
IRC: EvergreenTree
In-game: Evergreen
Location: A forest in the midwest
Contact:

by Evergreen » Post

jojoa1997 wrote:Does this change the player model?
Simply put, yes. It is not ready for default yet in its current state.
Back from the dead!

User avatar
Inocudom
Member
Posts: 3085
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

by Inocudom » Post

It's interesting to note that the player model with bending ankles and elbows is the default player model in Minetest Classic.
You can now find my videos at BitChute: https://www.bitchute.com/channel/some_cheeky_jinuskian/

User avatar
Johnyknowhow
Member
Posts: 358
Joined: Fri Sep 21, 2012 15:17
In-game: Minetestian
Location: Washington, USA

by Johnyknowhow » Post

I see, it is very glitchy, when I was playing with my bro he had a mese pickaxe, then he held dirt, and the item NEVER changed
I lost interest in Minetest for a couple of years and... I am still not really paying much attention. I rarely browse these forums anymore but it's nice to see old faces.

obligatory fancy signature goes here

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

by stu » Post

Johnyknowhow wrote:I see, it is very glitchy, when I was playing with my bro he had a mese pickaxe, then he held dirt, and the item NEVER changed
There is a deliberate delay (default 2 seconds) between checks for wielded item updates. That, copuled with gerneral server
latency is (most likely) the cause. I admit that it may seem a bit stange if you are playiing side-by-side.

However, if the wielded item is never changing then there is clearly a problem somewhere.

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests