[Mod] Fishing! - Mossmanikin's version [0.2.2] [fishing]

[Neuromancer]

MM, you need to check out this exciting news: Sapier has added some support for your mod. Maybe further integration is possible!
viewtopic.php?pid=113172#p113172

[Mossmanikin]

MM, you need to check out this exciting news: Sapier has added some support for your mod. Maybe further integration is possible!
viewtopic.php?pid=113172#p113172

Yeah, just read it.

[Mossmanikin]

Update (0.2.1)

New water lilies and seaweed (plantlife) can be caught when they share
the same space with the bobber.
A chance to catch a blue white fish (mobf) when it's near to the bobber.

[Mossmanikin]

Small update (0.2.2)

Twigs (undergrowth) can be caught.
Updated support for sea modpack.

[Topywo]

Small update (0.2.2)

Twigs (undergrowth) can be caught.
Updated support for sea modpack.

Great :-)


P.s. Digging seaplants:kelpgreenmiddle drops a seaplants:kelpgreen, so the 3rd sushi crafting recipe could be left out.

[Mossmanikin]

P.s. Digging seaplants:kelpgreenmiddle drops a seaplants:kelpgreen, so the 3rd sushi crafting recipe could be left out.

Thanks for info. Must've overseen that. Will change it.

[falsegrayburger]

I want to add a Mob of small fish in this alone

[Mossmanikin]

I want to add a Mob of small fish in this alone

I thought about that too. If you want to do it, feel free.
Otherwise I'll put it on the long(!) to-do-list.

[nvrsbr]

How do you fish?
Do you need worms?
I cannot seem to cast the rod?

[nvrsbr]

How do you fish?
Do you need worms?
I cannot seem to cast the rod?

Anyone?

[lightonflux]

To fish, just punch water with the fishing rod. Yes, you need to equip the rod with a worm to catch a fish. Not every punch catches a fish. I think the probability is between 20 and 25%.

[nvrsbr]

To fish, just punch water with the fishing rod. Yes, you need to equip the rod with a worm to catch a fish. Not every punch catches a fish. I think the probability is between 20 and 25%.

Thanks, it has been driving me nuts haha.

[Sane]

Hi there,

I'm trying your mod. It seems that there are some unidentified items in the crafting receipes.
I've changed crafting.lua and trophies.lua so that receipes aren't registered who's dependencies aren't met.

crafting.lua:

Code: Select all

-----------------------------------------------------------------------------------------------
-- Fishing - Mossmanikin's version - Recipes 0.0.8
-----------------------------------------------------------------------------------------------
-- License (code & textures): 	WTFPL
-- Contains code from: 		animal_clownfish, animal_fish_blue_white, fishing (original), stoneage
-- Looked at code from:
-- Dependencies: 			default, farming
-- Supports:				animal_clownfish, animal_fish_blue_white, animal_rat, mobs
-----------------------------------------------------------------------------------------------

local hasMoreblocks = minetest.get_modpath("moreblocks") ~= nil
local hasRopes = minetest.get_modpath("ropes") ~= nil
local hasFlowers = minetest.get_modpath("flowers_plus") ~= nil
local hasSeaplants = minetest.get_modpath("seaplants") ~= nil

-----------------------------------------------------------------------------------------------
-- Fishing Pole
-----------------------------------------------------------------------------------------------
-- mc style
minetest.register_craft({
	output = "fishing:pole",
	recipe = { 
		{"", 				"",					"default:stick"	},
		{"", 				"default:stick",	"farming:string"},
		{"default:stick",	"",					"farming:string"},
	}
})

if (hasMoreblocks) then
	minetest.register_craft({
		output = "fishing:pole",
		recipe = { 
			{"", 				"",					"default:stick"  },
			{"", 				"default:stick",	"moreblocks:rope"},
			{"default:stick",	"",					"moreblocks:rope"},
		}
	})
end

if (hasRopes) then
	minetest.register_craft({
		output = "fishing:pole",
		recipe = { 
			{"", 				"",					"default:stick"	},
			{"", 				"default:stick",	"ropes:rope"   	},
			{"default:stick",	"",					"ropes:rope"   	},
		}
	})
end


-----------------------------------------------------------------------------------------------
-- Roasted Fish
-----------------------------------------------------------------------------------------------
minetest.register_craft({
	type = "cooking",
	output = "fishing:fish",
	recipe = "fishing:fish_raw",
	cooktime = 2,
})

-----------------------------------------------------------------------------------------------
-- Wheat Seed
-----------------------------------------------------------------------------------------------
minetest.register_craft({
	type = "shapeless",
	output = "farming:seed_wheat",
	recipe = {"farming:wheat"},
})
-----------------------------------------------------------------------------------------------
-- Sushi
-----------------------------------------------------------------------------------------------
if (hasFlowers) then
	minetest.register_craft({
		type = "shapeless",
		output = "fishing:sushi",
		recipe = {"fishing:fish_raw","farming:seed_wheat","flowers:seaweed"},
	})
end

if (hasSeaplants) then
	minetest.register_craft({
		type = "shapeless",
		output = "fishing:sushi",
		recipe = {"fishing:fish_raw","farming:seed_wheat","seaplants:kelpgreen"},
			
	})
end

-----------------------------------------------------------------------------------------------
-- Roasted Shark
-----------------------------------------------------------------------------------------------
minetest.register_craft({
	type = "cooking",
	output = "fishing:shark_cooked",
	recipe = "fishing:shark",
	cooktime = 2,
})

-----------------------------------------------------------------------------------------------
-- Roasted Pike
-----------------------------------------------------------------------------------------------
minetest.register_craft({
	type = "cooking",
	output = "fishing:pike_cooked",
	recipe = "fishing:pike",
	cooktime = 2,
})

trophies.lua:

Code: Select all

-----------------------------------------------------------------------------------------------
-- Fishing - Mossmanikin's version - Trophies 0.0.2
-- License (code & textures): 	WTFPL
-- Contains code from: 		default
-- Supports:				animal_clownfish, animal_fish_blue_white
-----------------------------------------------------------------------------------------------

local TRoPHY = {
--	  MoD						 iTeM				 NaMe				iCoN
    {"fishing",  				"fish_raw",			"Fish",				"fishing_fish.png"},
	{"fishing",  				"pike",				"Northern Pike",	"fishing_pike.png"},
	{"fishing",  				"shark",			"Shark",			"fishing_shark.png"},
	{"animal_clownfish",		"clownfish",		"Clownfish",		"animal_clownfish_clownfish_item.png"},
	{"animal_fish_blue_white",	"fish_blue_white",	"Blue white fish",	"animal_fish_blue_white_fish_blue_white_item.png"},
}

local function has_trophy_privilege(meta, player)
	if player:get_player_name() ~= meta:get_string("owner") then
		return false
	end
	return true
end

for i in pairs(TRoPHY) do
	local 	MoD = 			TRoPHY[i][1]
	local 	iTeM = 			TRoPHY[i][2]
	local 	NaMe = 			TRoPHY[i][3]
	local 	iCoN = 			TRoPHY[i][4]
	
	if (minetest.get_modpath(MoD) ~= nil) then
		minetest.register_node("fishing:trophy_"..iTeM, {
			description = NaMe.." Trophy",
			inventory_image = "default_chest_top.png^"..iCoN.."^fishing_trophy_label.png",
			drawtype = "nodebox",
			tiles = {
				"default_chest_top.png", -- top
				"default_chest_top.png", -- bottom
				"default_chest_top.png", -- right
				"default_chest_top.png", -- left
				"default_chest_top.png", -- back
				"default_chest_top.png^"..iCoN.."^fishing_trophy_label.png", -- front
			},
			paramtype = "light",
			paramtype2 = "facedir",
			walkable = false,
			node_box = {
				type = "fixed",
				fixed = {
				--	{ left	, bottom , front  ,  right ,  top   ,  back  }
					{ -1/2  , -1/2   ,  7/16  , 1/2    ,  1/2   ,  1/2  },
				}
			},
			selection_box = {
				type = "fixed",
				fixed = {
					{ -1/2  , -1/2   ,  7/16  , 1/2    ,  1/2   ,  1/2  },
			}
			},
			groups = {choppy=2,oddly_breakable_by_hand=3,flammable=2},
			sounds = default.node_sound_wood_defaults(),
			after_place_node = function(pos, placer)
				local meta = minetest.get_meta(pos)
				meta:set_string("owner", placer:get_player_name() or "")
				meta:set_string("infotext", "This Huge "..NaMe.." was caught by the Famous Angler "..
					meta:get_string("owner").."!")
			end,
			on_construct = function(pos)
				local meta = minetest.get_meta(pos)
				meta:set_string("infotext", NaMe)
				meta:set_string("owner", "")
			end,
			can_dig = function(pos,player)
				local meta = minetest.get_meta(pos);
				return has_trophy_privilege(meta, player)
			end,
		})
		
		minetest.register_craft({
			type = "shapeless",
			output = "fishing:trophy_"..iTeM,
			recipe = {MoD..":"..iTeM, "default:sign_wall"},
		})
	end
	
end

[maikerumine]

Fishing does not work on multiplayer server, o0nly when one person is present, possible fix?

Thank you in advance!

[ExeterDad]

Fishing does not work on multiplayer server, o0nly when one person is present, possible fix?

Thank you in advance!

Aha! That's why I've never gotten fishing to work on our server! I was losing my mind.

[Napiophelios]

Fishing does not work on multiplayer server, o0nly when one person is present, possible fix?

Thank you in advance!

Aha! That's why I've never gotten fishing to work on our server! I was losing my mind.

It probably works fine, fishies just dont like crowds thats all. :P

[The_Critic]

Great mod Mossmanikin!But I would like to bring to your attention that for some reason the mod does not function quite right in multiplayer.You see, in multiplayer on minetest 0.4.13 (or at least mine) you hear the bobber hit the water , but you don`t see it.Please look into that if you get the time.(And yes I do cast the line close enough to the shore

[christoferlevich]

Are there server commands for FISHING or is it all through the gui?

[TumeniNodes]

mossmanikin has not been around in some time.
this mod could prob use some love to be updated, or sadly sent off to old mods

[christoferlevich]

Ok - help me understand something about terminology here. Lets say I go and work on this MOD - is that a 'branch' of the original or is it a new mod (trying to understand the lingo). :)

[TumeniNodes]

You fork the mod, and add your changes to it. So it is called a "fork"
You can create separate branches of your own fork to make changes, and then submit PR's from those to your own main repo for the mod (as well as sending PR's to the original mod which you forked from)
This way, you can merge it as squashed so 20 changes can be merged as one. (keeps things neater over time)

I am unsure if there will be a response from mossmanikin but, you could re-release the mod with your changes, just follow the license/requests of the original mod author.
If you re-release the mod, give the name something extra so it does not have the same exact name.
Which means each registered node, and textures from your mod should not match the names of the original.

i.e. (original) fishing:fishing_pole
(new) fishing2:fishing_pole

Did I make that confusing enough? :P

[christoferlevich]

Actually, I think I'm getting it. Thank you for the insight! I am a slow learner. Started last August (2016) with MT and I have learned a lot through trial and error but now I want to start filling in the gaps. :)