Page 1 of 1

[Mod] Player notes [player_notes]

Posted: Wed Apr 09, 2014 09:53
by Krock
Add a note to a player!
Image

This is why I created this mod.

It allows everybody with the "player_notes" privilege to write comments/messages/notices about a specific player.
Every note gets a random key from 100 to 999.
There can be multiple keys with the same number, just on diffrent players.

Commands:
/notes Shows up notes GUI

Optional settings: (in "init.lua")
Enable/disable timestamps
Define minimal and maximal number of keys.

Privilege required: player_notes (Added by mod)
Depends: nothing
License: WTFPL
Download: Master *.zip, View source

Posted: Wed Apr 09, 2014 17:29
by CraigyDavi
Nice mod!

Posted: Wed Apr 09, 2014 17:34
by Achilles
Nice... Easy way to keep track of of clients who repeatedly break server rules

+1

Posted: Thu Apr 10, 2014 19:18
by Achilles
Could the mod be adapted so that as soon as someone kills another it would appear on their notes screen?

Posted: Thu Apr 10, 2014 19:22
by Achilles
E.g say Achilles killed random_bot, then as soon as this happened something like 'Achilles at (10.05.2014 5:37:73) killed random_bot' would appear under the notes section for Achilles

Posted: Thu Apr 10, 2014 20:13
by Krock
Achilles wrote:Could the mod be adapted so that as soon as someone kills another it would appear on their notes screen?
Impossible.

Posted: Fri Apr 11, 2014 19:53
by Achilles
Krock wrote:
Achilles wrote:Could the mod be adapted so that as soon as someone kills another it would appear on their notes screen?
Impossible.
Ah OK... Just an idea

Posted: Sat Apr 12, 2014 15:34
by rommiekerova
Does this mod let the people see the notes on them or just the person with the priv who added it?

Is it possible for more than one player to see the notes or can anyone with the right priv see the notes? This would of course be useful for admins and mods on a server to keep track of people.

Posted: Sat Apr 12, 2014 16:52
by Krock
rommiekerova wrote:Does this mod let the people see the notes on them or just the person with the priv who added it?

Is it possible for more than one player to see the notes or can anyone with the right priv see the notes?
Only people with the "player_notes" privilege can add/remove and view the notes.
rommiekerova wrote:This would of course be useful for admins and mods on a server to keep track of people.
Yup. This mod is useful for teamwork under moderators.

Posted: Sat Apr 12, 2014 19:07
by rommiekerova
Awesome! This is definitely going to be added to my server.

Posted: Sat Apr 12, 2014 21:18
by rommiekerova
There is a serious problem with this mod. I added it and when it came to using /add_note, it said the note got added but suddenly the server announced it was shutting down.

There is nothing printed in debug to show why it is happening.

After rebooting the server I checked if the note had added and it hadn't.

Posted: Sun Apr 13, 2014 07:31
by Krock
Shame on me.

Posted: Sun Apr 13, 2014 07:45
by rommiekerova
There is absolutely nothing in the debug about the crashes or error.
I use windows XP.
Its easy to reproduce. Every time I type something like: /add_note rommie test note
it makes the server shut down.

/list_notes works fine but obviously returns the message stating the player has no notes.

Posted: Sun Apr 13, 2014 07:52
by Krock
rommiekerova wrote:/add_note rommie test note
Ah my bad.. a typo, it should be "_note" instead of "_node".
Fixed in new v3 (even if it's not worth to add a version number)

Posted: Sun Apr 13, 2014 07:58
by rommiekerova
So its local note = string.gsub(_node, "|", "/")
that causes the issue?

Changing it to _note
fixes it?

Posted: Sun Apr 13, 2014 08:00
by Krock
rommiekerova wrote:So its local note = string.gsub(_node, "|", "/")
that causes the issue?

Changing it to _note
fixes it?
Exactly.

Posted: Sun Apr 13, 2014 08:08
by rommiekerova
Awesome. Altered the right bit and tested it. Works fine now.

Re: [Mod] Player notes [v4] [player_notes]

Posted: Sun Apr 20, 2014 18:26
by Krock
New version with a GUI! (old chat commands are included in chatcommands.lua)

Image in the 1st post updated.
Download me!
Use the chatcommand "/notes" to see the GUI.

EDIT: fixed possible fails in the formspec, added "view-only" window.

Re: [Mod] Player notes [v4] [player_notes]

Posted: Mon Apr 21, 2014 05:17
by crazyginger72
nice, cheapie will love this one, he was asking for it at one time :)

and it will be going on my server

Re: [Mod] Player notes [v5] [player_notes]

Posted: Tue Apr 22, 2014 08:18
by 4aiman
Cool! Is it possible that the next version would have a combobox instead of simple edit field for username selection? You probably don't want to add notes on inexistent players..

Re: [Mod] Player notes [v5] [player_notes]

Posted: Tue Apr 22, 2014 18:59
by Krock
4aiman wrote:Cool! Is it possible that the next version would have a combobox instead of simple edit field for username selection? You probably don't want to add notes on inexistent players..
It'll throw errors if the user isn't registred on the server. It also should be possible to add note to an offline player, so is a textbox the best way at the moment.

Re: [Mod] Player notes [v5] [player_notes]

Posted: Wed Apr 23, 2014 08:12
by 4aiman
Either one of us is confused...

If you were able to make your mod to "throw errors if the user isn't registred on the server" then what's the problem of adding a note for some player who went off-line ATM?

Edit->combobox replacement won't cause any harm, but would save you from checking whether a player is on~ or off-line every time someone adds a note.

Re: [Mod] Player notes [v5] [player_notes]

Posted: Wed Apr 23, 2014 11:36
by Krock
4aiman wrote:Either one of us is confused...
<snip>
It does not matter if a player is online or offline when you want to add a note about him.

Re: [Mod] Player notes [player_notes]

Posted: Wed Jan 06, 2016 16:44
by rubenwardy
Would it be possible to add xban2 support? So notes are shared between different usernames.

Re: [Mod] Player notes [player_notes]

Posted: Sun Jan 10, 2016 09:39
by Krock
Yes, it's possible to add new notes with some code changes.
The main problem there is the deletion: What if the player gets unbanned? Should it delete the note or create a new one about "Unbanned by <player>"?