[Mod] Protector Redo [3.4] [protector]

sangeet
Member
Posts: 49
Joined: Sat Feb 13, 2021 12:15

Re: [Mod] Protector Redo [3.2] [protector]

by sangeet » Post

TenPlus1 wrote:
Tue Jul 06, 2021 17:53
Stamina mod has it's own sprint included so hbsprint is not required, and as for the issue at hand, it seems that something is checking for minetest.is_protected() for Moon_X but in a totally different area which is owned by PC007 so you have a rogue mod somewhere.
ok, thank you for your info! i will keep on looking.

sangeet
Member
Posts: 49
Joined: Sat Feb 13, 2021 12:15

Re: [Mod] Protector Redo [3.2] [protector]

by sangeet » Post

i was thinking about some rogue mod myself, but this happens to only two players out of around 100, so i decided to ask your opinion on this subject first.

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Protector Redo [3.2] [protector]

by TenPlus1 » Post

It could be a machine that's been added that somehow works in the background for a particular player.

sangeet
Member
Posts: 49
Joined: Sat Feb 13, 2021 12:15

Re: [Mod] Protector Redo [3.2] [protector]

by sangeet » Post

oh... that is a very good idea! thanks again!

User avatar
Festus1965
Member
Posts: 4181
Joined: Sun Jan 03, 2016 11:58
GitHub: Festus1965
In-game: Festus1965 Thomas Thailand Explorer
Location: Thailand ChiangMai
Contact:

Re: [Mod] Protector Redo [3.2] [protector]

by Festus1965 » Post

sangeet wrote:
Tue Jul 06, 2021 17:27
i have quite a few. most of them have been around for some time. the only thing i added prior to this bug is dmobs from your repository.
mhh, test the same thing under original 5.4.1 or 5.2.0 MineTest server, then you might know the answer and solution.

mods are basically written for minetest, and the coders have already problems to fit there mods to the now basic changing minetest versions to be working,
I am sure they are most not intent to fix to every fork also
Human has no future (climate change)
If urgend, you find me in Roblox (as CNXThomas)

sangeet
Member
Posts: 49
Joined: Sat Feb 13, 2021 12:15

Re: [Mod] Protector Redo [3.2] [protector]

by sangeet » Post

Festus1965 wrote:
Tue Jul 06, 2021 23:21
sangeet wrote:
Tue Jul 06, 2021 17:27
i have quite a few. most of them have been around for some time. the only thing i added prior to this bug is dmobs from your repository.
mhh, test the same thing under original 5.4.1 or 5.2.0 MineTest server, then you might know the answer and solution.

mods are basically written for minetest, and the coders have already problems to fit there mods to the now basic changing minetest versions to be working,
I am sure they are most not intent to fix to every fork also
I can't replicate it even on MT :) only two players have this happening to them, all others are fine.

sangeet
Member
Posts: 49
Joined: Sat Feb 13, 2021 12:15

Re: [Mod] Protector Redo [3.2] [protector]

by sangeet » Post

OK, mystery solved. This was caused by techpack mod, when harvester tried to operate on territory, protected by another player. TenPlus1, thank you very much for your time and advices.

ZAAo
Member
Posts: 47
Joined: Tue Jul 27, 2021 16:15

Re: [Mod] Protector Redo [3.2] [protector]

by ZAAo » Post

Hi TenPlus1, thanks for your work on this mod! I have encountered an issue (similar to what was mentioned in this topic by avatarKatzEyez on 9 Aug 201 - viewtopic.php?f=11&t=9376&start=2007)... players who are not in the protection list, are able to teleport into protected spaces (e.g. into my house, which is otherwise not accessible by anyone other than me and my friends. Is there a way to "block" the teleport "ability" inside a protected area? I was surprised to find another player (a griefer actually, who had previously destroyed some builds done by me and my friends) suddenly standing next to me, inside a house entirely protected by protector blocks and protected doors. Later on I tested this for myself and was able to teleport into someone's house, which is also protected in the same way (protector blocks and protected doors). As I said, this is similar to what avatarKatzEyez talked about, with players using /sethome to later gain access (even more easily than with /teleport) to a protected area.

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Protector Redo [3.2] [protector]

by TenPlus1 » Post

@ZAAo - It's difficult to stop players teleporting into your home as we have many mods which allow them to do just that, although maybe I could override the sethome function to stop them that way.

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Updated to Version 3.4

by TenPlus1 » Post

- Added protector flip and hurt to on_protection_violation function (thanks hlqkj)

User avatar
Festus1965
Member
Posts: 4181
Joined: Sun Jan 03, 2016 11:58
GitHub: Festus1965
In-game: Festus1965 Thomas Thailand Explorer
Location: Thailand ChiangMai
Contact:

Re: [Mod] Protector Redo [3.2] [protector]

by Festus1965 » Post

TenPlus1 wrote:
Tue Jul 27, 2021 19:22
@ZAAo - It's difficult to stop players teleporting into your home as we have many mods which allow them to do just that, although maybe I could override the sethome function to stop them that way.
let your home be filled with lava during the time your not there ...
I guess possible also without technic or mesecon ... an attic room with a manual or automatic switch ... to let flow in or not
after back home I have most fun to harvest bones
Human has no future (climate change)
If urgend, you find me in Roblox (as CNXThomas)

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added 'protector_crafts' setting to disable doors/chest recipes.
- Changed wooden door/chest to immediate_dig to fix Mineclone2 issue.

iXware
New member
Posts: 8
Joined: Sat Feb 13, 2021 15:29

Re: [Mod] Protector Redo [3.4] [protector]

by iXware » Post

Hi,
I think I have discovered a bug in the mod. One of the players on one of my Mineclone2 servers (Debian 10, minetest 5.3, mineclone 0.71) can crash the server when using place/use with a protected stone block
In the logfile i then find the following lines. i just updated the mod version to the latest master.zip from git. the problem still exists.
Spoiler
2021-12-07 18:04:17: ACTION[Main]: hb.register_hudbar: health
2021-12-07 18:04:17: ACTION[Main]: hb.register_hudbar: breath
2021-12-07 18:04:17: ACTION[Main]: [doc] doc.mt opened.
2021-12-07 18:04:17: ACTION[Main]: [doc] doc.mt successfully read.
2021-12-07 18:04:17: ACTION[Main]: hb.register_hudbar: armor
2021-12-07 18:04:17: ACTION[Main]: [mcl_weather] Weather restored.
2021-12-07 18:04:17: ACTION[Main]: [bell] Read positions of bells from savefile.
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:578: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:766: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:152: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:310: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:190: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:310: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:228: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:310: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:266: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:310: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:152: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:354: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:190: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:354: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:228: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:354: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:266: in function 'register_door'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:354: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:451: in function 'register_trapdoor'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:457: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:452: in function 'register_trapdoor'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:457: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:451: in function 'register_trapdoor'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:498: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:182: in function 'register_item'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:208: in function 'register_node'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:452: in function 'register_trapdoor'
2021-12-07 18:04:17: ERROR[Main]: ...st/worlds/mineclone2/worldmods/protector/doors_chest.lua:498: in main chunk
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'dofile'
2021-12-07 18:04:17: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:796: in main chunk
2021-12-07 18:04:17: WARNING[Main]: [stairs] No explicit description for double slab 'mcl_stairs:slab_bamboo_double' added. Using auto-generated description.
2021-12-07 18:04:17: WARNING[Main]: Undeclared global variable "eternal_fire_help" accessed at ...test/worlds/mineclone2/worldmods/mcl_blackstone/init.lua:109
2021-12-07 18:04:17: WARNING[Main]: Undeclared global variable "fire_death_messages" accessed at ...test/worlds/mineclone2/worldmods/mcl_blackstone/init.lua:129
2021-12-07 18:04:17: WARNING[Main]: Undeclared global variable "LIGHT_TORCH" accessed at ...test/worlds/mineclone2/worldmods/mcl_blackstone/init.lua:944
2021-12-07 18:04:17: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:17: ERROR[Main]: stack traceback:
2021-12-07 18:04:17: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:17: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:407: in function 'override_item'
2021-12-07 18:04:17: ERROR[Main]: ...etest/games/mineclone2/mods/CORE/_mcl_autogroup/init.lua:343: in function 'overwrite'
2021-12-07 18:04:17: ERROR[Main]: ...etest/games/mineclone2/mods/CORE/_mcl_autogroup/init.lua:363: in main chunk
2021-12-07 18:04:18: ACTION[Main]: [mcl_skins] Mod initialized with 11 custom skin(s)
2021-12-07 18:04:18: ERROR[Main]: Invalid field use_texture_alpha (expected boolean got string).
2021-12-07 18:04:18: ERROR[Main]: stack traceback:
2021-12-07 18:04:18: ERROR[Main]: [C]: in function 'register_item_raw'
2021-12-07 18:04:18: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:407: in function 'override_item'
2021-12-07 18:04:18: ERROR[Main]: ...-server/.minetest/games/mineclone2/mods/HELP/tt/init.lua:53: in function <...-server/.minetest/games/mineclone2/mods/HELP/tt/init.lua:47>
2021-12-07 18:04:18: ERROR[Main]: /usr/share/games/minetest/builtin/game/register.lua:429: in function </usr/share/games/minetest/builtin/game/register.lua:413>
2021-12-07 18:04:19: ACTION[Main]: World at [/var/games/mineclone2-server/.minetest/worlds/mineclone2]
2021-12-07 18:04:19: ACTION[Main]: Server for gameid="mineclone2" listening on 85.10.203.252:30000.
2021-12-07 18:04:30: ACTION[Server]: malte [93.225.211.247] joins game. List of players: malte
2021-12-07 18:04:30: ACTION[Server]: [mcl_skins] Player skin for malte set to skin #9
2021-12-07 18:04:39: WARNING[Server]: Undeclared global variable "geckopos" accessed at ...minetest/worlds/mineclone2/worldmods/waterlife/spawn.lua:88
2021-12-07 18:05:10: ACTION[Main]: Server: Shutting down
2021-12-07 18:05:10: ACTION[Main]: [doc] Server shuts down. Player data is about to be saved.
2021-12-07 18:05:10: ACTION[Main]: [doc] Wrote player data into /var/games/mineclone2-server/.minetest/worlds/mineclone2/doc.mt.
2021-12-07 18:05:11: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback item_OnPlace(): ....minetest/worlds/mineclone2/worldmods/protector/init.lua:163: attempt to concatenate field 'gui_slots' (a nil value)
2021-12-07 18:05:11: ERROR[Main]: stack traceback:
2021-12-07 18:05:11: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:163: in function 'protector_formspec'
2021-12-07 18:05:11: ERROR[Main]: ....minetest/worlds/mineclone2/worldmods/protector/init.lua:528: in function 'on_rightclick'
2021-12-07 18:05:11: ERROR[Main]: /usr/share/games/minetest/builtin/game/item.lua:426: in function </usr/share/games/minetest/builtin/game/item.lua:419>

with kind regards
Frank

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Protector Redo [3.4] [protector]

by TenPlus1 » Post

iXware: Are you sure you are using Minetest 5.x as the following errors only come from 0.4.x versions:

"Invalid field use_texture_alpha (expected boolean got string)."

As for the crash you may be using an older version of Protector Redo in your world since the error doesn't line up with the current code. I've tweaked a few things just incase since mineclone2 isn't fully 'default' compatible so update to new version and give it a go :)

iXware
New member
Posts: 8
Joined: Sat Feb 13, 2021 15:29

Re: [Mod] Protector Redo [3.4] [protector]

by iXware » Post

yes I am very sure that I am using version 5.

and I do not think that I have installed too old version of Protector Redo. I updated from version 3.3 to 3.4 yesterday due to the bug, with no change in behavior. I checked out the version from git again this morning. That one didn't change anything either.

see the server-Version
minetestversion-on-server.png
minetestversion-on-server.png (23.08 KiB) Viewed 2610 times
and the Mod-Version on server
Screenshot_20211208_142045.png
Screenshot_20211208_142045.png (38.05 KiB) Viewed 2610 times
For testing, I just set a stone block and a protection for that stone block - my users and I have different clients with Linux or Windows and Minetest with at least version 5.3 - I don't allow older versions.
mineclone-client.png
mineclone-client.png (526.25 KiB) Viewed 2610 times
Last edited by iXware on Wed Dec 08, 2021 13:40, edited 2 times in total.
with kind regards
Frank

iXware
New member
Posts: 8
Joined: Sat Feb 13, 2021 15:29

Re: [Mod] Protector Redo [3.4] [protector]

by iXware » Post

with dig/punce
Screenshot_20211208_135957.png
Screenshot_20211208_135957.png (451.97 KiB) Viewed 2610 times
and with place/use button on mouse
Screenshot_20211208_140025.png
Screenshot_20211208_140025.png (26.79 KiB) Viewed 2610 times
with kind regards
Frank

User avatar
sirrobzeroone
Member
Posts: 593
Joined: Mon Jul 16, 2018 07:56
GitHub: sirrobzeroone
Contact:

Re: [Mod] Protector Redo [3.4] [protector]

by sirrobzeroone » Post

Hi TenPlus1, I don't think this is a bug with your mod but potentially a hole in the general mt protection, but I don't have the knowledge to draw that conclusion. So thought best to flag with yourself and see what you think.

I've been playing around with updating Comboblock and wanted to see how well it did with respecting protection with no specific protection checks and it did okay. However I am noticing that anytime I use minetest.swap_node() inside comboblock this seems to still work in protected area's. I'm guessing it's because swap dosen't fire the normal callbacks set/place does?

I can add some checks but thought it best to reach out and get your thoughts as well. Thanks for any help.

edit: should have mentioned I'm using Protector redo for testing :)

User avatar
LMD
Member
Posts: 1385
Joined: Sat Apr 08, 2017 08:16
GitHub: appgurueu
IRC: appguru[eu]
In-game: LMD
Location: Germany
Contact:

Re: [Mod] Protector Redo [3.4] [protector]

by LMD » Post

sirrobzeroone wrote:
Mon Jun 13, 2022 09:17
Hi TenPlus1, I don't think this is a bug with your mod but potentially a hole in the general mt protection, but I don't have the knowledge to draw that conclusion. So thought best to flag with yourself and see what you think.
[...]
However I am noticing that anytime I use minetest.swap_node() inside comboblock this seems to still work in protected area's. I'm guessing it's because swap dosen't fire the normal callbacks set/place does?
[...]
It's not a "hole", it's intended behavior. These functions (set_node, add_node, remove_node etc.) are supposed to be used by modders who know what they are doing; they don't check protection using minetest.is_protected, that's left up to the modder.

Player interactions (placing / digging and the respective engine funcs) respect protection.
My stuff: Projects - Mods - Website

User avatar
sirrobzeroone
Member
Posts: 593
Joined: Mon Jul 16, 2018 07:56
GitHub: sirrobzeroone
Contact:

Re: [Mod] Protector Redo [3.4] [protector]

by sirrobzeroone » Post

LMD wrote:
Mon Jun 13, 2022 12:19
Thanks LMD just what I needed to know :). I didn't want to add a fix which potentially could break protection in general and it's not an area i've looked at much and the api is rather thin on the topic - tried both under protect and swap...probably there somewhere I just couldn't locate the info.

Thanks again, I'll add a check for my swap events across in comboblock which should then make it play nicer in general with protection. At the moment someone could change a protected area by adding slabs on top/below/beside existing placed slabs which would be annoying to have to fix as the builder if protection was enabled.

:)

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Protected Chest names can only use alphanumerical and spaces and are limited to 35 characters long.

User avatar
Irremann
Member
Posts: 49
Joined: Fri Jan 10, 2020 06:03
GitHub: Irremann
Location: Russia, Pereslavl-Zalesskiy

Re: [Mod] Protector Redo [3.4] [protector]

by Irremann » Post

Hi all. Enyekala server has protectors with different radius and timer. Where can I find the code for this mod?

User avatar
Zweihorn
Member
Posts: 22
Joined: Tue Dec 06, 2022 18:06

Re: [Mod] Protector Redo [3.4] [protector]

by Zweihorn » Post

Irremann wrote:
Mon Dec 12, 2022 15:33
Hi all. Enyekala server has protectors with different radius and timer. Where can I find the code for this mod?
Hi @Irremann,
regarding your question:

Beyond the information on page 1 of this topic at viewtopic.php?f=11&t=9376 you will find:
a) the code for the protector mod at: https://notabug.org/TenPlus1/protector
b) the applicable information on the radius on same page below the list of code and after the Changelog.
The following lines can be added to your minetest.conf file to configure specific features of the mod:

protector_radius = 5

Sets the area around each protection node so that other players cannot dig, place or enter through protected doors or chests.
and some more ...

Hope this helps.

User avatar
sirrobzeroone
Member
Posts: 593
Joined: Mon Jul 16, 2018 07:56
GitHub: sirrobzeroone
Contact:

Re: [Mod] Protector Redo [3.4] [protector]

by sirrobzeroone » Post

made this to use as a placer tool, not sure if anyone else would liek to use or Tenplus1 include in the mod?

licence: CC0

preview
protector_placer_big.png
protector_placer_big.png (711 Bytes) Viewed 1233 times
Attachments
protector_placer.png
protector_placer.png (599 Bytes) Viewed 1233 times

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added new protector_tool.png texture, thanks sirrobzeroone :)

User avatar
TenPlus1
Member
Posts: 3700
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Tweaked nodebox so Protectors are visible underground.

Post Reply

Who is online

Users browsing this forum: No registered users and 15 guests