PilzAdam wrote:I dont like the checking for chests or owned nodes, because just some random meta strings are tested.
True. I don't like the implementation either. I wanted to test for meta data in general, but I'm not sure that can be done with the current API.
PilzAdam wrote:I have talked to VanessaE about the crafting grid. People shouldnt use crafting grid as transport space so we decided to try to add the content but when there is not enough space its simply lost.
Then the ability to store things there should be removed before bones is added to minetest_game. The fact is, people DO store things there, and it's not fair for those items to be lost. People are just making use of the tools provided by the game.
PilzAdam wrote:I also dont like to add the replaced nodes to the bones inventory because it should only contain the players items. Otherwise it would be possible to dig mese without any tools.
True, but replacing the mese with the bones node and completely losing the mese forever is worse. Just the inconvenience of finding a way to die in mese just to avoid having to use a tool paired with being warped back to the spawn point so you have to walk all the way back down into the mine to find the mese/bones will deter people from using bones as a way of mining without tools. Not to mention the fact that you can only find your way into the mese to die if you already had a strong enough tool to break the mese in the first place, but lag caused the server to not respond to your digging. Or course, another solution is to just not spawn bones if the player is inside ANY node, and let them keep their stuff in that case.
PilzAdam wrote:Changing minetest.env:remove_node() to dig_node() is a nice idea and I will maybe add it. But a problem here is (mesecons has this problem too) that this calls minetest.handle_node_drops(). If item_drop mod is used this causes the node to be dropped there, so mining mese without tools is possible.
It is the responsibility of plugin developers to make sure their plugins are fixed to be compatible with minetest_game. In fact, that fix to bones is incompatible with my Full Inventory plugin, which is something I will need to fix if bones is added. Actually, I need to fix it either way, because an incompatibility is an incompatibility. If whoever is developing item_drop has a problem with the way bones is interacting with nodes, they need to add a check to see if the digger is an actual player.
Speaking of incompatibility, NOT using node_dig() is incompatible with some plugins as well. For example, in minetest_game, doors.
-=-=-=-
Maybe my method of dealing with these problems wasn't the best way. However, until theses problems are fixed, be it my fix or a different fix, adding bones to minetest_game seems like a very bad idea. If bones is to be added by default, it should at least be functioning well.