[Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fixes

User avatar
afflatus
Member
Posts: 329
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus
Location: Avalonia
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Post

That works :-)
Grailtest is dreaming ...

User avatar
afflatus
Member
Posts: 329
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus
Location: Avalonia
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Post

This mod doesn't seem to respect shout priv, which means I can't gag verbally abusive players. Has anyone else experienced this?
Grailtest is dreaming ...

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post

Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4

User avatar
afflatus
Member
Posts: 329
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus
Location: Avalonia
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Post

rubenwardy wrote:Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4
It does indeed. Thank you :)
Grailtest is dreaming ...

bark
Member
Posts: 35
Joined: Thu Sep 24, 2015 13:25
In-game: bark

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by bark » Post

EDIT: Never mind

User avatar
Fixer
Member
Posts: 898
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer
Location: Ukraine

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by Fixer » Post

Please add few simple optional antispam filters to public chat (and mail?):
+ block same message spam by player
+ truncate or block very large messages
+ block messages with https:// or ftp:// or www.

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post

1) Good suggestion, is in my (mental) to do list
2) This is potentially problematic - what if they write a long rant, and have it deleted?
3) This is also problematic - how do you detect web links reliably?

User avatar
mahmutelmas06
Member
Posts: 367
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by mahmutelmas06 » Post

Is it possible to see only chat messages left of the bottom instead of top ?
It would be easier to read.
My Mods:

Beverage

User avatar
Fixer
Member
Posts: 898
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer
Location: Ukraine

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by Fixer » Post

>2) This is potentially problematic - what if they write a long rant, and have it deleted?

add sane defaults (amount of symbols before truncation) and make it disabable if you are worrying, I've seen some huge spam messages that cover my entire 1280*1024 screen which slowed down minetest to few fps on descent PC.

>3) This is also problematic - how do you detect web links reliably?

Number 3 is not a big deal, 1) and 2) is a big deal, worst kinds of spam

User avatar
fireglow
Member
Posts: 93
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow
Location: Germany

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Post

Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a

User avatar
ExeterDad
Member
Posts: 1717
Joined: Sun Jun 01, 2014 20:00
In-game: ExeterDad
Location: New Hampshire U.S.A

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by ExeterDad » Post

fireglow wrote:Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a
I'm seeing this as well. Newer dev clients no longer have chat prediction visible. I thought about overcoming this on mine by sending a copy of sent chat to sender, but then older clients with chat prediction would see double posts.

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post


User avatar
ExeterDad
Member
Posts: 1717
Joined: Sun Jun 01, 2014 20:00
In-game: ExeterDad
Location: New Hampshire U.S.A

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by ExeterDad » Post

Nice! And only two lines added? Is it wrong that I hate how easy you make things look? :P

User avatar
fireglow
Member
Posts: 93
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow
Location: Germany

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Post

Not quite, I'm afraid:

Code: Select all

ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_chat_message(): /srv/minetest/world3/worldmods/chatplus/api.lua:223: attempt to call field 'chat_send_place' (a nil value)
stack traceback:
      /srv/minetest/world3/worldmods/chatplus/api.lua:223: in function 'send'
      /srv/minetest/world3/worldmods/chatplus/api.lua:232: in function </srv/minetest/world3/worldmods/chatplus/api.lua:231>
      ...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:412: in function <...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:392>
Server: 0.4.15-7b74f04a
Client: 0.4.15-c05dfac

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post


User avatar
fireglow
Member
Posts: 93
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow
Location: Germany

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Post

Perfect, thank you very much!

User avatar
fireglow
Member
Posts: 93
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow
Location: Germany

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Post

I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post

fireglow wrote:I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?
Afaik there's no way of detecting whether a client will print the chat message before sending it, so yes: I can only support one or the other :(

User avatar
rubenwardy
Moderator
Posts: 6276
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post

I will no longer be supporting chatplus. It doesn't do what it does very well, and just causes headaches.
I suggest using these mods instead:

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest