[Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fixes

User avatar
BrunoMine
Member
Posts: 1073
Joined: Thu Apr 25, 2013 17:29
GitHub: BrunoMine
Location: SP-Brasil
Contact:

by BrunoMine » Post

Living and discovering! Thanks for the solution. But I think it would be cool to idea of the computer! I think we should explore the possibilities of using a work area in pcs.
We could use pcs for:
Access banking balance and make payments
Use our inbox
Read news event server
Read a wiki server
Enter and exit rooms private chat.

All this without becoming annoying Recurring commands!
But anyway, I believe it will happen when the minetest become a very famous game.
My small square universe under construction ... Minemacro
Comunidade Minetest Brasil
www.minetestbrasil.com

User avatar
fairiestoy
Member
Posts: 191
Joined: Sun Jun 09, 2013 19:25
Location: Germany

by fairiestoy » Post

Hello ruben,

i came up with a suggestion when looking through my fork of this and watching the user traffic on the landruch server. I think its necessary to include some kind of time check when a user last log in. Otherwise, your file will be fed up by dozens of users that show up only once and never come back. But they do take place in your files, therefore it might be a good idea to attach a date to each user when he last logged in and delete him after a specific timespan. About compatibility with your old files: Since you are only storing a serialized table, you could make check on init (when loading the data from file) if each user has already such a date. It will increase the server load time, but will keep the resulting file smaller as well as the used memory.

Greetings
Interesting about new things is, to figure out how it works ...

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

by rubenwardy » Post

0.5 Released!

Reworked code to be more stable and logical.

When the game is loaded, it cleans stored data to get rid of any unneeded ones, fixing @fairiestoy's problem.

To enable distance limitation, set chatplus_distance in minetest.conf to something bigger than zero.

To disable logging, set chatplus_log to false in minetest.conf.

Coming soon:
  • Freeminer specific features (coloring)
  • Mention Highlighting
Last edited by rubenwardy on Tue Jan 07, 2014 18:26, edited 1 time in total.

User avatar
Krock
Developer
Posts: 4526
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

by Krock » Post

Can't say much about this, I like this mod!

A GUI would be a cool addition but right now it's working well :)

EDIT: sorry, it's not working well:

Code: Select all

/mail singleplayer haiiii

20:55:21: ERROR[main]: ServerError: LuaError: E:\Programme\minetest\bin\..\mods\
chatplus\init.lua:288: bad argument #1 to 'insert' (table expected, got nil)
20:55:21: ERROR[main]: stack traceback:
20:55:21: ERROR[main]:  [C]: in function 'insert'
20:55:21: ERROR[main]:  E:\Programme\minetest\bin\..\mods\chatplus\init.lua:288:
 in function 'func'
20:55:21: ERROR[main]:  E:\Programme\minetest\bin\..\builtin/chatcommands.lua:25
: in function <E:\Programme\minetest\bin\..\builtin/chatcommands.lua:16>
Last edited by Krock on Tue Jan 07, 2014 19:55, edited 1 time in total.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

by rubenwardy » Post


User avatar
Sokomine
Member
Posts: 4046
Joined: Sun Sep 09, 2012 17:31
GitHub: Sokomine

by Sokomine » Post

It would be very good if individual messages in the inbox could be deleted while others could be kept. A command like /inbox del <nr> to delete message <nr> would be very welcomed.
A list of my mods can be found here.

User avatar
Jonathan
Member
Posts: 119
Joined: Tue Apr 02, 2013 14:07
Location: USA

by Jonathan » Post

rubenwardy wrote:

Coming soon

  • Swearing filter
Nice! Keep up the good work!
By perseverance the snail reached the ark.
- Charles Spurgeon

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

by rubenwardy » Post

Graphical inboxes

0.6 adds formspec inboxes like the following. They are scrollable.

You can still access the text/chat version by typing /inbox text or /inbox t

Image
Last edited by rubenwardy on Wed Apr 09, 2014 19:01, edited 1 time in total.

User avatar
hoodedice
Member
Posts: 1372
Joined: Sat Jul 06, 2013 06:33
GitHub: hoodedice
IRC: hoodedice
In-game: hoodedice
Location: world
Contact:

by hoodedice » Post

Why is this not default already?
7:42 PM - Bauglio: I think if you go to staples you could steal firmware from a fax machine that would run better than win10 does on any platform
7:42 PM - Bauglio: so fudge the stable build
7:43 PM - Bauglio: get the staple build

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

by rubenwardy » Post

It would be pointless in single player, so it probably won't be added to minetest_game.

4aiman
Member
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

by 4aiman » Post

Neat! :)

Also, what about swearing filter?
Do you plan to add a dictionary of the most frequently used swears?
It would be funny to replace all those with "Capybara" :)

User avatar
BrunoMine
Member
Posts: 1073
Joined: Thu Apr 25, 2013 17:29
GitHub: BrunoMine
Location: SP-Brasil
Contact:

Re: [Mod] Chat plus [0.6] [chatplus] -- Inbox GUI

by BrunoMine » Post

Eui just want to mail. The old version has only mail?

This is a bug:
size[10,5]textlist[0,0;9.75,5;inbox;13/06 <Admin>: Ola]
11:04:50: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: Ola'
11:04:55: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: Ola'
size[10,5]textlist[0,0;9.75,5;inbox;13/06 <Admin>: HOOOOOOOOOOOOOOaaaa]
11:05:37: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: HOOOOOOOOOOOOOOaaaa'
GUIPauseMenu: Not allowing focus change.

User avatar
stormchaser3000
Member
Posts: 419
Joined: Sun Oct 06, 2013 21:02
GitHub: stormchaser3000

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by stormchaser3000 » Post

please add the swearing filter. for english, russian, spanish, portuguese, and german swear words. and please make it compatible with the irc mod

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by rubenwardy » Post

Already exists, set the chatplus_badwords = one, two, three as a setting in minetest.conf

or add it in lua here yourself: https://github.com/rubenwardy/chatplus/ ... t.lua#L401

User avatar
CWz
Member
Posts: 197
Joined: Tue Dec 24, 2013 17:01
GitHub: chaoswormz
IRC: CWz
In-game: CWz
Location: Banana Land

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by CWz » Post

chat plus seems to allow players to talk without shout.

stormchaser3000, this also interferers with keyword_interact

Gundul
Member
Posts: 880
Joined: Thu Aug 27, 2015 10:55
GitHub: berengma
IRC: Gundul
Location: Europe/Asia

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by Gundul » Post

Nice work. I added to my server "Jungle".
As admin it would be cool if there was an option to send email to all users. For example to inform about news on the server.
My servers: Jungle, Lilly in the valley, ZombieTest

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by Minetestforfun » Post

Gundul wrote:Nice work. I added to my server "Jungle".
As admin it would be cool if there was an option to send email to all users. For example to inform about news on the server.
+1

JoshMars
Member
Posts: 108
Joined: Sat May 17, 2014 23:24
In-game: rubber UbuntuJosh

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by JoshMars » Post

Basically this whole mod should be client side and should be included by default

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by rubenwardy » Post

Yes. Now that email, has been separated, it's pretty much just an ignore filter by default. It has an API too, though, but not used much.

vitaminx
Member
Posts: 49
Joined: Tue Dec 30, 2014 15:08

.

by vitaminx » Post

.
Last edited by vitaminx on Sun Sep 23, 2018 15:48, edited 1 time in total.

Gundul
Member
Posts: 880
Joined: Thu Aug 27, 2015 10:55
GitHub: berengma
IRC: Gundul
Location: Europe/Asia

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by Gundul » Post

I had some trouble when updating from chatplus 0.6 to the new version.

Together with your email 0.1 I could send mails and use /msg also. Everything
seemed to work fine. But what did not work was the chat. Not even one single
word wanted to appear on screen. Only who logged in and out was shown.

I commented this in your api.lua out and now it works:

Code: Select all

-- Minetest callbacks
--minetest.register_on_chat_message(function(...)
--	local ret = chatplus.send(...)
--	if ret and minetest.global_exists("irc") and irc.on_chatmessage then
--		irc.on_chatmessage(...)
--	end
--	return ret
--end)
Did you send all chat to Irc by default ?


Gundul
My servers: Jungle, Lilly in the valley, ZombieTest

User avatar
afflatus
Member
Posts: 325
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus
Location: Avalonia
Contact:

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by afflatus » Post

This is a very useful mod. I have found a couple of problems ...

* I have written a script to rotate chatplus-log.txt as it can easily grow to several MB if the server is busy. This was causing freeze-ups on my server (not enough memory probably)
* I want to move the mail icon from in-your-face. I dare say that is trivial (haven't looked yet).

I'm using an older version, so I'll upgrade to 1.0-rc before I comment any further.
Nice work Rubenwardy!
Grailtest is dreaming ...

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by rubenwardy » Post

I wish it was easier to place hud items compatibly. :(

Chatplus is a little bit outdated and needs some work from me to fix some things. I recommend you look into the ignore and email mods. Ignore works a lot better than chatplus, just looking at the code.

At some point I'll update it. I'm just quite busy with other things. Log rotation would be a nice feature.

User avatar
rubenwardy
Moderator
Posts: 6162
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Post

2.3 Released!

Fixes chat messages not sending

https://github.com/rubenwardy/chatplus/ ... s/tag/v2.3

User avatar
afflatus
Member
Posts: 325
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus
Location: Avalonia
Contact:

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Post

OK, I was just about to report that.
I'll pull and test.
Thanks
Grailtest is dreaming ...

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests