Page 3 of 3

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Thu Mar 17, 2016 17:13
by afflatus
That works :-)

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sat Mar 19, 2016 07:39
by afflatus
This mod doesn't seem to respect shout priv, which means I can't gag verbally abusive players. Has anyone else experienced this?

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sat Mar 19, 2016 14:43
by rubenwardy
Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sat Mar 19, 2016 19:23
by afflatus
rubenwardy wrote:Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4


It does indeed. Thank you :)

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Wed Jun 01, 2016 21:46
by bark
EDIT: Never mind

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sun Aug 28, 2016 12:46
by Fixer
Please add few simple optional antispam filters to public chat (and mail?):
+ block same message spam by player
+ truncate or block very large messages
+ block messages with https:// or ftp:// or www.

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sun Aug 28, 2016 13:06
by rubenwardy
1) Good suggestion, is in my (mental) to do list
2) This is potentially problematic - what if they write a long rant, and have it deleted?
3) This is also problematic - how do you detect web links reliably?

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sun Aug 28, 2016 17:18
by mahmutelmas06
Is it possible to see only chat messages left of the bottom instead of top ?
It would be easier to read.

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sun Aug 28, 2016 17:55
by Fixer
>2) This is potentially problematic - what if they write a long rant, and have it deleted?

add sane defaults (amount of symbols before truncation) and make it disabable if you are worrying, I've seen some huge spam messages that cover my entire 1280*1024 screen which slowed down minetest to few fps on descent PC.

>3) This is also problematic - how do you detect web links reliably?

Number 3 is not a big deal, 1) and 2) is a big deal, worst kinds of spam

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 11:00
by fireglow
Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 14:54
by ExeterDad
fireglow wrote:Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a


I'm seeing this as well. Newer dev clients no longer have chat prediction visible. I thought about overcoming this on mine by sending a copy of sent chat to sender, but then older clients with chat prediction would see double posts.

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 15:15
by rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 15:18
by ExeterDad
rubenwardy wrote:https://github.com/rubenwardy/chatplus/commit/d0834e2cb31d67645c1840d4cf4ee4ed872d2a85

Nice! And only two lines added? Is it wrong that I hate how easy you make things look? :P

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 15:49
by fireglow
Not quite, I'm afraid:
Code: Select all
ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_chat_message(): /srv/minetest/world3/worldmods/chatplus/api.lua:223: attempt to call field 'chat_send_place' (a nil value)
stack traceback:
      /srv/minetest/world3/worldmods/chatplus/api.lua:223: in function 'send'
      /srv/minetest/world3/worldmods/chatplus/api.lua:232: in function </srv/minetest/world3/worldmods/chatplus/api.lua:231>
      ...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:412: in function <...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:392>

Server: 0.4.15-7b74f04a
Client: 0.4.15-c05dfac

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 15:51
by rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 15:53
by fireglow
Perfect, thank you very much!

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Mon Mar 20, 2017 16:16
by fireglow
I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Thu Mar 23, 2017 15:28
by rubenwardy
fireglow wrote:I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?


Afaik there's no way of detecting whether a client will print the chat message before sending it, so yes: I can only support one or the other :(

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

PostPosted: Sat Jan 05, 2019 23:30
by rubenwardy
I will no longer be supporting chatplus. It doesn't do what it does very well, and just causes headaches.
I suggest using these mods instead: