[Mod] Unified_Inventory Skins [u_skins]

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

stu wrote:I looked over the code and the cause is simply that someone removed the underscore that was between u_skins_set and the skin number. I just pushed a change to 3d_armor that fixes this ;-)
Seems like my version of this mod was used, so I think this one is ready for the forum "Old Mods".
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

Re: [Mod] Unified_Inventory Skins [u_skins]

by stu » Post

Krock wrote: Seems like my version of this mod was used, so I think this one is ready for the forum "Old Mods".
Well, not really, this is modding general so it's not really a released mod. Is SmallJoker's fork in release anyehere yet? If not someone should do that and I will make that the officially supported version for armor.

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

stu wrote:Well, not really, this is modding general so it's not really a released mod. Is SmallJoker's fork in release anyehere yet? If not someone should do that and I will make that the officially supported version for armor.
There you go.
Krock equals SmallJoker (GitHub link in my profile / on left side)
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

Re: [Mod] Unified_Inventory Skins [u_skins]

by stu » Post

Krock wrote: There you go.
Krock equals SmallJoker (GitHub link in my profile / on left side)
Oh, I should have realized you were one and the same, der. I have updatet the top post of the 3d armor topic and linked to your version of the mod.

Cheers!

User avatar
stu
Member
Posts: 923
Joined: Sat Feb 02, 2013 02:51
GitHub: stujones11
Location: United Kingdom

Re: [Mod] Unified_Inventory Skins [u_skins]

by stu » Post

Eh... Why was this moved to old mods? when (a) it was not in release and (b) It still works fine with current stable?

Korck's version is better for sure but by extension you could say that simple mobs should be moved here because Calinou's version is arguably better.

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

xxx@Minetest:~/minetest/mods/u_skins$ python ./update_from_db.py
Traceback (most recent call last):
File "./update_from_db.py", line 2, in <module>
from http.client import HTTPConnection
ImportError: No module named http.client
xxx@Minetest:~/minetest/mods/u_skins$ python ./update_from_db2.py
Traceback (most recent call last):
File "./update_from_db2.py", line 5, in <module>
import requests
ImportError: No module named requests
Errr... i think, i have a problem... :)

mgl
Member
Posts: 39
Joined: Wed Sep 10, 2014 16:13
GitHub: mgl512
Location: France

Re: [Mod] Unified_Inventory Skins [u_skins]

by mgl » Post

Minetestforfun wrote:...
You probably use an outdated version of this mod, because there's no more "update_from_db2.py" script in Krock's latest git.

Clone it and fix the bug (that I forgot to report) in the base64 function call of the "update_from_db.py" script:
Edit: Krock fixed it.

Then, fix your python: the "http.client" module that the scrip "update_from_db.py" uses is in the debian package "python3.2".
Last edited by mgl on Mon Oct 06, 2014 11:51, edited 1 time in total.

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

Thank you for your answer,
But... i don't want use the u_skin of krock, because his mod has less skins :/ (4pages vs 10 pagesin this mod)

Or, a possible merge is conceivable ?

mgl
Member
Posts: 39
Joined: Wed Sep 10, 2014 16:13
GitHub: mgl512
Location: France

Re: [Mod] Unified_Inventory Skins [u_skins]

by mgl » Post

Minetestforfun wrote:Thank you for your answer,
But... i don't want use the u_skin of krock, because his mod has less skins :/ (4pages vs 10 pagesin this mod)
Use the script "update_from_db.py" (still talking about Krock's fork) to fetch all the skins available at Addis's website. That's the purpose of this mod. I used it yesterday to download something like 350 skins (25 pages of skins in the game, in the unified_inventory menu).

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

Thank you, my u_skins DB is now updated (39 pages :D !!!)

(EDIT :
I've problems when i restarted my server => http://imgur.com/B57bga5
Indeed, i's saw 39pages when update the DB of u_skins, but only 25pages appear in-game, for the rest of the skins, i think they are in the screenshot because they can't increase the number of skins above 250 or 25 pages...
It works, but, if i can have 39pages instead of 25 for now, it's btter for the choice of players :)

mgl
Member
Posts: 39
Joined: Wed Sep 10, 2014 16:13
GitHub: mgl512
Location: France

Re: [Mod] Unified_Inventory Skins [u_skins]

by mgl » Post

Minetestforfun wrote:i's saw 39pages when update the DB of u_skins, but only 25pages appear in-game
Don't take the number of pages displayed by different applications as a reliable information because they don't have the same number of skins per page. Addis currently shows 30 skins per page while unified_inventory has 16 skins per page. "update_from_db.py" claims another number (39) and is probably very wrong (should report the same number as the website, 13, I think) but it downloads all of them anyway.

The script "update_from_db.py" download skins from Addis's website. Count them yourself, count the total number of skins in your unified_inventory screen ans see that they match. You have every skin available.

I don't know why you have meta data errors on so many skins. Maybe all of them. My own log is clean.

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

Minetestforfun wrote:I've problems when i restarted my server => http://imgur.com/B57bga5
I can't reproduce this error with my forked version. Maybe you're using a mix of the original and mine.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

Actually in my world : 389 skins, and in the Addis's website they have 389 skins...

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

Hi,

Is it possible to add a variable for interdict skins too small or transparent ?

on a pvp server, if we can see only the eyes and the life bar of an opponent, is a handicap...

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

Minetestforfun wrote:Is it possible to add a variable for interdict skins too small or transparent ?

on a pvp server, if we can see only the eyes and the life bar of an opponent, is a handicap...
It's not possible to read the "main color" of a texture in Lua.
Ask the server owner to delete the skin's meta.txt file to remove it.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
mtmodder148
Member
Posts: 132
Joined: Wed May 14, 2014 13:44
GitHub: MT-Modder
In-game: mtmodder148

Re: [Mod] Unified_Inventory Skins [u_skins]

by mtmodder148 » Post

I was wondering if you could add a tooltip of the name for each skin, instead of having to click on it to find out. If not then no big deal I just thought that would be cool. I love this mod by the way. And thank you to who ever made the .exe updater...just brilliant. :)

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

mtmodder148 wrote:I was wondering if you could add a tooltip of the name for each skin,
viewtopic.php?p=162689#p162689
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
mtmodder148
Member
Posts: 132
Joined: Wed May 14, 2014 13:44
GitHub: MT-Modder
In-game: mtmodder148

Re: [Mod] Unified_Inventory Skins [u_skins]

by mtmodder148 » Post

Thank you for the link.

User avatar
Gael de Sailly
Member
Posts: 753
Joined: Sun Jan 26, 2014 17:01
GitHub: Gael-de-Sailly
IRC: Gael-de-Sailly
In-game: Gael-de-Sailly Ginkgoo
Location: France

Re: [Mod] Unified_Inventory Skins [u_skins]

by Gael de Sailly » Post

There are now too many skins on his database.
It will be good to implement a new feature to display only our favourites in the list and a "skin search engine".
Last edited by Gael de Sailly on Fri Jan 02, 2015 21:10, edited 1 time in total.
Just realize how bored we would be if the world was perfect.

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

I agree it's a good idea Gael, and if we can add a feature to display/hide skin, maybe in a new file with an option true/false for each skin, it will be awesome ! :)
(because actually i need to "hide" / delete skins manually, it's not a very good method, it's boring and take time, and if i update skins database with the python script, i must renew my skins deletion...)

User avatar
Gael de Sailly
Member
Posts: 753
Joined: Sun Jan 26, 2014 17:01
GitHub: Gael-de-Sailly
IRC: Gael-de-Sailly
In-game: Gael-de-Sailly Ginkgoo
Location: France

Re: [Mod] Unified_Inventory Skins [u_skins]

by Gael de Sailly » Post

I was thinking about an in-game filter, as for the items filter at the right of the unified_inventory formspec.
There are now 422 skins. The classic list with 16 skins per page is not convenient. So it will be awesome to implement a filter. Imagine : you can switch between whole list, filter and your favourites (the ones that you've already used, needs also a feature to be removed from this list).

I'm dreaming. But I give you ideas. I've thought about coding it myself, but I lack time, and the formspec aren't really my field.
Just realize how bored we would be if the world was perfect.

User avatar
Minetestforfun
Member
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun
Location: On earth
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Minetestforfun » Post

im dreaming also, code these features are out of my range... But it's an awesome upgrade if it's done :)

User avatar
doyousketch2
Member
Posts: 112
Joined: Tue Feb 05, 2013 16:06
GitHub: doyousketch2
In-game: Sketch2
Location: Ohio
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by doyousketch2 » Post

I was on the Free Pizza Server, and one of the kids using the Android version was having a hard time using your mod, 'cuz the chat apparently over-writes the ability to change skins.

I wonder if there's a way to automatically hide the chat while the skin-change menu is open.

I would think you could simply set

Code: Select all

flags.show_chat = false
The thing is, that would just hide the chat once the skin-change menu comes up,
but the show_chat wouldn't toggle back to True when you exit out of that menu.

If anyone can figure this out, that'd be great. Maybe add a button to toggle chat on/off, either on the Android GUI, or in the inventory buttons somewhere.

User avatar
Krock
Developer
Posts: 4535
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Mod] Unified_Inventory Skins [u_skins]

by Krock » Post

doyousketch2 wrote:I would think you could simply set

Code: Select all

flags.show_chat = false
It's not possible to control clients to turn it off.
The only soulation for this is to add a chat on/off button for Android clients.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
DI3HARD139
Member
Posts: 154
Joined: Sat Oct 18, 2014 21:04
GitHub: DI3HARD139
IRC: DI3HARD139
In-game: DI3HARD139 DI3HARD139_

Re: [Mod] Unified_Inventory Skins [u_skins]

by DI3HARD139 » Post

When running generate_previews.sh I get Blender and convert not found errors.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests