Page 1 of 1

[This forum] Bug in forum theme

PostPosted: Mon Dec 15, 2014 06:45
by Linuxdirk
Hey there.

There is a bug in the forums theme. When displaying a thread the div with the ID “wrap” gets cut off by a </div> from somewhere causing all further posts on this page of the thread not being aligned properly because not being in the “wrap” div anymore.

Since there are too many errors when using the W3C validator check with Firefox Inspector (Right click, Q). All posts up to the post from the ignored member are within the “wrap” div. All posts after this post aren’t.

See screenshots (zoomed out for showing the highlighted parts properly).

Image Image

Kind regards,
Dirk

Re: [This forum] Bug in forum theme

PostPosted: Mon Dec 15, 2014 17:47
by Krock
Also my mod indexer finds about 20 syntax/code errors.
Luckily, I do not have any problems with the correct display on Chromium.

Re: [This forum] Bug in forum theme

PostPosted: Mon Dec 15, 2014 17:54
by addi
I also have no problems with firefox. but im using the phpbb default design instead of that minetest design.

Re: [This forum] Bug in forum theme

PostPosted: Mon Dec 15, 2014 18:00
by Linuxdirk
Krock wrote:I do not have any problems with the correct display on Chromium.

With Minetest theme and ignored users? When using the default theme it’s all fine. Same with not ignored users, but after the first post of a ignored user the rest of the thread display is broken.

Re: [This forum] Bug in forum theme

PostPosted: Mon Dec 15, 2014 18:13
by rubenwardy
I'd prefer a dark minetest theme, with the original stone texture as a background (not white washed), but nobody answered my question: https://github.com/minetest/forum.minet ... 1/issues/2

Re: [This forum] Bug in forum theme

PostPosted: Wed Dec 17, 2014 14:41
by Linuxdirk
rubenwardy wrote:I'd prefer a dark minetest theme, […]

I prefer an actually working theme :D

The default theme is weird. It’s like made for RTL languages and not LTR :)

Re: [This forum] Bug in forum theme

PostPosted: Sun Jan 04, 2015 05:44
by Linuxdirk
Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?

Re: [This forum] Bug in forum theme

PostPosted: Sun Jan 04, 2015 09:54
by sfan5
Linuxdirk wrote:Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?

IIRC, BlockMen is responsible for the forum theme.

Re: [This forum] Bug in forum theme

PostPosted: Sat Jan 10, 2015 16:16
by celeron55
The theme is here: https://github.com/minetest/forum.minet ... _template1

Post your fixes as pull requests.

Re: [This forum] Bug in forum theme

PostPosted: Sun Jan 11, 2015 21:37
by Linuxdirk
celeron55 wrote:Post your fixes as pull requests.

Since I don’t know how to create phpBB themes I don’t know which files to fix, sorry.

Re: [This forum] Bug in forum theme

PostPosted: Sun Jan 11, 2015 21:58
by rubenwardy
I'll fix it, or try to, as soon as I work out how to install the theme.

Re: [This forum] Bug in forum theme

PostPosted: Sun Jan 11, 2015 23:17
by 4aiman
It's marvelous and spectacular how ppl tend to ignore complaints made by some members and respond with eagerness to the similar ones made by other members.

This "theme" issue was reported by me long ago (somewhat around the 15th of October, 2014).
No one seemed to had encountered that one at the time.
But it was confirmed by other ppl in early December, 2014 and subsequently it was revealed that only FF+MT-theme users were affected so far.

I find that amusing, really.

Re: [This forum] Bug in forum theme

PostPosted: Thu Jan 22, 2015 04:12
by Sokomine
4aiman wrote:I find that amusing, really.

Might be more like a case of "Damn. Another user reported that bug again. We'll eventually have to fix it, or else they'll keep reporting" :-)

Re: [This forum] Bug in forum theme

PostPosted: Thu Jan 22, 2015 05:46
by 4aiman
Well, can't say that it'd be a bad case. IF the bug were fixed by now ;)