Opinons needed: Possible change in map block serialization

paramat
Developer
 
Posts: 2647
Joined: Sun Oct 28, 2012 00:05
Location: UK
GitHub: paramat

Opinons needed: Possible change in map block serialization

by paramat » Sun Feb 05, 2017 08:03

This PR fixes occasional light bugs caused by the cooling of lava https://github.com/minetest/minetest/pull/4682 but comes at a cost:

"To introduce the new flags I had to increase the map block serialization version, this is why you can not play on your maps on other versions of Minetest after you opened them in this version.
Of course old clients still can play, just the server has to be new to be able to read the map."

If this PR is merged, once you open a world with a server you cannot then afterwards open that world with an older server. This includes singleplayer as that is a server and client running on one machine.
Last edited by paramat on Sun Feb 12, 2017 23:02, edited 2 times in total.
 

User avatar
addi
Member
 
Posts: 605
Joined: Thu Sep 20, 2012 03:16
Location: Black-Forest, Germany

Re: Opinons needed: Possible change in map block serializati

by addi » Sun Feb 05, 2017 10:28

If this does not introduce any other bugs, I would fine with it.
 

User avatar
burli
Member
 
Posts: 1282
Joined: Fri Apr 10, 2015 13:18

Re: Opinons needed: Possible change in map block serializati

by burli » Sun Feb 05, 2017 10:42

Let me answer with a song

https://www.youtube.com/watch?v=HWPJ8Gvh2C4

I think, progress is more important than backwards compatibility at any cost
 

Thomas-S
Member
 
Posts: 62
Joined: Sun Sep 06, 2015 12:23
Location: Bavaria, Germany
GitHub: Thomas--S
IRC: Thomas-S
In-game: Thomas-S

Re: Opinons needed: Possible change in map block serializati

by Thomas-S » Sun Feb 05, 2017 14:40

I think that less bugs are more important than backwards compatibility.
 

CuriousNoob
Member
 
Posts: 74
Joined: Wed Jan 27, 2016 09:43

Re: Opinons needed: Possible change in map block serializati

by CuriousNoob » Sun Feb 05, 2017 14:51

paramat wrote:. . . you can not play on your maps on other versions of Minetest after you opened them in this version . . . the server has to be new to be able to read the map . . . If this PR is merged, once you open a world with a server you cannot then afterwards open that world with an older server . . .


From a position of complete ignorance on what/why/where ''map block serialization'' is here, just general-principle questions would be :

Does ''server'' include the singleplayer use-case too..?

Are there any feasible longer-term gotchas, unintended consequences, just this side of ''unforeseen'' outcomes..?

Will there be big clear pre-world-launch warnings about irreversibility, like I've seen for various other software over the years..?

Does the change affect the whole (huge) world-database, and if not, could any sort of automatic file-backup mitigate the risk of no-path-back breakage for users wanting to test it..?

Or again, if the huge database is not directly affected, then could there be potentially parallel ways to access the same data, as per the extensions to ISO9660 and hybrid filesystem views of data on optical discs..?

.
 

User avatar
burli
Member
 
Posts: 1282
Joined: Fri Apr 10, 2015 13:18

Re: Opinons needed: Possible change in map block serializati

by burli » Sun Feb 05, 2017 15:38

CuriousNoob wrote:[
Does the change affect the whole (huge) world-database, and if not, could any sort of automatic file-backup mitigate the risk of no-path-back breakage for users wanting to test it..?


I think, the server admin is responsible by himself for backups or to read the doc BEFORE he upgrades anything.

RTFM first
 

paramat
Developer
 
Posts: 2647
Joined: Sun Oct 28, 2012 00:05
Location: UK
GitHub: paramat

Re: Opinons needed: Possible change in map block serializati

by paramat » Sun Feb 05, 2017 15:51

Discussing on IRC dev channel the devs are thinking this is worth it, the 1st PR will fix more lighting bugs than just large areas of lavacooling, and helps make the 2nd PR more effective.

The first PR (which increases mapblock serialisation version) could be merged as soon as a few days, maybe a week, so this is a warning, and of course if it goes ahead it will be announced here and probably in a dedicated thread in this news subforum.

This does affect singleplayer yes because singleplayer is actually a server and a client running on a single machine.

I'm not knowledgeable about the more technical questions about the world database, maybe others will reply here.
 

User avatar
Wuzzy
Member
 
Posts: 2141
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy

Re: Opinons needed: Possible change in map block serializati

by Wuzzy » Sun Feb 05, 2017 16:08

I think you should go ahead and fix the bug. Unless you can find a way to fix the bug without breaking compability (this would be of course the best scenario).
But if not:
Getting rid of annoying lighting bugs is always important IMO, even if you have to break compability sometimes. Bad lighting in Minetest worlds can be very annoying or frustrating.

Also, I think compability shouldn't be too big a concern at this stage. Minetest is still incomplete and has a long way to go, so introducing important features or bugfixes should be expected. I would be more concerned about compability as soon Minetest hits the 1.0.0 milestone or is in beta stage.

But PLEASE add this info in the changelog (or better: in the release announcement) when you release the next version as this is important to know. (Speaking of changelogs, I'm still waiting for the 0.4.15 changelog. :P)

Thanks for asking the community before doing important changes, however.
I'm creating MineClone 2, a Minecraft clone for Minetest.
I made the Help modpack, adding in-game help to Minetest.
 

paramat
Developer
 
Posts: 2647
Joined: Sun Oct 28, 2012 00:05
Location: UK
GitHub: paramat
 

843jdc
Member
 
Posts: 204
Joined: Tue Jan 19, 2016 16:46
Location: USA
GitHub: jdc843
IRC: jdc843
In-game: 843jdc

Re: Opinons needed: Possible change in map block serializati

by 843jdc » Fri Feb 24, 2017 06:42

I guess it is too late to ask for a length|size field for serialized inventory in the world format? Every other data section of the database has a length|size|or count but not serialized inventory. ha. I don't even care about the contents right now. That's assuming that it is always there too. I just want to skip past it to get to the next nodes' metadata. But if people can write code that reads it and have a working game, I can read it also. IDK when though :)
 

paramat
Developer
 
Posts: 2647
Joined: Sun Oct 28, 2012 00:05
Location: UK
GitHub: paramat
 


Return to News

Who is online

Users browsing this forum: No registered users and 1 guest