Page 1 of 1

Setting absurdly long view range

Posted: Thu Oct 08, 2015 07:07
by OmniStudent
Is there a way (changing of source code OK) to extend the viewing range?
However I put the settings, it seems the game doesn't render nodes further than approximately half a kilometer. I've been standing in the same place for half an hour, hoping for the landscape further away to show.
I am aware that this may slow the game down to Unplayable, I just want to see what it looks like.

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 07:19
by Krock
Somewhen there's a limit when Minetest stops generating and/or sending far mapblocks.
For this, change in your minetest.conf the following lines:

Code: Select all

#    From how far blocks are sent to clients, stated in mapblocks (16 nodes)
max_block_send_distance = 10

#    From how far blocks are generated for clients, stated in mapblocks (16 nodes)
max_block_generate_distance = 6
minetest.conf.example GitHub link

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 08:06
by OmniStudent
Thanks, will try when nobody at work is looking ;)

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 09:49
by Morn76
Have you tried to enable far view by pressing R? First fly around the map a bit so everything gets loaded, then hit R.

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 11:08
by OmniStudent
Thanks!
Image

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 16:35
by OmniStudent
But that light blue artifact in the water is really annoying. I get them all the time.

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 17:39
by kaadmy
OmniStudent wrote:But that light blue artifact in the water is really annoying. I get them all the time.
Is that just sky showing through un-generated ground?

Re: Setting absurdly long view range

Posted: Thu Oct 08, 2015 17:50
by Don
Press + until it is at the range you want. - makes it shorter range.

Re: Setting absurdly long view range

Posted: Fri Oct 09, 2015 05:13
by OmniStudent
kaadmy wrote:
OmniStudent wrote:But that light blue artifact in the water is really annoying. I get them all the time.
Is that just sky showing through un-generated ground?
Never thought of that, but ground is obviously generated very far in the xy-plane.

Re: Setting absurdly long view range

Posted: Fri Oct 09, 2015 13:28
by celeron55
OmniStudent wrote:But that light blue artifact in the water is really annoying. I get them all the time.
That's an optimization that makes views like this look nasty. The server assumes that things that are pitch black and far away from the player wouldn't be visible or useful and doesn't send them, but as it turns out, the bottom of oceans is exactly like that.

You can try how it looks without that if you can modify the code and re-compile:

Code: Select all

diff --git a/src/clientiface.cpp b/src/clientiface.cpp
index a6ab1ef..1379431 100644
--- a/src/clientiface.cpp
+++ b/src/clientiface.cpp
@@ -288,19 +288,6 @@ void RemoteClient::GetNextBlocks (
 
                                if(block->isGenerated() == false)
                                        block_is_invalid = true;
-
-                               /*
-                                       If block is not close, don't send it unless it is near
-                                       ground level.
-
-                                       Block is near ground level if night-time mesh
-                                       differs from day-time mesh.
-                               */
-                               if(d >= 4)
-                               {
-                                       if(block->getDayNightDiff() == false)
-                                               continue;
-                               }
                        }
 
                        /*
However, I'm not sure if we should just remove that piece of code. Some kind of an actual fix to it so that it would send ocean floors, but still not things that are very far in actual undeground, would be much better.

Another option of course would be to make the bottom of the skybox to be black. Then the blue sky wouldn't shine through like that. It might make more sense than making the server send pitch black blocks. Certainly it would have better performance at least.

Re: Setting absurdly long view range

Posted: Fri Oct 09, 2015 14:49
by OmniStudent
Thankyou, will try this in the weekend.

Re: Setting absurdly long view range

Posted: Sun Oct 11, 2015 14:51
by OmniStudent
Worked as you said!

Before:
Image
After (couldn't figure out where to change the view distance for this one, but nevermind) :
Image

Re: Setting absurdly long view range

Posted: Thu Oct 15, 2015 05:00
by Sokomine
The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?

Re: Setting absurdly long view range

Posted: Thu Oct 15, 2015 13:04
by jin_xi
Sokomine wrote:The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?
probably not, or at least not before 7 years down the road. Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them. important stuff, like hyphens in code, adding dead code, "better" solutions for the golden future (never used...) so PLS STOP MAKING SENSE. kthxbai

Re: Setting absurdly long view range

Posted: Thu Oct 15, 2015 13:45
by Don
jin_xi wrote:
Sokomine wrote:The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?
probably not, or at least not before 7 years down the road. Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them. important stuff, like hyphens in code, adding dead code, "better" solutions for the golden future (never used...) so PLS STOP MAKING SENSE. kthxbai
That's a bit harsh isn't it? Although I don't agree with some of the things that the dev team does I still appreciate all the work they do. Constructive criticism is good but what you said is nothing more than an insult. It is not productive and can cause harm.

Re: Setting absurdly long view range

Posted: Fri Oct 16, 2015 00:35
by Minerz
jin_xi wrote:
Sokomine wrote:The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?
probably not, or at least not before 7 years down the road. Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them. important stuff, like hyphens in code, adding dead code, "better" solutions for the golden future (never used...) so PLS STOP MAKING SENSE. kthxbai
Just sayin', that's rude. :(

Re: Setting absurdly long view range

Posted: Fri Oct 16, 2015 09:21
by Ferk
@jin_xi in the meantime you are busy not being helpful. The devs move at a prudent pace. They want to avoid implementing experimental things that will break stuff or affect performance. I don't think that kind of feedback will make devs listen to you, as it just gives the image of a naysayer.

Example of an attempt to give constructive feedback on this:

Since there's already code to check for farther away nodes, would it be possible to alter the way the water nodes in the frontier are rendered? I mean, somehow render the last water nodes of the far away frontier so that their faces are visible. If this is done only with liquids that are in the limits of the rendering it would look fine.

This way you wouldn't need to render the whole ocean floor nor would you have to find a way to make the sky change without making it look bad when you are flying above a singlenode mapgen world.

EDIT: ok, I just realized that the check is per-block not per-node (which makes sense). I guess it would be too much to affect the opacity of all the nodes in the block.

Is there a way to render the faces of the liquids when they are next to an "ignore" node? There's this related PR that adds faces for waving liquids, but not sure if it's helpful.

Re: Setting absurdly long view range

Posted: Sat Oct 17, 2015 22:51
by AccidentallyRhine
jin_xi wrote:
Sokomine wrote:The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?
probably not, or at least not before 7 years down the road. Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them. important stuff, like hyphens in code, adding dead code, "better" solutions for the golden future (never used...) so PLS STOP MAKING SENSE. kthxbai
It may be harsh, but it is true enough that the core developers are aware of the problem.

Re: Setting absurdly long view range

Posted: Sat Oct 17, 2015 23:17
by Don
AnxiousInfusion wrote:
jin_xi wrote:
Sokomine wrote:The second screenshot looks good. I sometimes fly around just to get the ocean floor covered. Can this be added at least as an option to the game?
probably not, or at least not before 7 years down the road. Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them. important stuff, like hyphens in code, adding dead code, "better" solutions for the golden future (never used...) so PLS STOP MAKING SENSE. kthxbai
It may be harsh, but it is true enough that the core developers are aware of the problem.
I was reading the irc log and saw a quick mention of it and then they go on to discuss things that matter. Your comment before stated "Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them". If you read through the whole page you can see that they are discussing more important things.
If the dev team was as ridiculous as you claim then we would not have any changes. Just look at the difference between 0.4.10 and the latest dev version and you will seen a huge difference.
Also, even if you was 100% correct, your comment does nothing to help. If you really think that the dev team is that bad then what should be done about it? Should we see if the dev team will have a conversation with you were you present your evidence that they are not doing what they should do? Maybe you could start a new tread that addresses this. You could lay out your argument and present your evidence and then ask the dev team if they would read it.
I know the dev team is not perfect. No one is. I do see the great things that they are doing though. For a free open source game I do believe that it is advancing nicely. Might not be advancing in the direction I would prefer but since I am not able to fork minetest and develop it in a different way I choose to be happy with what the dev team does. If I am not happy then I voice my opinion in a constructive way and hope that I am heard.

Re: Setting absurdly long view range

Posted: Sun Oct 18, 2015 00:44
by est31
@celeron55 there is an algorithm we could implement:
https://tomcc.github.io/2014/08/31/visibility-1.html

Re: Setting absurdly long view range

Posted: Sun Oct 18, 2015 04:34
by AccidentallyRhine
Don wrote: I was reading the irc log and saw a quick mention of it and then they go on to discuss things that matter. Your comment before stated "Devs are busy doing, then re-doing, then discussing various innoticeable changes and then scrapping them". If you read through the whole page you can see that they are discussing more important things.
If the dev team was as ridiculous as you claim then we would not have any changes. Just look at the difference between 0.4.10 and the latest dev version and you will seen a huge difference.
Also, even if you was 100% correct, your comment does nothing to help. If you really think that the dev team is that bad then what should be done about it? Should we see if the dev team will have a conversation with you were you present your evidence that they are not doing what they should do? Maybe you could start a new tread that addresses this. You could lay out your argument and present your evidence and then ask the dev team if they would read it.
I know the dev team is not perfect. No one is. I do see the great things that they are doing though. For a free open source game I do believe that it is advancing nicely. Might not be advancing in the direction I would prefer but since I am not able to fork minetest and develop it in a different way I choose to be happy with what the dev team does. If I am not happy then I voice my opinion in a constructive way and hope that I am heard.
I am not the same person who made the original comment. I do read through those pages each day and I was particularly happy to find talk of updating the encryption with TLS. Sokomine's criticism just made me think of that one part of yesterday's chat.

Re: Setting absurdly long view range

Posted: Sun Oct 18, 2015 11:57
by Don
Sorry. I should have read it better.

Re: Setting absurdly long view range

Posted: Fri Oct 23, 2015 03:55
by Sokomine
AnxiousInfusion wrote: Sokomine's criticism
It wasn't intended to be criticism. I just saw something that might be an improvement and became hopeful :-) There's usually quite a lot of work behind some things.