Crash server with sign (fix offer)

User avatar
bosapara
Member
 
Posts: 396
Joined: Fri Apr 07, 2017 08:49
GitHub: bosapara
In-game: Jozet

Crash server with sign (fix offer)

by bosapara » Mon Jan 07, 2019 06:23

Server can be crashed or lagged using long text with default sign

Image

One more problem - server log still accept a lot of trash from sign

fix for games\minetest_game\mods\default\nodes.lua

Code: Select all
local code = fields.text or "";
if string.len(code) > 1000 then
meta:set_string("text", "#SIGN: your text is too long, make it less")
meta:set_string("infotext", "#SIGN: your text is too long, make it less")
minetest.log("action", (player_name or "") .. " wrote is too long text" .. minetest.pos_to_string(pos))
return false
end
 

User avatar
TumeniNodes
Member
 
Posts: 2597
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: Crash server with sign (fix offer)

by TumeniNodes » Mon Jan 07, 2019 11:32

Feature freeze has begun but, as this is a fix, try throwing it up as a PR

I did not test or anything though.
I'm not your buddy, guy...
 

User avatar
sorcerykid
Member
 
Posts: 907
Joined: Fri Aug 26, 2016 15:36
Location: Illinois, USA
GitHub: sorcerykid
In-game: Nemo

Re: Crash server with sign (fix offer)

by sorcerykid » Mon Jan 07, 2019 13:05

I still they are still merging bug fixes, just not new features. And yeah, this looks to be a pretty serious issue. Def. going to patch this right away on my server.
 


Return to General Discussion



Who is online

Users browsing this forum: No registered users and 7 guests