Page 1 of 1

Crash server with sign (fix offer)

PostPosted: Mon Jan 07, 2019 06:23
by bosapara
Server can be crashed or lagged using long text with default sign

Image

One more problem - server log still accept a lot of trash from sign

fix for games\minetest_game\mods\default\nodes.lua

Code: Select all
local code = fields.text or "";
if string.len(code) > 1000 then
meta:set_string("text", "#SIGN: your text is too long, make it less")
meta:set_string("infotext", "#SIGN: your text is too long, make it less")
minetest.log("action", (player_name or "") .. " wrote is too long text" .. minetest.pos_to_string(pos))
return false
end

Re: Crash server with sign (fix offer)

PostPosted: Mon Jan 07, 2019 11:32
by TumeniNodes
Feature freeze has begun but, as this is a fix, try throwing it up as a PR

I did not test or anything though.

Re: Crash server with sign (fix offer)

PostPosted: Mon Jan 07, 2019 13:05
by sorcerykid
I still they are still merging bug fixes, just not new features. And yeah, this looks to be a pretty serious issue. Def. going to patch this right away on my server.

Re: Crash server with sign (fix offer)

PostPosted: Mon Feb 04, 2019 07:18
by sofar
Please open a github issue for this. This is serious enough and it will get fixed faster if you do. It is unlikely that the maintainers find bugreports on the forums. Especially this close to a major release.

Re: Crash server with sign (fix offer)

PostPosted: Tue Feb 05, 2019 05:38
by sofar