If this is about me specifically, I think I proved enough, but ok. And no, to be clear I'm not asking for any core role, already been there.
But they can self-assign them, yet they don't. Back to the Africa example
If this is about me specifically, I think I proved enough, but ok. And no, to be clear I'm not asking for any core role, already been there.
But they can self-assign them, yet they don't. Back to the Africa example
Yep, and only core devs can assign themselves. There should also be a normal way for contributors
Sure, we shouldn't close undone Issues with great Ideas!Zughy wrote: ↑Mon Oct 19, 2020 13:14Uhm, I don't think it's a good approach: I mean, if something is simply bad for the project, ok, let's close this, but if something is doable and no core dev has the interest to do it, I think it's fine to leave them there just in case someone else wants to take care of it. The important thing is stating the approval, a thing they could already do with the supported by core dev tag
Yep, I agree.Linuxdirk wrote: ↑Mon Oct 19, 2020 13:17PR reviews could be made faster by auto-linting it stead of playing ping-pong with the contributor figuratively one code line after another with a 2-3 days to weeks delay between each review. Not sure if Microsoft offers that on their GitHub platform but this should be part of every DevOps loop (either after plan or in code).
No it’s not, don’t worry. Enough is, what current core devs think is enough, I guess.
I prefer the volunteer fire department example: People volunteered to join them and if there is an emergency they simply can’t say “nah, now I’m not doing it because I am a volunteer and I decide what I do and when I do it”. So when you volunteer as a developer: same thing (slightly). You either do dev work when it’s needed, or you stop doing it altogether. It’s simple as that. But playing the “I aM a vOLuntEer” card every time there is work to do is just the wrong way. No mater how stupid the analogies are.
Please don't say that, it's simply not true. Basically the whole reason I became a core developer is to make them better, and a lot of progress is being made on a replacement. Just because I don't advertise it on Discord or display it on the forums doesn't mean it's not happening, just that it's not yet in a presentable state. I don't want to get false hopes up or to show something off too early.
I totally agree,v-rob wrote: ↑Mon Oct 19, 2020 16:59When it comes to creating features, I already have a full roadmap in place for what I want to work on. I have no problem with that whatsoever. I think that the real problem is I don't know where to focus when it comes to reviewing PRs. It's basically a find something that looks interesting and review it system. As a result, I don't especially feel like reviewing anything. What I really want to know is what to review. Maybe a queue for PRs that I should review (not made by me for myself, but by someone else) or something along those lines.
Ruben wants, v-rob wants, others don't. They're the only ones taking part to these topics, and I saw you linking this one in the IRC, and how they didn't consider you at all. Welcome aboard
So the older a PR gets the less interesting it is?
Here’s a task: Order the PR lists by age (descending) and start on top. Review the first 10 PRs :)
It is, unfortunately. A lot of awesome work was done, and formspecs are now a lot more consistent than before and are easier to style (no weird 3 decimals anymore! I just love it!). Still some imperfections and weird things (i.e. labels are measured from their center and not from ther top left corner like everything else, or – also labels: a newline being optically two newlines instead of one newline. But those are minor things) but overall much better.
Anything replacing formspecs will automatically be better :)
No, just less likely to be found.
The unfortunate thing is that most of those first 10 are in areas of the engine that I know nothing about. A queue would make things a lot simpler. Another problem is when to review. Since I'm working a lot on a formspec replacement, I don't want to review any formspec PRs (which are some of the few I can review) because it will all be replaced anyway and increase the compatibility layer that will need to be made, and searching through the large list of PRs to find ones I am able to review is exhausting. If there was a queue based partly on my opinion, partly on another person's, it would just be to work through those one at a time, no problem.
Have a look at viewtopic.php?p=382529#p382529 and the new linked draft PR I've been working on. That is what I hope is the future.
Users browsing this forum: No registered users and 13 guests