Page 8 of 13

Re: [OS X] Morn76's Yosemite builds

Posted: Mon Dec 22, 2014 17:01
by Joby
Interesting, I'll double check tonight when I get home, but I have not noticed jumping in any other program other than MT, and the 0.4.9 build I mentioned works flawlessly. I have a brand new MBP less than a month old. In the reddit thread it looks like people are having issue with the external Bluetooth track pad not the inbuilt one.

Re: [OS X] Morn76's Yosemite builds

Posted: Mon Dec 22, 2014 17:48
by Morn76
In the YouTube video I linked to it's the built-in trackpad that is causing problems. Apparently Yosemite and trackpads don't mix. :-)

Re: [OS X] Morn76's Yosemite builds

Posted: Tue Dec 23, 2014 02:35
by Joby
So I checked, my pointer scrolls fine on the desktop and all programs including the 0.4.9 version of MT Its definitely something that went into 0.4.10

extra info, the pointer seems fine in the main menu, only once in game does it start to freeze up, it will scroll a bit then lock up, then continue as if the thread is being paused for a split second.

I added the patch that you suggested but get the same black screen, I don't seem to be able to rebuild either, I have to rm the whole lot and start again, so I just added a line in your script to patch the files after it pulls and updates them.

Re: [OS X] Morn76's Yosemite builds

Posted: Tue Dec 23, 2014 03:21
by SAMIAMNOT
Morn76 wrote:In the YouTube video I linked to it's the built-in trackpad that is causing problems. Apparently Yosemite and trackpads don't mix. :-)
Yosemite sucks from what I hear. Some say it has a new component that drains RAM. (A reason for low FPS)

On the cursor issue, i meanthe bottom tip of the cursor. if the game freezes or i switch to another app, that happens. its only an issue when im in the inventory.

Re: [OS X] Morn76's Yosemite builds

Posted: Tue Dec 23, 2014 11:37
by Morn76
SAMIAMNOT wrote: Yosemite sucks from what I hear. Some say it has a new component that drains RAM. (A reason for low FPS)
Well, on my early-2013 MB the trackpad works fine in MT 0.4.10 under Yosemite, so I still think there must be a hardware side to this problem somehow. It looks like this bug only affects newer MBPs.
Joby wrote:so I just added a line in your script to patch the files after it pulls and updates them.
Yes, that's what I meant.

Re: [OS X] Morn76's Yosemite builds

Posted: Tue Dec 23, 2014 16:30
by Joby
So how do I go about debugging it? As I said I'm new to MT and OSX development, any pointers are appreciated otherwise you will find me Googling like a crazy person....

Re: [OS X] Morn76's Yosemite builds

Posted: Tue Dec 23, 2014 18:49
by Morn76
Finding out the bad commit by bisecting would be the next step I think. Of course if the last MT commit without trackpad problems is 0.4.9-something, there are quite a few versions to test.

If you apply these old patches from mtmake-osx to MT 0.4.9 (or other MT versions from before June 29, 2014), you should be able to build and test them.

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 06:30
by MinerDad
I have a MacBook Air so it isn't just MBPs

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 08:01
by MinerDad
I think I found the problematic commit: 1c21e391edeb7739935ca78250f066a60c369fc7 (https://github.com/minetest/minetest/co ... a60c369fc7). If I modify the make_mac.sh script to checkout that commit instead of master and modify src/irrlichttypes.h with the u64 patch (just move the #include <stdint.h> before the #include <irrTypes.h>), the weird trackpad issue shows up. If I grab the previous commit, 92981b2fee19fd04e2a49533ffa1f778bff6ca72, and do the same changes as above, I don't see the trackpad problem.

Joby, can you see if this commit also causes the problem for you?

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 09:17
by neoascetic
Recently I've made some fixes in minetest's package building system:
https://github.com/minetest/minetest/pull/1975

So now, "make package" simply works: as a result, you'll get ".dmg" file with minetest app bundle within. This let me create Homebrew formula (https://github.com/Homebrew/homebrew-ga ... inetest.rb), so if you use Homebrew, installing minetest (event the latest one) should be as simple as typing "brew install homebrew/games/minetest".

But let's return to ".dmg" file. There still exist an issue. Currently, minetest links with all dependencies dynamically, so you need to have them all installed on target system. Morn76's project fixes this by running "dylibbundler" to fix libraries paths. I think it would be nice to have minetest doing same staff out-of-box without need in external project. I. e. we still need to fix packaging for OSX with cmake's "fixup_bundle" or something similar.

@Morn76, what are your think on this? Would you like to make attempt to fix the issue?

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 10:58
by Morn76
neoascetic wrote:I think it would be nice to have minetest doing same staff out-of-box without need in external project. I. e. we still need to fix packaging for OSX with cmake's "fixup_bundle" or something similar.

@Morn76, what are your think on this? Would you like to make attempt to fix the issue?
I'm using a shell script because I could not figure out how to include all libs via cmake's packaging system, so I think you will have to fix this yourself. Personally I'm fine with my shell script, but Homebrew is a great option too of course.

Maybe we can have daily Travis builds for OS X then and get fewer nasty surprises like the u64 problem.
MinerDad wrote:I think I found the problematic commit: 1c21e391edeb7739935ca78250f066a60c369fc7 (https://github.com/minetest/minetest/co ... a60c369fc7). If I modify the make_mac.sh script to checkout that commit instead of master and modify src/irrlichttypes.h with the u64 patch (just move the #include <stdint.h> before the #include <irrTypes.h>), the weird trackpad issue shows up. If I grab the previous commit, 92981b2fee19fd04e2a49533ffa1f778bff6ca72, and do the same changes as above, I don't see the trackpad problem.
Looks pretty innocent, as it only seems to affect FPS limiting and double tap jumping. I think my frame rates are too low to require limiting (30–40 fps), so maybe that's why I don't see any problems on my MB but users with recent, more powerful machines do.

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 16:30
by Joby
neoascetic wrote:so if you use Homebrew, installing minetest (event the latest one) should be as simple as typing "brew install homebrew/games/minetest".
I tried this and it worked perfectly first time :) great work.

Whats even better is that its fixed my trackpad problem!! This is the first 0.4.10 build that I've been able to use with no trackpad issue. Would be interested to know if it fixes it for MinerDad too

Though I'd still like to know what the cause was...

Re: [OS X] Morn76's Yosemite builds

Posted: Wed Dec 24, 2014 19:17
by neoascetic
Morn76 wrote:Maybe we can have daily Travis builds for OS X then and get fewer nasty surprises like the u64 problem.
Currently travis does not support multi-os feature for builds, so I've made a simple alternative here: https://github.com/neoascetic/minetest/tree/travis-osx. Master branch is synchronized with that branch every 5 minutes (at this moment). If you are interested in failure notifications, feel free to send me your email, I'll add it to travis setup.

Re: [OS X] Morn76's Yosemite builds

Posted: Thu Dec 25, 2014 00:40
by Morn76
neoascetic wrote:
Morn76 wrote:Maybe we can have daily Travis builds for OS X then and get fewer nasty surprises like the u64 problem.
Currently travis does not support multi-os feature for builds, so I've made a simple alternative here: https://github.com/neoascetic/minetest/tree/travis-osx. Master branch is synchronized with that branch every 5 minutes (at this moment). If you are interested in failure notifications, feel free to send me your email, I'll add it to travis setup.
Excellent! How does this work exactly, e.g. is there a way to download these builds somewhere? If so I'd like to link to them from the first post in this thread.

If these builds had all optional features in terms of included subgames, Redis, FreeType, etc. of my builds and would be uploaded as nightlies somewhere, that would be a great alternative, especially if they also solve the mysterious trackpad issue that has been reported.

Re: [OS X] Morn76's Yosemite builds

Posted: Thu Dec 25, 2014 02:10
by MinerDad
Building with "make package" and running that build doesn't fix the trackpad issue for me.

I split the problematic commit into several parts: double tap, show_debug, and limitfps. The double tap change did not cause any problem but the show_debug and the limitfps changes did. My frame rates are always around 60fps so I would be affected by the limitfps. I don't know why the show_debug line is causing a problem.

Re: [OS X] Morn76's Yosemite builds

Posted: Thu Dec 25, 2014 05:24
by neoascetic
Morn76 wrote:Excellent! How does this work exactly, e.g. is there a way to download these builds somewhere? If so I'd like to link to them from the first post in this thread.
Currently these builds only for testing purposes, just to be sure that everything compiles well. The issue with dynamic linking is still need to be fixed, thus no, there is no way to download those builds.
Issue with trackpad was fixed probably because version from tag 0.4.10 was installed instead of latest master.

Re: [OS X] Morn76's Yosemite builds

Posted: Thu Dec 25, 2014 10:43
by Morn76
MinerDad wrote:Building with "make package" and running that build doesn't fix the trackpad issue for me.

I split the problematic commit into several parts: double tap, show_debug, and limitfps. The double tap change did not cause any problem but the show_debug and the limitfps changes did. My frame rates are always around 60fps so I would be affected by the limitfps. I don't know why the show_debug line is causing a problem.
Well, as the recent u64 issue showed, a Minetest commit can look perfectly harmless yet still trigger an obscure bug e.g. in an Irrlicht header file that causes problems.

What happens to your trackpad if you comment out the calls to limitFps()?
neoascetic wrote: Currently these builds only for testing purposes, just to be sure that everything compiles well. The issue with dynamic linking is still need to be fixed, thus no, there is no way to download those builds.
Aww. I hope we can get nightlies too like FlightGear at some point. But of course checking everything compiles is useful in itself.
neoascetic wrote: Issue with trackpad was fixed probably because version from tag 0.4.10 was installed instead of latest master.
Yes, that might be it. I'm not sure if Joby installed HEAD or stable.

P.S. Aha, if I run the Minimal Development Test game, I can hit 60 fps on Linux and Mac: no problems on Linux; stuck trackpad on the Mac.

Re: [OS X] Morn76's Yosemite builds

Posted: Thu Dec 25, 2014 13:25
by Morn76
New build: 20141224.3f83ca2 (0.4.11) with a patch for the trackpad bug. It's not a 100% perfect solution but it has to suffice for now. :-)

The mtmake-osx repo has also been updated.

Merry Christmas, everyone!

Re: [OS X] Morn76's Yosemite builds

Posted: Fri Dec 26, 2014 04:11
by Joby
Morn76 wrote: Yes, that might be it. I'm not sure if Joby installed HEAD or stable.
I used head, and the previous build Morn76 had uploaded, those both gave problems, whatever brew install gave me is the 0.4.10 that works perfectly, I guess that was stable.

I just tried the 0.4.11 build linked above and its a lot better trackpad wise but not perfectly smooth. Its totally playable now, but does stutter a little bit, where as the 0.4.9 build was smooth.

Thanks guys, and merry Christmas!!

Re: [OS X] Morn76's Yosemite builds

Posted: Fri Dec 26, 2014 12:04
by Morn76
Joby wrote: I just tried the 0.4.11 build linked above and its a lot better trackpad wise but not perfectly smooth. Its totally playable now, but does stutter a little bit, where as the 0.4.9 build was smooth.
Yes, this bug needs more investigation later on and a better fix/pull request. Which 0.4.9 build (downloaded from where; stable or git version) did you use by the way?

Re: [OS X] Morn76's Yosemite builds

Posted: Fri Dec 26, 2014 17:59
by Joby
Morn76 wrote: Yes, this bug needs more investigation later on and a better fix/pull request. Which 0.4.9 build (downloaded from where; stable or git version) did you use by the way?
Can't remember where I clicked the link but the file name is minetest-osx-bin-20140903.8948907-yosemite-v3.zip

Re: [OS X] Morn76's Yosemite builds

Posted: Fri Dec 26, 2014 18:56
by Morn76
Joby wrote:
Morn76 wrote: Yes, this bug needs more investigation later on and a better fix/pull request. Which 0.4.9 build (downloaded from where; stable or git version) did you use by the way?
Can't remember where I clicked the link but the file name is minetest-osx-bin-20140903.8948907-yosemite-v3.zip
OK, so this is a September 0.4.10-dev build then, not 0.4.9.

Re: [OS X] Morn76's Yosemite builds

Posted: Fri Dec 26, 2014 21:40
by Joby
oh sorry I could have sworn that 0.4.9 had shown in the top left, or is that how dev builds work, previous stable + commits

Re: [OS X] Morn76's Yosemite builds

Posted: Sat Dec 27, 2014 00:46
by Morn76
0.4.10 was released in July, so it should say 0.4.10-X-Y, where X is the number of commits since the commit tagged as 0.4.10 and Y is the truncated git commit hash.

Re: [OS X] Morn76's Yosemite builds

Posted: Sun Dec 28, 2014 05:40
by Joby
Sorry I could have swan it said 0.4.9 I just checked, its 0.4.10-74-g8948907 maybe I was getting mixed up with the server version that was running at the time.