error determining biome name

[PolySaken]

I'm trying to use the current biome name for each player to determine what effects to apply, but either minetest.get_biome_data(pos) or minetest.get_biome_name(biome_data) is not working correctly.

(the full code)

Code: Select all

local biome=""
		
		local bname=minetest.get_biome_name(minetest.get_biome_data(player:get_pos())["biome"])
		print(bname)
		if string.find(bname, "%_") then
			local sbname = string.split(bname, "_")
			biome=sbname[1]
			print(1)
		else
			biome=bname
			print(2)
		end
		print(biome)

I'm getting the wrong output in the console for the biome i'm in.
For example: in the biome "plains", the code returns the biome name "jungle". does anyone know why this is happening.

(If this is just ambiguity about biome limits, could anyone recommend a better way to find the current biome?)

[duane]

I'm trying to use the current biome name for each player to determine what effects to apply, but either minetest.get_biome_data(pos) or minetest.get_biome_name(biome_data) is not working correctly.

Have you tried flooring the pos data? I don't remember offhand whether getpos returns float or integer data. Maybe get_biome_data expects integers.

[Termos]

I'm pretty sure get_biome_data doesn't care about integers.
Maybe it's because player pos is one or two nodes away from the node he's standing on.
I'd try offsetting pos.y by players collisionbox[2] - 0.01

[PolySaken]

I'm pretty sure get_biome_data doesn't care about integers.
Maybe it's because player pos is one or two nodes away from the node he's standing on.
I'd try offsetting pos.y by players collisionbox[2] - 0.01

I'll give this a try.

[duane]

I'm pretty sure get_biome_data doesn't care about integers.
Maybe it's because player pos is one or two nodes away from the node he's standing on.
I'd try offsetting pos.y by players collisionbox[2] - 0.01

As far as I know, biomes are still two-dimensional.

[Termos]

That would make underground biomes impossible.
They're 3d, but yeah, on the surface they're 2d-ish, at least in MTG.

OP seems to be using a different game though.

[ShadMOrdre]

Biomes are 2-D. This is why you cannot stack biomes.

[Termos]

Sorry, disregard what I said then.
I'm definitely getting different biome ids for different y coords in the same xz column, but probably I'm missing something.

[paramat]

Should it be:

Code: Select all

local bname=minetest.get_biome_name(minetest.get_biome_data(player:get_pos()).biome)

.biome
instead of
["biome"]
?

Biomes are 3D and they are stacked in MTG. It is only heat and humidity noises that are 2D.

[PolySaken]

Nothing seems to be working. I think the problem is with the borders of biomes not being cleanly defined. sometimes it's right, sometimes wrong, depending on the biome being entered and the one being left.

[Termos]

How do you determine which biome is 'right', anyway?

[PolySaken]

How do you determine which biome is 'right', anyway?

The one It looks like the player is in.

[Termos]

Ok, eyeballing may not be 100% reliable but should be good enough.

I've tested it myself, in vanilla MTG with carpathian mapgen the return of get_biome_data seems 100% exact so far, it works even for 1x1 biome blend inclusions.
Maybe it's the game/mod you're using. If any voxel manipulation is being done, that's probably the cause.

My test:

Code: Select all

minetest.register_on_chat_message(
	function(name, message)
		if message == 'doit' then
			local plyr = minetest.get_player_by_name(name)
			local pos = plyr:get_pos()
			pos.y = pos.y-0.01
			minetest.chat_send_all(minetest.get_biome_name(minetest.get_biome_data(pos).biome))
		end
	end
)

[PolySaken]

Ok, eyeballing may not be 100% reliable but should be good enough.

I've tested it myself, in vanilla MTG with carpathian mapgen the return of get_biome_data seems 100% exact so far, it works even for 1x1 biome blend inclusions.
Maybe it's the game/mod you're using. If any voxel manipulation is being done, that's probably the cause.

My test:

Code: Select all

minetest.register_on_chat_message(
	function(name, message)
		if message == 'doit' then
			local plyr = minetest.get_player_by_name(name)
			local pos = plyr:get_pos()
			pos.y = pos.y-0.01
			minetest.chat_send_all(minetest.get_biome_name(minetest.get_biome_data(pos).biome))
		end
	end
)

I tried modifying the y pos by -0.01 but it didn't change much. I think I'll just rewrite it all.