Confirmation dialog on new player registration

[srifqi]

Before, Minetest has no difference in interaction between login and register. Both are the same, because registration happens automatically in the background. This can lead to new player confusion. See Issue #258 and Issue #3167.

So, as of 13 January 2018, a cofirmation dialog is added for non-singleplayer game. (Pull Request #6849)

I got a report from another player that they can't register because they actually didn't enter a password in password field. EDIT: It's not like what I thought. They can, just press the button and leave the textbox empty as before.

Spoiler

My question is, how is it? What's missing from it? How is the text and interaction inside it? How should it take care of empty password?

Thank you for your inputs!

[sofar]

File a bug, title: "password confirmation doesn't verify password matches with previously entered password"

(I didn't read the code, but that's what I assume is going wrong here)

[jas]

I haven't updated this server in some time, so hopefully there were no new commits regarding this new feature since I last did. It's on 70a90bc8.

I hope I was this other player, because I simply commented on the PR and its commit. I was able to login fine, after clicking Register and Join, leaving the password text box empty. It took me a while, and I was surprised -- mostly, because this is what I saw:


I was simply frustrated that a previously known behavior had changed -- I don't use password on test servers. And I don't restrict clients connecting because they neglected to secure their account.

My suggestion is to keep doing you, dude, good feature!

[jas]

Here's the comment I made on the commit: https://github.com/minetest/minetest/co ... t-27010195

I thought I made another comment on the PR, but I can't find it and forget now what it was. Here's me complaining about the UI: https://github.com/minetest/minetest/pu ... -357518536

I do maintain that this text is too verbose, and that it _could_ be reduced. However, it's simply not worth too much thought and energy, it's a good feature.

"You are about to join the server for the first time, confirm your password. (TEXTBOX) [OK] [CANCEL]"

[srifqi]

Thanks for the feedbacks.

First, I thought the player cannot register. But they actually can, just press the button and leave thr textbox empty as before.

I have no idea. Probably add special case for empty password?

For the information text, we'll wait for other user to comment on this.

[jas]

Yes, it's not a worry.

My revised suggestion: "You are about to join {server} with {name} for the first time, please confirm your password." (TEXTBOX) (OK) (Cancel)

[sorcerykid]

I've always wondered why the text is so verbose as well. I would think it could be straightforward: "A player account named 'testplayer' was not found on this server. Are you sure that you want to join 'My Great Server' as a new player?" with a "Yes" and a "No" button.

[Wuzzy]

Bug:
https://github.com/minetest/minetest/issues/7022