[Opinions Needed] Darker ambient occlusion values?

Post Reply

Do darker/more obvious AO values look better or worse?

Better
8
42%
Worse
1
5%
Yes, but it needs some tweaking
8
42%
No real difference
2
11%
 
Total votes: 19

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

[Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

Hey guys, it's me again. I've been quite busy recently and still don't really have time for Minetest.
I fired it up for the first time in ages a bit ago, and was shocked at how (I don't know, plastic?) the world felt.

From my experience, ambient occlusion greatly affects the level of realism of a 3D scene, so I played around with the values in mapblock_mesh.cpp until I found something that seemed to look nice.

In my opinion, this really enhances the vibrancy of the scene. Thoughts?
Do you guys think this looks better or worse?

Screenshot with default values:
Image
Screenshot with modified values:
Image
To play with it yourself, replace line 294 in mapblock_mesh.cpp with this and recompile:
Note, this value is a ballpark estimate, and is quite subject to change.

Code: Select all

	static const float light_amount[4] = { 0.6, 0.5, 0.3, 0.0 };
(Sorry, had to use a different image hosting site. China now blocks mediacru.sh. :/)
Attachments
screenshot_3647419891.png
(407.99 KiB) Not downloaded yet
screenshot_3647476750.png
(409.06 KiB) Not downloaded yet
Last edited by TriBlade9 on Mon Jan 12, 2015 00:18, edited 5 times in total.

User avatar
rubenwardy
Moderator
Posts: 6455
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by rubenwardy » Post

You need to link directly to the image, you're linking to an page with the image on it.

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

rubenwardy wrote:You need to link directly to the image, you're linking to an page with the image on it.
From here, those are direct links and are working fine. What do you see?

User avatar
rubenwardy
Moderator
Posts: 6455
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by rubenwardy » Post


TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

rubenwardy wrote:You linked to http://postimg.org/image/vyqmkzdrn/ instead of http://s13.postimg.org/s2daozss7/screen ... 476750.png
I just see crosses.
That's strange, there seems to be some sort of URL filtering then. The actual link I posted is http://s13.postimg.org/3ymj0pab9/screen ... 476750.png

I'll try a different site.

User avatar
rubenwardy
Moderator
Posts: 6455
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by rubenwardy » Post

Just uploading as attachments. That redirects, too.

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

rubenwardy wrote:Just uploading as attachments. That redirects, too.
Ah right, thanks.
</offtopic>

Also, please note that the code used was quite hacky and looks bad in pretty much every situation except daylight.

User avatar
Krock
Developer
Posts: 4602
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker
Location: Switzerland
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by Krock » Post

Impressive. I like this change.
Look, I programmed a bug for you. >> Mod Search Engine << - Mods by Krock - DuckDuckGo mod search bang: !mtmod <keyword here>

User avatar
rubenwardy
Moderator
Posts: 6455
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy
Location: United Kingdom
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by rubenwardy » Post

Darker shadows? It does look better. With dynamic shadows, it will look even cooler.

User avatar
Kenney
Member
Posts: 131
Joined: Fri Jan 02, 2015 12:12
In-game: Kenney

Re: [Opinions Needed] Darker ambient occlusion values?

by Kenney » Post

I like it! +1
Games:
Voxus | UFO Race

User avatar
Calinou
Moderator
Posts: 3166
Joined: Mon Aug 01, 2011 14:26
GitHub: Calinou
IRC: Calinou
In-game: Calinou
Location: Troyes, France
Contact:

Re: [Opinions Needed] Darker ambient occlusion values?

by Calinou » Post

Ideally, ambient occlusion strength should be configurable. The default value should probably be slightly higher than what we currently have.

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

Calinou wrote:Ideally, ambient occlusion strength should be configurable. The default value should probably be slightly higher than what we currently have.
That's a neat idea, perhaps subgames could modify it in their configuration files. That would probably help give each game a sort of feel.

However, first someone has to figure out/rewrite the current system. I still can't wrap my head around how it works exactly, or how to fix the issues with caves and water and such.

EDIT: So this line apparently affects darkness well, but it looks like someone tweaked it to be very exact. Any info?

Code: Select all

		//table of precalculated gamma space multiply factors
		//light^2.2 * factor (0.75, 0.5, 0.25, 0.0), so table holds factor ^ (1 / 2.2)
		static const float light_amount[4] = { 0.877424315, 0.729740053, 0.532520545, 0.0 };
I've updated the main post with a modification to the light_amount array, which looks roughly the same, but works perfectly underwater and in caves.

Code: Select all

		static const float light_amount[4] = { 0.6, 0.5, 0.3, 0.0 };
Now to make it configurable...

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

This has been added to the main game, with a lot of tweaks. See the setting "ambient_occlusion_gamma".

User avatar
Napiophelios
Member
Posts: 1028
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Opinions Needed] Darker ambient occlusion values?

by Napiophelios » Post

Well I am the goon who voted "No real difference",
but I am half blind and using a tiny computer and from the screen shots
I really didnt see much of a difference.

But man in game it looks awesome, good job TriBlade9.
Its the little things you know :)

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

Napiophelios wrote:Well I am the goon who voted "No real difference",
but I am half blind and using a tiny computer and from the screen shots
I really didnt see much of a difference.

But man in game it looks awesome, good job TriBlade9.
Its the little things you know :)
No problem, glad you like it!
Just out of curiosity, what values are you using?

User avatar
Napiophelios
Member
Posts: 1028
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Opinions Needed] Darker ambient occlusion values?

by Napiophelios » Post

Whatever Krock has as the default in his latest build;
(If I dont understand something,I try not to mess with it)

Its really noticeable effect when viewing things from high altitudes

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

Napiophelios wrote:Whatever Krock has as the default in his latest build;
(If I dont understand something,I try not to mess with it)

Its really noticeable effect when viewing things from high altitudes
Strange, in the latest builds the default is exactly the same as previously. (Should be anyways)

User avatar
Napiophelios
Member
Posts: 1028
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Opinions Needed] Darker ambient occlusion values?

by Napiophelios » Post

I dont know but when you fly around the landscape kinda shimmers, especially tree leaves
Its kinda weird lookin but neat.

Does #display_gamma = 1.8 have anything to do with it?
I might be remarking on something entirely different,
I thought this (darker ambient occlusion) was the change that was having the effect

edit:
okay,I found it; I am using
ambient_occlusion_gamma=1.2
display_gamma = 2.4

But I changed texture packs and it looks very different now,
going back to using SummerfieldsTP it looks better.

TriBlade9
Member
Posts: 89
Joined: Fri Sep 05, 2014 09:35

Re: [Opinions Needed] Darker ambient occlusion values?

by TriBlade9 » Post

Napiophelios wrote:I dont know but when you fly around the landscape kinda shimmers, especially tree leaves
Its kinda weird lookin but neat.

Does #display_gamma = 1.8 have anything to do with it?
I might be remarking on something entirely different,
I thought this (darker ambient occlusion) was the change that was having the effect

edit:
okay,I found it; I am using
ambient_occlusion_gamma=1.2
display_gamma = 2.4

But I changed texture packs and it looks very different now,
going back to using SummerfieldsTP it looks better.
Ah okay, you are indeed using a darker ambient_occlusion_gamma value. (default is 2.2)

User avatar
Napiophelios
Member
Posts: 1028
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: [Opinions Needed] Darker ambient occlusion values?

by Napiophelios » Post

Well night time and dark places in general really seem dark now;
I dont know if these settings have anything to do with it,or maybe just the 0411 update,
but I dont get all the little white lines every where any more when I go into a cave.
Black looks black now.

Zeno
Member
Posts: 140
Joined: Sun Jun 29, 2014 03:36
GitHub: Zeno-
Location: Australia

Re: [Opinions Needed] Darker ambient occlusion values?

by Zeno » Post

Napiophelios wrote:Well night time and dark places in general really seem dark now;
You can change display_gamma to a lower value for brighter nights depending on your monitor. E.g. I use display_gamma = 1.5

The default is display_gamma = 1.8 and this gives the exact same brightness values as version 0.4.10 of minetest

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest