Minetest Forums

No. I'm voting no. We have apple trees with the More-Trees mod, there is no point in making more.

TenPlus1 wrote:The default tree in minetest IS an apple tree, some spawn randomly with fruit while others do not...

though it was an oak........

If the “default” tree is supposed to be an apple tree, why not simply renaming the nodes?

- “Tree” → “Apple Tree” (actually should be “Apple tree trunk” but for some reason tree trunks are called “trees” in Minetest Game)
- “Leaves” → “Apple Tree Leaves”
and so on.

It is being frequently states that the default trees are apple trees. However, they are not named/id'd as such - the tree trunk is default:tree and the leaves are default:leaves. If they are truly supposed to be apple trees, it would make sense that the nodes are id'd default:tree_apple and default:leaves_apple or something like that.

I am working on a mod which adds different types of tool handles (but it isn't the main feature) - I call the handle made with default:wood "toolhandle_applewood", which when observed does not make sense because the names of default:tree and default:leaves are just "Tree" and "Leaves", respectively. If they are truly supposed to be apple trees, the names should reflect that, but currently they do not. So, either apples need to be moved to a new tree that is actually called "Apple" outside of a single-line comment somewhere in the code, and the "regular" trees left without apples, - or, the nodes need to be re-id'd and re-named such that they are default:tree_apple and default:leaves_apple, and the names being "Apple Tree" and "Apple Leaves" respectively.

Leaving it the way it is now is wrong, because the current implementation is self-contradictory, even without the mod I am working on. If nothing is done, it will continue to be wrong.

Don't say that renaming the nodes will cause problems - that's what minetest.register_alias() is for.

EDIT:

Wuzzy wrote:If the “default” tree is supposed to be an apple tree, why not simply renaming the nodes?

- “Tree” → “Apple Tree” (actually should be “Apple tree trunk” but for some reason tree trunks are called “trees” in Minetest Game)
- “Leaves” → “Apple Tree Leaves”
and so on.

I didn't see this one yet, that basically sums up what I just said, except for the part about tool handles and the part about leaving "regular trees" without apples

Perhaps they were not changed because until recently trees were either spawned with apples to be appletrees or spawned without to be some generic tree. In mgv6 there are 2 noises: 'trees' and 'apple trees' suggesting only some are actually appletrees.

Now there's a good case for renaming, but might not be worth the breakage.
The generic 'tree' nodes may be in use for other types of tree.

paramat wrote:Perhaps they were not changed because until recently trees were either spawned with apples to be appletrees or spawned without to be some generic tree. In mgv6 there are 2 noises: 'trees' and 'apple trees' suggesting only some are actually appletrees.

Now there's a good case for renaming, but might not be worth the breakage.
The generic 'tree' nodes may be in use for other types of tree.

Then we can leave the generic "tree" nodes as just generic tree nodes, and make a new set of nodes for the apple trees, and then have mapgen use the apple tree nodes for all new apple trees. That way, old mods using the generic tree nodes for other trees are not broken, and apple trees have distinct wood/leaves/saplings.

I am making a mod which adds tools made with different handle materials, including several types of wood and some different metals and alloys. Currently there are "apple wood" and "jungle wood" handles of the wood variety, but since generic tree wood isn't apple wood, I am stuck with naming the tool handle made of generic wood (description name), because it has to be something other than just "wood" or the less desirable "generic wood" (for example, you have "Jungle Wood Tool Handle" and "Acacia Wood Tool Handle", but "Generic Wood Tool Handle" or just "Wood Tool Handle" doesn't make sense with them); but if we call it "Oak Wood", then all of the old mods that use generic wood for banana trees and orange trees (and such) will make the players think like "lol I just made an oak wood tool handle out of banana tree wood, what a dumb mod" or something.