[shaders]Bloom + Better Light
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
OKAY ! Invitation : https://github.com/appgurueu/new-shaders/invitations
Re: [shaders]Bloom + Better Light
I'm in! Thanks, LMD.
Alright folks, wish list time for shaders. Colored lights, speed, super fancy psychedelic rainbows, have at it. I can promise that 99% of it won't be worked on. But it will really help set priorities.
The goal will be get it into the main Minetest branch so a history of well tested, stable, and documented code is needed. It also has to make the game better for all players, not just those who want to enable fancy graphics.
Alright folks, wish list time for shaders. Colored lights, speed, super fancy psychedelic rainbows, have at it. I can promise that 99% of it won't be worked on. But it will really help set priorities.
The goal will be get it into the main Minetest branch so a history of well tested, stable, and documented code is needed. It also has to make the game better for all players, not just those who want to enable fancy graphics.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
shaders are good and all, Skulls and LMD, but you guys are still going to need the minetest client to have the features necessary.
however there are two PR's that implement everything that is necessary:
however there are two PR's that implement everything that is necessary:
I don't make messes, I just, er...disturb the local entropy!
-
- Member
- Posts: 818
- Joined: Tue Apr 14, 2015 01:59
- GitHub: raymoo
- IRC: Hijiri
- In-game: Raymoo + Clownpiece
Re: [shaders]Bloom + Better Light
For lighting with lots of light sources, you could look into light cuts.
Every time a mod API is left undocumented, a koala dies.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
what do you mean light cuts?
I don't make messes, I just, er...disturb the local entropy!
-
- Member
- Posts: 818
- Joined: Tue Apr 14, 2015 01:59
- GitHub: raymoo
- IRC: Hijiri
- In-game: Raymoo + Clownpiece
Re: [shaders]Bloom + Better Light
http://www.graphics.cornell.edu/~bjw/lightcuts.pdfThomasMonroe wrote:what do you mean light cuts?
Every time a mod API is left undocumented, a koala dies.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
hmm that seems to be for rendering a photo-realistic scene rather than a game scene
I don't make messes, I just, er...disturb the local entropy!
-
- Member
- Posts: 818
- Joined: Tue Apr 14, 2015 01:59
- GitHub: raymoo
- IRC: Hijiri
- In-game: Raymoo + Clownpiece
Re: [shaders]Bloom + Better Light
I don't see why it couldn't be used for Minetest's light levels, since it doesn't seem like lightcuts are that expensive to compute, and Minetest's lighting doesn't change that frequently. The core of the paper is just an algorithm that approximates a bunch of point lights using less lights.ThomasMonroe wrote:hmm that seems to be for rendering a photo-realistic scene rather than a game scene
Every time a mod API is left undocumented, a koala dies.
Re: [shaders]Bloom + Better Light
Sweet, thank you. LMD, lets pull this into a branch and start poking around. Still need to do the testing and boring bits.ThomasMonroe wrote:shaders are good and all, Skulls and LMD, but you guys are still going to need the minetest client to have the features necessary.
however there are two PR's that implement everything that is necessary:
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
kilbith's PR still has work to be done with it though
I don't make messes, I just, er...disturb the local entropy!
Re: [shaders]Bloom + Better Light
Moar shaders I stumbled across, for the curious: https://github.com/armory3d/armory/tree/master/Shaders
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
Post processing is pretty nice, and not much work to implement, as theres already the mentioned base. Here is a good point to start. https://github.com/minetest/minetest/pu ... a8fc8c0be1
EDIT :
Skulls, I need your help. How can I fork this PR ?
EDIT :
Skulls, I need your help. How can I fork this PR ?
Re: [shaders]Bloom + Better Light
I can't figure out how to do that using the GitHub web interface but if you clone numberZero's repo, switch to the dev-postprocessing branch you should get there. This will have to be done on your local drive.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
Skulls..most of the shaders you have found may not be able to be implemented due to the client, however they will be very instructive.
I don't make messes, I just, er...disturb the local entropy!
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
Based on numberZero's impressive work :
https://github.com/appgurueu/new-shader ... gment.glsl
Edge darkening
Focus blur
Thanks alot, numberZero !
EDIT : TESTERS REQUIRED !
If you want to test the new post-processing :
- compile numberZero's minetest fork with post-processing
- replace opengl_fragment.glsl in client/shaders/post-processing with my version.
- you may also replace opengl_vertex.glsl, but this is not necessary.
azekill_DIABLO : Je pense que tu es un personne qui a plein d'experience avec "compiling Minetest" et que tu peux faire ca tres bien, et je crois que tu aimes essayer des nouvelle choses le plus de tout la monde. Est-ce que tu es d'accord ?
PS : J'apprends le francais depuis 2 ans a mon ecole.
Et je sais que je n'ai pas utilise des accents, c'est parce-que ca n'est pas facile avec la clavier de mon ordinateur allemand.
Any feedback ?
https://github.com/appgurueu/new-shader ... gment.glsl
Edge darkening
Focus blur
Thanks alot, numberZero !
EDIT : TESTERS REQUIRED !
If you want to test the new post-processing :
- compile numberZero's minetest fork with post-processing
- replace opengl_fragment.glsl in client/shaders/post-processing with my version.
- you may also replace opengl_vertex.glsl, but this is not necessary.
azekill_DIABLO : Je pense que tu es un personne qui a plein d'experience avec "compiling Minetest" et que tu peux faire ca tres bien, et je crois que tu aimes essayer des nouvelle choses le plus de tout la monde. Est-ce que tu es d'accord ?
PS : J'apprends le francais depuis 2 ans a mon ecole.
Et je sais que je n'ai pas utilise des accents, c'est parce-que ca n'est pas facile avec la clavier de mon ordinateur allemand.
Any feedback ?
Last edited by LMD on Wed Jan 03, 2018 14:19, edited 2 times in total.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
it seems that all of the rendering code was rearranged and better organized, so numberZero's work is no longer valid and needs to be re-done with the new rendering implementation.
I don't make messes, I just, er...disturb the local entropy!
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
The only word that fits well now has 4 letters and starts with s.
Guess what ?
Guess what ?
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
Sorry, I don't have enough C++ knowledge to implement this yet, however you could search around and try to find someone willing to pick it up.
I don't make messes, I just, er...disturb the local entropy!
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
Anyway, we can test the shaders with his Minetest fork.
- LMD
- Member
- Posts: 1400
- Joined: Sat Apr 08, 2017 08:16
- GitHub: appgurueu
- IRC: appguru[eu]
- In-game: LMD
- Location: Germany
- Contact:
Re: [shaders]Bloom + Better Light
I have ANSI C99 experience. And Java experience. Equation : C99+Java = C++
But I have no MT experience. ß((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((
We need a core developer.
But I have no MT experience. ß((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((
We need a core developer.
- azekill_DIABLO
- Member
- Posts: 7507
- Joined: Wed Oct 29, 2014 20:05
- GitHub: azekillDIABLO
- In-game: azekill_DIABLO
- Location: OMICRON
- Contact:
Re: [shaders]Bloom + Better Light
mmm... ask paramat maybe.
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!
DMs are always open if you want to get in touch!
- rubenwardy
- Moderator
- Posts: 6978
- Joined: Tue Jun 12, 2012 18:11
- GitHub: rubenwardy
- IRC: rubenwardy
- In-game: rubenwardy
- Location: Bristol, United Kingdom
- Contact:
Re: [shaders]Bloom + Better Light
I doubt you'll get much help from paramat. numberZero or lhofhansl would be more likely to be able to help you.
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
yeah paramat isn't much into eye-candy/graphics, he's more of a MT mechanic than anything else
I don't make messes, I just, er...disturb the local entropy!
- TumeniNodes
- Member
- Posts: 2943
- Joined: Fri Feb 26, 2016 19:49
- GitHub: TumeniNodes
- IRC: tumeninodes
- In-game: TumeniNodes
- Location: in the dark recesses of the mind
- Contact:
Re: [shaders]Bloom + Better Light
Working with shaders is not an easy task..., by any means.ThomasMonroe wrote:yeah paramat isn't much into eye-candy/graphics, he's more of a MT mechanic than anything else
It's not so much that he isn't into eye candy, I would say more like not experienced in that area..., same goes for the rest of the devs or, I assure you..., there would be more to offer by now.
And it is not very easy to find individuals who are, who would be willing or available (time wise) to work on it for free.
A Wonderful World
- ThomasMonroe
- Member
- Posts: 286
- Joined: Tue Apr 04, 2017 16:21
- GitHub: ThomasMonroe314
- IRC: ThomasMonroe TMcSquared
- In-game: ThomasMonroe TMcSquared
- Location: Wherever I am at
Re: [shaders]Bloom + Better Light
touche
however paramat has said on multiple occasions that he is not a big fan of eye-candy. But like you said, that doesn't mean anything, all it takes is someone experienced in shaders.
however paramat has said on multiple occasions that he is not a big fan of eye-candy. But like you said, that doesn't mean anything, all it takes is someone experienced in shaders.
I don't make messes, I just, er...disturb the local entropy!
Who is online
Users browsing this forum: No registered users and 9 guests