[shaders]Bloom + Better Light

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo
 

Skulls
Member
 
Posts: 78
Joined: Thu Dec 21, 2017 17:41
In-game: Skulls

Re: [shaders]Bloom + Better Light

by Skulls » Thu Dec 28, 2017 19:08

I'm in! Thanks, LMD.

Alright folks, wish list time for shaders. Colored lights, speed, super fancy psychedelic rainbows, have at it. I can promise that 99% of it won't be worked on. But it will really help set priorities.

The goal will be get it into the main Minetest branch so a history of well tested, stable, and documented code is needed. It also has to make the game better for all players, not just those who want to enable fancy graphics.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Thu Dec 28, 2017 23:42

shaders are good and all, Skulls and LMD, but you guys are still going to need the minetest client to have the features necessary.
however there are two PR's that implement everything that is necessary:
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

Byakuren
Member
 
Posts: 809
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [shaders]Bloom + Better Light

by Byakuren » Thu Dec 28, 2017 23:51

For lighting with lots of light sources, you could look into light cuts.
Every time a mod API is left undocumented, a koala dies.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Fri Dec 29, 2017 04:01

what do you mean light cuts?
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

Byakuren
Member
 
Posts: 809
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [shaders]Bloom + Better Light

by Byakuren » Fri Dec 29, 2017 04:37

ThomasMonroe wrote:what do you mean light cuts?

http://www.graphics.cornell.edu/~bjw/lightcuts.pdf
Every time a mod API is left undocumented, a koala dies.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Fri Dec 29, 2017 12:40

hmm that seems to be for rendering a photo-realistic scene rather than a game scene
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

Byakuren
Member
 
Posts: 809
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri
In-game: Raymoo + Clownpiece

Re: [shaders]Bloom + Better Light

by Byakuren » Fri Dec 29, 2017 16:44

ThomasMonroe wrote:hmm that seems to be for rendering a photo-realistic scene rather than a game scene

I don't see why it couldn't be used for Minetest's light levels, since it doesn't seem like lightcuts are that expensive to compute, and Minetest's lighting doesn't change that frequently. The core of the paper is just an algorithm that approximates a bunch of point lights using less lights.
Every time a mod API is left undocumented, a koala dies.
 

Skulls
Member
 
Posts: 78
Joined: Thu Dec 21, 2017 17:41
In-game: Skulls

Re: [shaders]Bloom + Better Light

by Skulls » Fri Dec 29, 2017 18:02

ThomasMonroe wrote:shaders are good and all, Skulls and LMD, but you guys are still going to need the minetest client to have the features necessary.
however there are two PR's that implement everything that is necessary:


Sweet, thank you. LMD, lets pull this into a branch and start poking around. Still need to do the testing and boring bits.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Fri Dec 29, 2017 19:56

kilbith's PR still has work to be done with it though
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

Skulls
Member
 
Posts: 78
Joined: Thu Dec 21, 2017 17:41
In-game: Skulls
 

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo

Re: [shaders]Bloom + Better Light

by LMD » Sun Dec 31, 2017 16:13

Post processing is pretty nice, and not much work to implement, as theres already the mentioned base. Here is a good point to start. https://github.com/minetest/minetest/pu ... a8fc8c0be1

EDIT :
Skulls, I need your help. How can I fork this PR ?
Magic-CTF(soon)MTPCFractal-SuiteModel Creator Schematic CreatorColorfulXmas BallsWebsite • Never judge me by my age
 

Skulls
Member
 
Posts: 78
Joined: Thu Dec 21, 2017 17:41
In-game: Skulls

Re: [shaders]Bloom + Better Light

by Skulls » Sun Dec 31, 2017 21:38

I can't figure out how to do that using the GitHub web interface but if you clone numberZero's repo, switch to the dev-postprocessing branch you should get there. This will have to be done on your local drive.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Sun Dec 31, 2017 22:44

Skulls..most of the shaders you have found may not be able to be implemented due to the client, however they will be very instructive.
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo

Re: [shaders]Bloom + Better Light

by LMD » Wed Jan 03, 2018 14:08

Based on numberZero's impressive work :
https://github.com/appgurueu/new-shader ... gment.glsl
Edge darkening
Focus blur
Thanks alot, numberZero !
EDIT : TESTERS REQUIRED !
If you want to test the new post-processing :
- compile numberZero's minetest fork with post-processing
- replace opengl_fragment.glsl in client/shaders/post-processing with my version.
- you may also replace opengl_vertex.glsl, but this is not necessary.
azekill_DIABLO : Je pense que tu es un personne qui a plein d'experience avec "compiling Minetest" et que tu peux faire ca tres bien, et je crois que tu aimes essayer des nouvelle choses le plus de tout la monde. Est-ce que tu es d'accord ?
PS : J'apprends le francais depuis 2 ans a mon ecole.
Et je sais que je n'ai pas utilise des accents, c'est parce-que ca n'est pas facile avec la clavier de mon ordinateur allemand.
Any feedback ?
Last edited by LMD on Wed Jan 03, 2018 14:19, edited 2 times in total.
Magic-CTF(soon)MTPCFractal-SuiteModel Creator Schematic CreatorColorfulXmas BallsWebsite • Never judge me by my age
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Wed Jan 03, 2018 14:18

it seems that all of the rendering code was rearranged and better organized, so numberZero's work is no longer valid and needs to be re-done with the new rendering implementation.
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo

Re: [shaders]Bloom + Better Light

by LMD » Wed Jan 03, 2018 14:21

The only word that fits well now has 4 letters and starts with s.
Guess what ?
Magic-CTF(soon)MTPCFractal-SuiteModel Creator Schematic CreatorColorfulXmas BallsWebsite • Never judge me by my age
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Wed Jan 03, 2018 14:26

Sorry, I don't have enough C++ knowledge to implement this yet, however you could search around and try to find someone willing to pick it up.
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo

Re: [shaders]Bloom + Better Light

by LMD » Wed Jan 03, 2018 14:27

Anyway, we can test the shaders with his Minetest fork.
Magic-CTF(soon)MTPCFractal-SuiteModel Creator Schematic CreatorColorfulXmas BallsWebsite • Never judge me by my age
 

User avatar
LMD
Member
 
Posts: 631
Joined: Sat Apr 08, 2017 08:16
Location: Somewhere over the Rainbow : Bonn, Germany
GitHub: appgurueu
In-game: LMD + PRO_LMD + Limo

Re: [shaders]Bloom + Better Light

by LMD » Wed Jan 03, 2018 14:30

I have ANSI C99 experience. And Java experience. Equation : C99+Java = C++
But I have no MT experience. ß((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((((
We need a core developer.
Magic-CTF(soon)MTPCFractal-SuiteModel Creator Schematic CreatorColorfulXmas BallsWebsite • Never judge me by my age
 

User avatar
azekill_DIABLO
Member
 
Posts: 7434
Joined: Wed Oct 29, 2014 20:05
Location: OMICRON
GitHub: azekillDIABLO
In-game: azekill_DIABLO
 

User avatar
rubenwardy
Moderator
 
Posts: 5474
Joined: Tue Jun 12, 2012 18:11
Location: United Kingdom
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [shaders]Bloom + Better Light

by rubenwardy » Wed Jan 03, 2018 16:57

I doubt you'll get much help from paramat. numberZero or lhofhansl would be more likely to be able to help you.
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Thu Jan 04, 2018 00:01

yeah paramat isn't much into eye-candy/graphics, he's more of a MT mechanic than anything else
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

User avatar
TumeniNodes
Member
 
Posts: 2469
Joined: Fri Feb 26, 2016 19:49
Location: in the dark recesses of the mind
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes

Re: [shaders]Bloom + Better Light

by TumeniNodes » Thu Jan 04, 2018 00:20

ThomasMonroe wrote:yeah paramat isn't much into eye-candy/graphics, he's more of a MT mechanic than anything else


Working with shaders is not an easy task..., by any means.
It's not so much that he isn't into eye candy, I would say more like not experienced in that area..., same goes for the rest of the devs or, I assure you..., there would be more to offer by now.

And it is not very easy to find individuals who are, who would be willing or available (time wise) to work on it for free.
My brain, is AES256 encrypted, even I don't know wth I'm thinking...
 

User avatar
ThomasMonroe
Member
 
Posts: 278
Joined: Tue Apr 04, 2017 16:21
Location: Wherever I am at
GitHub: ThomasMonroe314
IRC: ThomasMonroe TMcSquared
In-game: ThomasMonroe TMcSquared

Re: [shaders]Bloom + Better Light

by ThomasMonroe » Thu Jan 04, 2018 13:45

touche
however paramat has said on multiple occasions that he is not a big fan of eye-candy. But like you said, that doesn't mean anything, all it takes is someone experienced in shaders.
Projects|:*sigh* school: :Qub³d: :Legends Of Survival: :making people think:
I don't make things messy, I just *cough* disturb the local entropy.
 

PreviousNext

Return to Feature Discussion



Who is online

Users browsing this forum: No registered users and 2 guests