Confirmation dialog on new player registration

User avatar
srifqi
Member
 
Posts: 556
Joined: Sat Jun 28, 2014 04:31
Location: Indonesia
GitHub: srifqi
IRC: srifqi
In-game: srifqi

Confirmation dialog on new player registration

by srifqi » Mon Jan 22, 2018 15:54

Before, Minetest has no difference in interaction between login and register. Both are the same, because registration happens automatically in the background. This can lead to new player confusion. See Issue #258 and Issue #3167.

So, as of 13 January 2018, a cofirmation dialog is added for non-singleplayer game. (Pull Request #6849)

I got a report from another player that they can't register because they actually didn't enter a password in password field. EDIT: It's not like what I thought. They can, just press the button and leave the textbox empty as before.

+ (Old) screenshot


My question is, how is it? What's missing from it? How is the text and interaction inside it? How should it take care of empty password?

Thank you for your inputs!
Last edited by srifqi on Tue Jan 23, 2018 15:39, edited 1 time in total.
I'm from Indonesia! Saya dari Indonesia!
Terjemahkan Minetest!
Mods by me. Modifikasi oleh saya.

Pronounce my nick as in: es-rifqi (IPA: /es rifˈki/)
 

sofar
Developer
 
Posts: 2066
Joined: Fri Jan 16, 2015 07:31
GitHub: sofar
IRC: sofar
In-game: sofar

Re: Confirmation dialog on new player registration

by sofar » Mon Jan 22, 2018 17:51

File a bug, title: "password confirmation doesn't verify password matches with previously entered password"

(I didn't read the code, but that's what I assume is going wrong here)
 

User avatar
jas
Member
 
Posts: 452
Joined: Mon Jul 24, 2017 18:15
GitHub: jastevenson303
IRC: jas_
In-game: jas

Re: Confirmation dialog on new player registration

by jas » Tue Jan 23, 2018 14:20

I haven't updated this server in some time, so hopefully there were no new commits regarding this new feature since I last did. It's on 70a90bc8.

I hope I was this other player, because I simply commented on the PR and its commit. I was able to login fine, after clicking Register and Join, leaving the password text box empty. It took me a while, and I was surprised -- mostly, because this is what I saw:
Image

I was simply frustrated that a previously known behavior had changed -- I don't use password on test servers. And I don't restrict clients connecting because they neglected to secure their account.

My suggestion is to keep doing you, dude, good feature!
Attachments
Screenshot from 2018-01-21 13-07-50.png
(154.23 KiB) Not downloaded yet
2019-10-14 09:12:51: ACTION[Server]: jas activates
 

User avatar
jas
Member
 
Posts: 452
Joined: Mon Jul 24, 2017 18:15
GitHub: jastevenson303
IRC: jas_
In-game: jas

Re: Confirmation dialog on new player registration

by jas » Tue Jan 23, 2018 14:27

Here's the comment I made on the commit: https://github.com/minetest/minetest/co ... t-27010195

I thought I made another comment on the PR, but I can't find it and forget now what it was. Here's me complaining about the UI: https://github.com/minetest/minetest/pu ... -357518536

I do maintain that this text is too verbose, and that it _could_ be reduced. However, it's simply not worth too much thought and energy, it's a good feature.

"You are about to join the server for the first time, confirm your password. (TEXTBOX) [OK] [CANCEL]"
2019-10-14 09:12:51: ACTION[Server]: jas activates
 

User avatar
srifqi
Member
 
Posts: 556
Joined: Sat Jun 28, 2014 04:31
Location: Indonesia
GitHub: srifqi
IRC: srifqi
In-game: srifqi

Re: Confirmation dialog on new player registration

by srifqi » Tue Jan 23, 2018 15:37

Thanks for the feedbacks.

First, I thought the player cannot register. But they actually can, just press the button and leave thr textbox empty as before.

I have no idea. Probably add special case for empty password?

For the information text, we'll wait for other user to comment on this.
I'm from Indonesia! Saya dari Indonesia!
Terjemahkan Minetest!
Mods by me. Modifikasi oleh saya.

Pronounce my nick as in: es-rifqi (IPA: /es rifˈki/)
 

User avatar
jas
Member
 
Posts: 452
Joined: Mon Jul 24, 2017 18:15
GitHub: jastevenson303
IRC: jas_
In-game: jas

Re: Confirmation dialog on new player registration

by jas » Tue Jan 23, 2018 20:48

Yes, it's not a worry.

My revised suggestion: "You are about to join {server} with {name} for the first time, please confirm your password." (TEXTBOX) (OK) (Cancel)
2019-10-14 09:12:51: ACTION[Server]: jas activates
 

User avatar
sorcerykid
Member
 
Posts: 1061
Joined: Fri Aug 26, 2016 15:36
Location: Illinois, USA
GitHub: sorcerykid
In-game: Nemo

Re: Confirmation dialog on new player registration

by sorcerykid » Sun Feb 04, 2018 14:19

I've always wondered why the text is so verbose as well. I would think it could be straightforward: "A player account named 'testplayer' was not found on this server. Are you sure that you want to join 'My Great Server' as a new player?" with a "Yes" and a "No" button.
 

User avatar
Wuzzy
Member
 
Posts: 3610
Joined: Mon Sep 24, 2012 15:01
GitHub: Wuzzy2
IRC: Wuzzy
In-game: Wuzzy
 


Return to Feature Discussion



Who is online

Users browsing this forum: No registered users and 2 guests