triggers needed

[theFox]

I would like to have some global triggers:

• rightclickNode
• pickupItem

but since I am not a core developer I don't know how to implement them...

[Linuxdirk]

rightclickNode

This can be done by adding an on_rightclick function to the node in question.

http://dev.minetest.net/minetest.regist ... rightclick

[theFox]

to the node in question

I meant global triggers (like register minetest.register_on_punchnode)

[Linuxdirk]

to the node in question

I meant global triggers (like register minetest.register_on_punchnode)

When you use a tool for that action you can register it with an on_use function where you can do whatever you want. By just quick skipping to the API documentation I can't find such a register.

What is your use case? Maybe there is a workaround or other/better/different solution.

[Lejo]

Have a look at this mod:https://github.com/Arcelmi/minetest-controls

[TechNolaByte]

If these features would be implemented it would greatly improve the quest line for my soon to be released skyfactory subgame

[theFox]

What is your use case? Maybe there is a workaround or other/better/different solution.

I am only building a trigger api...
RSLRedstonier is requesting it from my mod, so he's the boss here.

[Linuxdirk]

You could register a tool that looks like and acts like the hand but with changes to the on_use function.

https://github.com/minetest/minetest/bl ... .txt#L2210

[theFox]

You could register a tool that looks like and acts like the hand but with changes to the on_use function.

https://github.com/minetest/minetest/bl ... .txt#L2210

Naw, that won't be useful...

Have a look at this mod:https://github.com/Arcelmi/minetest-controls

I guess that leaves only the on_pickup problem.

It's for my journal mod btw.

[Lejo]

I guess that leaves only the on_pickup problem.

Why not use on_drop and minetest.handle_node_drops?
You could override all items with a trigger on drop.

[TechNolaByte]

I guess that leaves only the on_pickup problem.

hmm i know that mineclone 2 uses a custome item drop mod which does have an on_pickup function
perhaps other item drop mods would have likewise?

[theFox]

Have a look at this mod:https://github.com/Arcelmi/minetest-controls

I guess that leaves only the on_pickup problem.

Like this I can't get the target of the player's right click.

hmm i know that mineclone 2 uses a custome item drop mod which does have an on_pickup function
perhaps other item drop mods would have likewise?

The ones I use don't...
If you used your own version in your subgame, you can register a trigger there.

[Lejo]

Like this I can't get the target of the player's right click.

Then just override all nodes with a trigger on_rightclick = func(pos, node, clicker, itemstack, pointed_thing).

[TechNolaByte]

Like this I can't get the target of the player's right click.

Then just override all nodes with a trigger on_rightclick = func(pos, node, clicker, itemstack, pointed_thing).

but what if they already have their own on_rightclick function?

[Lejo]

Like this I can't get the target of the player's right click.

Then just override all nodes with a trigger on_rightclick = func(pos, node, clicker, itemstack, pointed_thing).

but what if they already have their own on_rightclick function?

I have done the same with on_drop it works with a trick.
You have to store their own on_rightclick in a extra value.

[Lejo]

Here is the register code for it, just put it to your code.

Code: Select all

minetest.registered_on_rightclick = {}
function minetest.register_on_rightclick(func)
  table.insert(minetest.registered_on_rightclick, func)
end
local rightclickfuncs = {}

function minetest.handle_rightclick(pos, node, clicker, itemstack, pointed_thing)
  if clicker and clicker:is_player() then
    local name = clicker:get_player_name()
    if rightclickfuncs[node.name] then
      return rightclickfuncs[node.name](pos, node, clicker, itemstack, pointed_thing)
    end
    local todo
    for _,value in pairs(minetest.registered_on_rightclick) do
      local result = value(pos, node, clicker, itemstack, pointed_thing)
      if result then
        todo = result
      end
    end
    return todo
  end
end

minetest.after(3, function()
  for name, def in pairs(minetest.registered_items) do
    if def.on_rightclick then
      rightclickfuncs[name] = def.on_rightclick
    end
    minetest.override_item(name, {on_rightclick=minetest.handle_rightclick})
  end
end)

It should work with
minetest.register_on_rightclick(function(pos, node, clicker, itemstack, pointed_thing)
-- Your Code
end)

[theFox]

And if you want to use it together with my journal...
Look into the api.md and lower part of triggers.lua there you can learn how to register new triggers for the journal mod.

[Lejo]

And if you want to use it together with my journal...
Look into the api.md and lower part of triggers.lua there you can learn how to register new triggers for the journal mod.

Do it like so:

Code: Select all

triggers.register_trigger("rightclick")
local rightclickfuncs = {}

function triggers.handle_rightclick(pos, node, clicker, itemstack, pointed_thing)
  if clicker and clicker:is_player() then
    local name = clicker:get_player_name()
    if rightclickfuncs[node.name] then
      rightclickfuncs[node.name](pos, node, clicker, itemstack, pointed_thing)
    end
    local data ={
     target = node.name,
     playerName = name,
     tool = clicker:get_wielded_item():get_name(),
    }
    triggers.run_callbacks("rightclick", data)
  end
end

minetest.after(3, function()
  for name, def in pairs(minetest.registered_items) do
    if def.on_rightclick then
      rightclickfuncs[name] = def.on_rightclick
    end
    minetest.override_item(name, {on_rightclick=triggers.handle_rightclick})
  end
end)

It should work :)
But not tested.

[TechNolaByte]

ty!

[Lejo]

np

[theFox]

Edit: never mind, didn't read the code quite right.

[Lejo]

You can cut out the rightclickfuncs stuff, it's not needed here...

The rightclickfuncs is important it does that, if a block has a function on_rightclick that this function is not ignored.

[theFox]

The triggers are now avalible in the extra_triggers mod inside the journal modpack!