Vibrant Lighting

Astrobe
Member
Posts: 307
Joined: Sun Apr 01, 2018 10:46

Re: Vibrant Lighting

by Astrobe » Post

sorcerykid wrote: My thought is that dynamic colored lighting could be implemented as a special type of LuaEntitySAO, therefore no change to the database format or network protocol would even be required (I think). Here is a very basic specification that comes to mind: [...]
That looks appetizing. Are those specs based on Irrlicht's known capabilities?

Two drawbacks though: static (e.g. lamps) colored lights are not addressed - I fear there that doing this with entities could be expansive at scale - and implementing e.g. a fireball that lights things on its way (or falling torches etc.) will require two entities. I guess in the latter case, the use is more "transient" and the possibly of attaching two entities will make things relatively easy, but hopefully Irrlicht won't have the "strange idea" that entities can block light.

Termos
Member
Posts: 310
Joined: Sun Dec 16, 2018 12:50

Re: Vibrant Lighting

by Termos » Post

runs wrote:I feel like the sky is better in Minecraft. I mean the blue color, in Minetest is most a gray blue.
Agreed.
Which one do you like better?

Image
Image

If you guys like it, I've got a PR ready to roll.
Attachments
screenshot_20200228_202645.png
(156.81 KiB) Not downloaded yet
screenshot_20200228_201931.png
(156.95 KiB) Not downloaded yet

CalebJ
Member
Posts: 295
Joined: Sat Dec 29, 2018 19:21
GitHub: KaylebJay
IRC: KaylebJay
In-game: CalebJ
Location: Tunnelers' Abyss

Re: Vibrant Lighting

by CalebJ » Post

https://github.com/minetest/minetest/pull/8964
I think this pull request will dramatically make the sky better (and possibly unique on every server?) and I'm waiting patiently for it to be merged.
Just changing the color won't do much in my opinion, because that other game as noted has shades to the sky.
If you want realism, you're in the wrong place. Get off your mobile.

User avatar
runs
Member
Posts: 1554
Joined: Sat Oct 27, 2018 08:32
GitHub: runsy

Re: Vibrant Lighting

by runs » Post

Termos wrote:
runs wrote:I feel like the sky is better in Minecraft. I mean the blue color, in Minetest is most a gray blue.
Agreed.
Which one do you like better?

Image
Image

If you guys like it, I've got a PR ready to roll.
I love it!!!
Day 42 of the quarantine

Termos
Member
Posts: 310
Joined: Sun Dec 16, 2018 12:50

Re: Vibrant Lighting

by Termos » Post

CalebJ wrote:I think this pull request will dramatically make the sky better (and possibly unique on every server?) and I'm waiting patiently for it to be merged.
Just changing the color won't do much in my opinion, because that other game as noted has shades to the sky.
Lua sky interface is another thing, yes in the current state it is quite limited an needs improvement.
But there's also the default sky color hard coded in the engine, it's wrong hue imo, and I think it's a good idea for it not to be depressive, shades or not.
runs wrote:I love it!!!
However colors are quite tricky to do, I already noticed my sky looks too intense on my phone. Sure colors on phones may be cheated for marketing reasons, but probably I should desaturate it a bit further.

User avatar
texmex
Member
Posts: 1751
Joined: Mon Jul 11, 2016 21:08
GitHub: tacotexmex
In-game: texmex

Re: Vibrant Lighting

by texmex » Post

Is the water's color unchanged? The color of the water somewhat reflects the color of the sky IRL after all.
Mods | Support Mesehub: bc1qluuests9rxmlnvpjrhsnyjg9ucwy6z3r0y3srw

Termos
Member
Posts: 310
Joined: Sun Dec 16, 2018 12:50

Re: Vibrant Lighting

by Termos » Post

texmex wrote:Is the water's color unchanged? The color of the water somewhat reflects the color of the sky IRL after all.
Yes, water color is unchanged, I haven't touched it because it comes with MTG. I believe it's wrong hue as well and indeed, ideally it should be related to sky color, but it's a game/mod thing easily changed via custom texpacks.

For now I filled an issue: https://github.com/minetest/minetest/issues/9449

User avatar
Hume2
Member
Posts: 534
Joined: Tue Jun 19, 2018 08:24
GitHub: Hume2
In-game: Hume2
Location: Czech Republic

Re: Vibrant Lighting

by Hume2 » Post

texmex wrote:Is the water's color unchanged? The color of the water somewhat reflects the color of the sky IRL after all.
Note that this should be done in a way so that water in caves won't be affected by daylight cycles.
If you lack the reality, go on a trip or find a job.

User avatar
texmex
Member
Posts: 1751
Joined: Mon Jul 11, 2016 21:08
GitHub: tacotexmex
In-game: texmex

Re: Vibrant Lighting

by texmex » Post

Maybe ideal would be for the sky color to be based on a texture by default rather than a color code. Then texture packs would be able to provide their own matching sky color…
Mods | Support Mesehub: bc1qluuests9rxmlnvpjrhsnyjg9ucwy6z3r0y3srw

CalebJ
Member
Posts: 295
Joined: Sat Dec 29, 2018 19:21
GitHub: KaylebJay
IRC: KaylebJay
In-game: CalebJ
Location: Tunnelers' Abyss

Re: Vibrant Lighting

by CalebJ » Post

Now that'd be really cool, texmex!
If you want realism, you're in the wrong place. Get off your mobile.

User avatar
Linuxdirk
Member
Posts: 2516
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: Vibrant Lighting

by Linuxdirk » Post

Tehre's always the skybox functionality available, but no-one knows or cares how to handle skybox-related issues.

User avatar
TumeniNodes
Member
Posts: 2853
Joined: Fri Feb 26, 2016 19:49
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes
Location: in the dark recesses of the mind
Contact:

Re: Vibrant Lighting

by TumeniNodes » Post

texmex wrote:Maybe ideal would be for the sky color to be based on a texture by default rather than a color code. Then texture packs would be able to provide their own matching sky color…
This is what I was so wanting for my Ambiguity TP as the blue sky just ruins the overall effect.
Ich mag keine grünen Eier und Schinken, ich mag sie nicht Sam I Am

Post Reply

Who is online

Users browsing this forum: Nathan.S and 2 guests