GLSL Shaders

[Jordach]

intel GMA

You will not be able to run shaders whatsoever.

Sorry bud.

[VanessaE]

the shaders only work on systems that are running opengl (though for me the water shader does not work at all).

[tinoesroho]

... DirectX is on, innit?

[Inocudom]

... DirectX is on, innit?

There aren't any Direct X shaders currently.

[RealBadAngel]

... DirectX is on, innit?

There aren't any Direct X shaders currently.

First lets have OpenGL up n runnin.

Vanessa's issue with water is definitely caused by Irrlicht 1.8
Current tree (i made many updates yesterday) is working under 1.7.3

[sfan5]

For me, I get it all red. (Using sfan's build posted above.) Windows x86 XP with intel GMA

Don't use DirectX

[PilzAdam]

Vanessa's issue with water is definitely caused by Irrlicht 1.8
Current tree (i made many updates yesterday) is working under 1.7.3

Actually thats wrong, I use Irrlicht 1.7.3 and all water is grey. It also says something about "reflection.png missing" (or similiar).

[Inocudom]

... DirectX is on, innit?

There aren't any Direct X shaders currently.

First lets have OpenGL up n runnin.

Vanessa's issue with water is definitely caused by Irrlicht 1.8
Current tree (i made many updates yesterday) is working under 1.7.3

I heard that there are ways that OpenGL shaders can be converted to Direct X shaders. As you said, of course, the OpenGL shaders do have to be stable first.

One issue is that Direct X 9 is the highest version Irrlicht can use for the time being.

[RealBadAngel]

Vanessa's issue with water is definitely caused by Irrlicht 1.8
Current tree (i made many updates yesterday) is working under 1.7.3

Actually thats wrong, I use Irrlicht 1.7.3 and all water is grey. It also says something about "reflection.png missing" (or similiar).

Please do build it again and see first post about settings.

[PilzAdam]

Vanessa's issue with water is definitely caused by Irrlicht 1.8
Current tree (i made many updates yesterday) is working under 1.7.3

Actually thats wrong, I use Irrlicht 1.7.3 and all water is grey. It also says something about "reflection.png missing" (or similiar).

Please do build it again and see first post about settings.

I guess you mean pull and rebuild?

Code: Select all

/home/adam/Minetest/minetest_rba_shaders/src/mapblock_mesh.cpp:1204:95: error: no matching function for call to 'ITextureSource::getTexture(<unresolved overloaded function type>)'

Fix:

Code: Select all

diff --git a/src/mapblock_mesh.cpp b/src/mapblock_mesh.cpp
index f56a986..b907b64 100644
--- a/src/mapblock_mesh.cpp
+++ b/src/mapblock_mesh.cpp
@@ -1201,7 +1201,7 @@ MapBlockMesh::MapBlockMesh(MeshMakeData *data):
                if (enable_shaders) {
                        ITextureSource *tsrc = data->m_gamedef->tsrc();
                        material.setTexture(2, tsrc->getTexture("disable_img.png"));
-                       material.setTexture(3, tsrc->getTexture(getTexturePath("water_surface_normalmap.png").c_str));
+                       material.setTexture(3, tsrc->getTexture(getTexturePath("water_surface_normalmap.png").c_str()));
                        if (enable_bumpmapping) {
                                std::string fname_base = tsrc->getTextureName(p.tile.texture_id);
                                std::string normal_ext = "_normal.png";

EDIT: That fix doesnt work, here is the correct one:

Code: Select all

diff --git a/src/mapblock_mesh.cpp b/src/mapblock_mesh.cpp
index f56a986..b907b64 100644
--- a/src/mapblock_mesh.cpp
+++ b/src/mapblock_mesh.cpp
@@ -1201,7 +1201,7 @@ MapBlockMesh::MapBlockMesh(MeshMakeData *data):
                if (enable_shaders) {
                        ITextureSource *tsrc = data->m_gamedef->tsrc();
                        material.setTexture(2, tsrc->getTexture("disable_img.png"));
-                       material.setTexture(3, tsrc->getTexture(getTexturePath("water_surface_normalmap.png").c_str));
+                       material.setTexture(3, tsrc->getTexture("water_surface_normalmap.png"));
                        if (enable_bumpmapping) {
                                std::string fname_base = tsrc->getTextureName(p.tile.texture_id);
                                std::string normal_ext = "_normal.png";

[PilzAdam]

Here are some screenshots:
Default Texture Pack:

Haven Texture Pack:

[PilzAdam]

Here is another patch that adds Jeijas waves to it (it contains the previous fixes so it should work if you apply it to 1c03fb5efb5095f177c27497200db27694baeea1):

Code: Select all

diff --git a/client/shaders/liquids_shader/opengl_vertex.glsl b/client/shaders/liquids_shader/opengl_vertex.glsl
index 08c98cf..9ad16c8 100644
--- a/client/shaders/liquids_shader/opengl_vertex.glsl
+++ b/client/shaders/liquids_shader/opengl_vertex.glsl
@@ -4,6 +4,7 @@ uniform mat4 mInvWorld;
 uniform mat4 mTransWorld;
 uniform float dayNightRatio;
 uniform vec3 eyePosition;
+uniform float time;^M
 
 varying vec3 vPosition;
 varying vec3 viewVec;
@@ -14,9 +15,24 @@ varying vec3 viewPos;
 varying vec3 cameraPos;
 varying vec2 uv;
 
+float rand(vec2 co)^M
+{^M
+       return fract(sin(dot(co.xy ,vec2(12.9898,78.233))) * 43758.5453);^M
+}^M
+^M
 void main(void)
 {
-       gl_Position = mWorldViewProj * gl_Vertex;
+       int wavelength = 20;^M
+       float waveheight = 1.7;^M
+       int wavespeed = 100;^M
+       int height_randomness = 1;^M
+       ^M
+       vec4 pos2 = gl_Vertex;^M
+       pos2.y -= 3.0;^M
+       pos2.y -= sin (pos2.z/wavelength + time * wavespeed * wavelength) * waveheight^M
+               + sin ((pos2.z/wavelength + time * wavespeed * wavelength)/7) * waveheight * height_randomness;^M
+       ^M
+       gl_Position = mWorldViewProj * pos2;^M
 
        vPosition = (mWorldViewProj * gl_Vertex).xyz;
        vec3 pos = vec3(gl_Vertex);
diff --git a/src/game.cpp b/src/game.cpp
index 4c5e285..580ba8d 100644
--- a/src/game.cpp
+++ b/src/game.cpp
@@ -839,6 +839,8 @@ public:
                services->setPixelShaderConstant("useNormalmap" , (irr::s32*)&layer2, 1);
                services->setPixelShaderConstant("normalSampler" , (irr::s32*)&layer3, 1);
 #endif
+               float timeofday = m_client->getEnv().getTimeOfDayF();
+               services->setPixelShaderConstant("time", &timeofday, 1);
        }
 };
 
diff --git a/src/mapblock_mesh.cpp b/src/mapblock_mesh.cpp
index f56a986..fa6cf6a 100644
--- a/src/mapblock_mesh.cpp
+++ b/src/mapblock_mesh.cpp
@@ -1201,7 +1201,7 @@ MapBlockMesh::MapBlockMesh(MeshMakeData *data):
                if (enable_shaders) {
                        ITextureSource *tsrc = data->m_gamedef->tsrc();
                        material.setTexture(2, tsrc->getTexture("disable_img.png"));
-                       material.setTexture(3, tsrc->getTexture(getTexturePath("water_surface_normalmap.png").c_str));
+                       material.setTexture(3, tsrc->getTexture("water_surface_normalmap.png"));
                        if (enable_bumpmapping) {
                                std::string fname_base = tsrc->getTextureName(p.tile.texture_id);
                                std::string normal_ext = "_normal.png";

[Inocudom]

Here is another patch that adds Jeijas waves to it (it contains the previous fixes so it should work if you apply it to 1c03fb5efb5095f177c27497200db27694baeea1):

Code: Select all

diff --git a/client/shaders/liquids_shader/opengl_vertex.glsl b/client/shaders/liquids_shader/opengl_vertex.glsl
index 08c98cf..9ad16c8 100644
--- a/client/shaders/liquids_shader/opengl_vertex.glsl
+++ b/client/shaders/liquids_shader/opengl_vertex.glsl
@@ -4,6 +4,7 @@ uniform mat4 mInvWorld;
 uniform mat4 mTransWorld;
 uniform float dayNightRatio;
 uniform vec3 eyePosition;
+uniform float time;^M
 
 varying vec3 vPosition;
 varying vec3 viewVec;
@@ -14,9 +15,24 @@ varying vec3 viewPos;
 varying vec3 cameraPos;
 varying vec2 uv;
 
+float rand(vec2 co)^M
+{^M
+       return fract(sin(dot(co.xy ,vec2(12.9898,78.233))) * 43758.5453);^M
+}^M
+^M
 void main(void)
 {
-       gl_Position = mWorldViewProj * gl_Vertex;
+       int wavelength = 20;^M
+       float waveheight = 1.7;^M
+       int wavespeed = 100;^M
+       int height_randomness = 1;^M
+       ^M
+       vec4 pos2 = gl_Vertex;^M
+       pos2.y -= 3.0;^M
+       pos2.y -= sin (pos2.z/wavelength + time * wavespeed * wavelength) * waveheight^M
+               + sin ((pos2.z/wavelength + time * wavespeed * wavelength)/7) * waveheight * height_randomness;^M
+       ^M
+       gl_Position = mWorldViewProj * pos2;^M
 
        vPosition = (mWorldViewProj * gl_Vertex).xyz;
        vec3 pos = vec3(gl_Vertex);
diff --git a/src/game.cpp b/src/game.cpp
index 4c5e285..580ba8d 100644
--- a/src/game.cpp
+++ b/src/game.cpp
@@ -839,6 +839,8 @@ public:
                services->setPixelShaderConstant("useNormalmap" , (irr::s32*)&layer2, 1);
                services->setPixelShaderConstant("normalSampler" , (irr::s32*)&layer3, 1);
 #endif
+               float timeofday = m_client->getEnv().getTimeOfDayF();
+               services->setPixelShaderConstant("time", &timeofday, 1);
        }
 };
 
diff --git a/src/mapblock_mesh.cpp b/src/mapblock_mesh.cpp
index f56a986..fa6cf6a 100644
--- a/src/mapblock_mesh.cpp
+++ b/src/mapblock_mesh.cpp
@@ -1201,7 +1201,7 @@ MapBlockMesh::MapBlockMesh(MeshMakeData *data):
                if (enable_shaders) {
                        ITextureSource *tsrc = data->m_gamedef->tsrc();
                        material.setTexture(2, tsrc->getTexture("disable_img.png"));
-                       material.setTexture(3, tsrc->getTexture(getTexturePath("water_surface_normalmap.png").c_str));
+                       material.setTexture(3, tsrc->getTexture("water_surface_normalmap.png"));
                        if (enable_bumpmapping) {
                                std::string fname_base = tsrc->getTextureName(p.tile.texture_id);
                                std::string normal_ext = "_normal.png";

It pleases me greatly to see you supporting RealBadAngel's shaders, PilzAdam.

The new water shaders are very impressive, but may still be a little glitchy. Water that is in caves still has grayish coloration from time to time. Another thing I noticed is that lava also gets the water shaders, but ends up looking like water in the process.

The parallax mapping is working now, but the effect doesn't appear to be 3D from some viewing angles. Xonotic, Red Eclipse, and Sauerbraten have parallax mapping in them, so they can provide inspiration if it is needed. Calinou is involved in the communities of those games, so he might be of assistance.

I can tell that good progress is being made with the shaders. I know that the end result will be impressive.

[RealBadAngel]

I have updated first post with all the aviable config settings.

Issue with parallax not working perfectly is that we dont have properly calculated tangent.
I do have the code to calculate it in the engine, but theres no way to pass it to shaders.
Theres no way in irrlicht to use GLSL shaders attribute or to pass uniform sampler buffers.

[Inocudom]

I have updated first post with all the aviable config settings.

Issue with parallax not working perfectly is that we dont have properly calculated tangent.
I do have the code to calculate it in the engine, but theres no way to pass it to shaders.
Theres no way in irrlicht to use GLSL shaders attribute or to pass uniform sampler buffers.

That does not sound good. Why would Irrlicht not have such a feature?

[tkerwel]

i use minetest-0.4.7-54c8bdb-shaders-win32 and always get the error:


10:46:56: ERROR[main]: generate_shader(): failed to generate "liquids_shader", addHighLevelShaderMaterial failed.

can still play but the water looks strange. its like looking thru dark glass dosent matter if i play this on my laptop or my highend gaming pc.

settings are:

enable_water_wave = true
water_wave_height = 0.4
water_wave_speed = 50
water_wave_length = 20
enable_bumpmapping = true
parallax_mapping_mode = 2
parallax_mapping_scale = 0.08
parallax_mapping_bias = 0.04

[RealBadAngel]

i use minetest-0.4.7-54c8bdb-shaders-win32 and always get the error:


10:46:56: ERROR[main]: generate_shader(): failed to generate "liquids_shader", addHighLevelShaderMaterial failed.

can still play but the water looks strange. its like looking thru dark glass dosent matter if i play this on my laptop or my highend gaming pc.

settings are:

enable_water_wave = true
water_wave_height = 0.4
water_wave_speed = 50
water_wave_length = 20
enable_bumpmapping = true
parallax_mapping_mode = 2
parallax_mapping_scale = 0.08
parallax_mapping_bias = 0.04

Please add a few more lines around that error message, i need more details.

[sfan5]

It would be nice if you could fix these errors:
http://pastebin.com/WE4H6FGi

[RealBadAngel]

It would be nice if you could fix these errors:
http://pastebin.com/WE4H6FGi

Those are not errors but your OpenGL, I guess youre using open drivers.
Im not sure if i can make all the code run with it but i will try.
Whats your OpenGL version?

[sfan5]

Those are not errors but your OpenGL

I'm pretty sure that are errors..

Whats your OpenGL version?

Code: Select all

$ glxinfo | grep version
server glx version string: 1.4
client glx version string: 1.4
GLX version: 1.4
OpenGL core profile version string: 3.1 (Core Profile) Mesa 9.2.1
OpenGL core profile shading language version string: 1.40
OpenGL version string: 3.0 Mesa 9.2.1
OpenGL shading language version string: 1.30

[hoodedice]

intel GMA

You will not be able to run shaders whatsoever.

Sorry bud.

They run in FlightGear, but they cause tons of lag. I was just gonna check out what they looked like.

For me, I get it all red. (Using sfan's build posted above.) Windows x86 XP with intel GMA

Don't use DirectX

I'm not using it (I guess). Well, minetest reports that my OpenGL version is 2.0 so maybe I'm running OpenGL. Again, I don't think sfan made a build with DirectX.

[Inocudom]

With PilzAdam's latest build of RealBadAngel's shaders branch, I was able to record a video of the shaders. The video is of somewhat low quality, but the shaders are visible.

[u34]

are there any shaders planed for AMD video cards?

Code: Select all

Irrlicht Engine version 1.8.0
Microsoft Windows 7 Home Premium Edition Service Pack 1 (Build 7601)
Using renderer: OpenGL 4.2.11631
AMD Radeon HD 6500M/5600/5700 Series: ATI Technologies Inc.
OpenGL driver version is 1.2 or better.
GLSL version: 4.2

[VanessaE]

In theory they should work with any video card, but they don't work for me. I assumed it was an incompatibility with my OpenGL version (4.3.12614), as RBA develops on an older OpenGL (2.2 or something) and AMD video.

[tkerwel]

i use minetest-0.4.7-54c8bdb-shaders-win32 and always get the error:


10:46:56: ERROR[main]: generate_shader(): failed to generate "liquids_shader", addHighLevelShaderMaterial failed.

can still play but the water looks strange. its like looking thru dark glass dosent matter if i play this on my laptop or my highend gaming pc.

settings are:

enable_water_wave = true
water_wave_height = 0.4
water_wave_speed = 50
water_wave_length = 20
enable_bumpmapping = true
parallax_mapping_mode = 2
parallax_mapping_scale = 0.08
parallax_mapping_bias = 0.04

Please add a few more lines around that error message, i need more details.

okay after i read your message i was looking whats the difference between the two computers. after a update for the newest OpenGL on the big one, i dont get this error anymore. so looks like this is something with the OpenGL drivers which cause the problem.