[solved]lava not cooling and cacti not growing...

Post Reply
User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

[solved]lava not cooling and cacti not growing...

by theFox » Post

If lava flows into water it doesn't cool down to stone, also cacti are not growing.
I playing the Minetest Game using Minetest 0.4.15-dev on Linux.
I already located the problem.
In minetest/games/minetest_game/mods/default/functions.lua after line 96:

Code: Select all

minetest.register_abm({
	nodenames = {"default:lava_source", "default:lava_flowing"},
	neighbors = {"group:water"},
	interval = 1,
	chance = 1,
	catch_up = false,
	action = function(...)
		default.cool_lava(...)
	end,
})
The problem is, that if you use "..." as function argument, the variables given to the function, are put into a list called "arg".
Maybe this would be better:

Code: Select all

minetest.register_abm({
	nodenames = {"default:lava_source", "default:lava_flowing"},
	neighbors = {"group:water"},
	interval = 1,
	chance = 1,
	catch_up = false,
	action = default.cool_lava,
})
It is used in the same way for cacti and papyrus.
Last edited by theFox on Thu May 25, 2017 17:10, edited 2 times in total.
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

better put emty ()
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

azekill_DIABLO wrote:better put emty ()
If you leave out the brackets, the function is set as action.
If you add the brackets, the function would be executed and the return value would be set as action (would cause an error of course)
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

put (lol) then?
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

I mean just leave it as I suggested.
Because the function will be set as action if you do it like this.
But I updated my minetest_game and it works.
somehow...
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

weird...
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

I guess I was a little optimistic, it doesn't...
I wonder why no one realizes: Lava doesn't cool off, cacti don't grow and papyrus does neither.
And even in the new code "function(...)" is not used correctly
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

have you posted an issue on github? it's true i didn't seen any cacti growing those times.
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

I have just posted the issue on github.
Hope it's fixed soon.
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

yup.
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

No one could reproduce the bug, but the fix is merged into the latest version of minetest_game.
So how do I delete this topic?
my mods and subgames (ง'̀-'́)ง

User avatar
MineYoshi
Member
Posts: 5373
Joined: Wed Jul 08, 2015 13:20
Contact:

Re: [bug]lava not cooling and cacti not growing...

by MineYoshi » Post

theFox wrote:No one could reproduce the bug, but the fix is merged into the latest version of minetest_game.
So how do I delete this topic?
Put [SOLVED] in the title of the topic. I don't think you can delete this topic nor the staff have time to do so.
Justly put [SOLVED] in the title of the topic so everybody justly ignores it.
Have a nice day! :D

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [bug]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

better put [reproducing needed].
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [bug]lava not cooling and cacti not growing...

by theFox » Post

azekill_DIABLO wrote:better put [reproducing needed].
xD
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [solved]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

:) what's so funny?
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [solved]lava not cooling and cacti not growing...

by theFox » Post

azekill_DIABLO wrote::) what's so funny?
It's better if the bug doesn't appear anymore.
my mods and subgames (ง'̀-'́)ง

User avatar
azekill_DIABLO
Member
Posts: 7507
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO
Location: OMICRON
Contact:

Re: [solved]lava not cooling and cacti not growing...

by azekill_DIABLO » Post

+1
Gone, but not dead. Contact me on discord: azekill_DIABLO#6565
DMs are always open if you want to get in touch!

User avatar
paramat
Developer
Posts: 3700
Joined: Sun Oct 28, 2012 00:05
GitHub: paramat
IRC: paramat
Location: UK

Re: [solved]lava not cooling and cacti not growing...

by paramat » Post

The bug reported here could not be reproduced, and the suggestion in the 1st post was carelessly merged (partially my fault), it actually broke something else and 0.4.16 was released with this breakage, sorry, it has been reverted now.

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [solved]lava not cooling and cacti not growing...

by theFox » Post

paramat wrote:it actually broke something else
I still don't get what went wrong.
my mods and subgames (ง'̀-'́)ง

User avatar
theFox
Member
Posts: 192
Joined: Sun Feb 12, 2017 14:08
GitHub: theFox6
In-game: theFox
Location: Germany

Re: [solved]lava not cooling and cacti not growing...

by theFox » Post

theFox wrote:
paramat wrote:it actually broke something else
I still don't get what went wrong.
All right got it: overriding of default functions does not work anymore
my mods and subgames (ง'̀-'́)ง

Post Reply

Who is online

Users browsing this forum: No registered users and 6 guests