Apples not generating right

Post Reply
Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Apples not generating right

by Soudon » Post

Ok so recently I noticed that apples are not generating right before they "hung" by themselves now here lately they have been generating inside of the leaves. Makes them hard to see and only to get them is to destroy the leaves I just want them to hang by themselves again. also on version 0.4.13

Image

User avatar
paramat
Developer
Posts: 3699
Joined: Sun Oct 28, 2012 00:05
GitHub: paramat
IRC: paramat
Location: UK

Re: Apples not generating right

by paramat » Post

Looking at the code. appletrees have been like this for a very long time.

User avatar
jp
Member
Posts: 803
Joined: Wed Dec 18, 2013 09:03
GitHub: kilbith
Location: France

Re: Apples not generating right

by jp » Post

Wake up, you're not using Minetest Game, but Minetest NeXt by BlockMen...

Dragonop
Member
Posts: 1194
Joined: Tue Oct 23, 2012 12:59
GitHub: Dragonop
IRC: Dragonop
In-game: Dragonop
Location: Argentina

Re: Apples not generating right

by Dragonop » Post

Minetest NeXt wrote:- Apples are now generated in leaves

User avatar
Minetestforfun
Member
Posts: 940
Joined: Tue Aug 05, 2014 14:09
GitHub: MinetestForFun
IRC: MinetestForFun
In-game: MinetestForFun
Location: On earth
Contact:

Re: Apples not generating right

by Minetestforfun » Post


Dartmouth
Member
Posts: 121
Joined: Sat Dec 06, 2014 14:39

Re: Apples not generating right

by Dartmouth » Post

Not necessarily, I just checked my tree farm (with regular minetest game) and managed to find one apple completely covered by leaves in roughly 15 apple trees. So it's quite unlikely, and digging one block of leaves isn't that much work :)
Besides, it's more realistic like this.

User avatar
Ferk
Member
Posts: 337
Joined: Tue Aug 18, 2015 17:18
GitHub: Ferk

Re: Apples not generating right

by Ferk » Post

This doesn't look like Minetest Next leaves with apples.

In Minetest Next the apple is just a few pixels in the texture of the sides of the leaves, there's no actual apple entity inside and you see the same apple in the same position in each of the sides of the node. However in the screenshot from this post you can see there's actually an apple inside and it's not just the texture because the apple is in the corner, in between two sides of the cube.
{ ☠ Dungeontest ☠ , ᗧ••myarcade•• }

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

jp wrote:Wake up, you're not using Minetest Game, but Minetest NeXt by BlockMen...
Wide awake over here and nope not using minetest next I have minetest minmal, game and my custom one called survival+ no minetest next

User avatar
programmingchicken
Member
Posts: 540
Joined: Sat Apr 18, 2015 02:20
GitHub: pchicken
IRC: chicken pchicken
Location: not here
Contact:

Re: Apples not generating right

by programmingchicken » Post

Soudon wrote:
jp wrote:Wake up, you're not using Minetest Game, but Minetest NeXt by BlockMen...
Wide awake over here and nope not using minetest next I have minetest minmal, game and my custom one called survival+ no minetest next
then this is a survival+ world, right?
<gamerdude> I apologize for the above content

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

Correct but based from minetest_game just threw a few survival mods in and renamed it.

But apples are not a big deal, really wanted to know if its a glitch or not thats all.

User avatar
BlockMen
Developer
Posts: 768
Joined: Fri Mar 01, 2013 17:24
GitHub: BlockMen
Location: Germany

Re: Apples not generating right

by BlockMen » Post

Soudon wrote:Correct but based from minetest_game just threw a few survival mods in and renamed it.

But apples are not a big deal, really wanted to know if its a glitch or not thats all.

Wrong. Just looked at your Game "Survival +", you took default (or at least parts of it) from Minetest NeXt, including the change of apples being generated inside the leaves.

Also your Readme.txt of the game states it is licensed under LGPL 2.1, while Minetest NeXt is licensed under GPL 3.0. So what you are doing now is not allowed. Either remove the code of Minetest NeXt OR state clearly that not all parts of the game are licensed under LGPL 2.1 OR relicense it under GPL 3.0 or a GPL 3.0 compatible license.

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

Ok now that I am behind my PC again and its easier to type then with my phone.

I apologize I really wasn't trying to claim something as my own and I honestly forgot about using part of minetest next, I remember which part it is I used the part for the inventory cause I liked the default look but with the additional slots for armor that is the part I used, If I used anymore that was unintentional.

I did state I threw mods in and renamed the minetest_game folder, never claimed I made the mods.

But I will go read up on the licensing and see about relicensing it as you suggested.

Again I apologize and just flat out forgot about using that part of next.
Last edited by Soudon on Tue Oct 27, 2015 16:08, edited 1 time in total.

User avatar
BlockMen
Developer
Posts: 768
Joined: Fri Mar 01, 2013 17:24
GitHub: BlockMen
Location: Germany

Re: Apples not generating right

by BlockMen » Post

Soudon wrote:Ill do one better and just delete the download link
Well, ofc you can "run away". Better alternative would be learning to deal with licenses respectively respect them ;)

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

BlockMen wrote:
Soudon wrote:Ill do one better and just delete the download link
Well, ofc you can "run away". Better alternative would be learning to deal with licenses respectively respect them ;)
lol I edited the post you quoted and submitted just after you but I did say I'm going to read up on licensing and see what I can do just for now the link is removed.

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

BlockMen wrote:
Soudon wrote:Ill do one better and just delete the download link
Well, ofc you can "run away". Better alternative would be learning to deal with licenses respectively respect them ;)
went here http://www.gnu.org/licenses

was reading but to me its all a different language, short and simple what must I do to make it ok to post the subgame, I suck at writing mods but I'm ok at editing the code to make it different and more to my liking. I know minetest next is your game Blockmen, I don't want step on any toes and really would like to learn how to license things properly so how exactly do I relicense it.

Either explain it help me understand or point me to website that explains it in dummy proof language lol.

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

BlockMen wrote:
Soudon wrote:Correct but based from minetest_game just threw a few survival mods in and renamed it.

But apples are not a big deal, really wanted to know if its a glitch or not thats all.

Wrong. Just looked at your Game "Survival +", you took default (or at least parts of it) from Minetest NeXt, including the change of apples being generated inside the leaves.

Also your Readme.txt of the game states it is licensed under LGPL 2.1, while Minetest NeXt is licensed under GPL 3.0. So what you are doing now is not allowed. Either remove the code of Minetest NeXt OR state clearly that not all parts of the game are licensed under LGPL 2.1 OR relicense it under GPL 3.0 or a GPL 3.0 compatible license.
Ok blockmen take a look see if I did this correctly I feel like I did but I want to be 100% this is right.

Readme.txt
+ Spoiler

User avatar
BlockMen
Developer
Posts: 768
Joined: Fri Mar 01, 2013 17:24
GitHub: BlockMen
Location: Germany

Re: Apples not generating right

by BlockMen » Post

Seems to be all correct now, since all different licenses I found are compatible with GPL 3.0.
I would add a notice that not all mods are licensed as GPL 3.0 (e.g. survival) though, but you don't have to.

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

BlockMen wrote:Seems to be all correct now, since all different licenses I found are compatible with GPL 3.0.
I would add a notice that not all mods are licensed as GPL 3.0 (e.g. survival) though, but you don't have to.

Awesome glad I was able to figure it out and I take it in the readme I just add a line about not all mods are GPL3.0.

User avatar
Ferk
Member
Posts: 337
Joined: Tue Aug 18, 2015 17:18
GitHub: Ferk

Re: Apples not generating right

by Ferk » Post

If these are really the apple leaves from Minetest next I'm surprised. At least the last time I tired it they didn't look this much as actual apple inside leaves, were they improved? Is an entity spawned inside the node or how?
{ ☠ Dungeontest ☠ , ᗧ••myarcade•• }

User avatar
Napiophelios
Member
Posts: 1020
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: Apples not generating right

by Napiophelios » Post

I get apples inside leaves In Minetest,
but they are just nodes surrounded by leaves
Image
00001.png
(108.87 KiB) Not downloaded yet

Soudon
Member
Posts: 167
Joined: Wed Apr 08, 2015 17:14
In-game: Soudon

Re: Apples not generating right

by Soudon » Post

Napiophelios wrote:I get apples inside leaves In Minetest,
but they are just nodes surrounded by leaves
Image
00001.png
yea same here its not a big deal for me as i also have the timber mod so they all fall to the ground.

User avatar
firefox
Member
Posts: 1588
Joined: Wed Jan 14, 2015 07:34
In-game: Red_Fox
Location: Xanadu

Re: Apples not generating right

by firefox » Post

maybe it's an illusion created by the drawtype of the leaves.
after all they are partially transparent and it looks like they use a drawtype similar to glass.

recently i made experiments with transparent ice and glaciers and it happenend that i could see through the glacier as if i had noclip enabled.
✨🏳️‍🌈♠️✨

User avatar
Ferk
Member
Posts: 337
Joined: Tue Aug 18, 2015 17:18
GitHub: Ferk

Re: Apples not generating right

by Ferk » Post

Ah no, seems like it's a mesh (except if waving leaves are enabled, maybe that's why I didn't see them)

Also it has different groups (will not show up in creative inventory) in that case. And I remember it did when I checked it out last time.. why should the graphical settings affect the creative inventory? I assume it's a bug.

I thought that things like shaders and waving leaves were set client-side. I guess being able to check the settings like this means they are not. Does this mean every server enforces even the graphical configuration on the clients? I guess this would mean that probably every server has to turn off all the effects to reach the minimum denominator.
{ ☠ Dungeontest ☠ , ᗧ••myarcade•• }

User avatar
BlockMen
Developer
Posts: 768
Joined: Fri Mar 01, 2013 17:24
GitHub: BlockMen
Location: Germany

Re: Apples not generating right

by BlockMen » Post

I thought that things like shaders and waving leaves were set client-side.
You are right, they are. It was actually more a try to allow waving when playing singleplayer, but it not that nice, visually and in general.

So some thoughts on this would be welcome, since im not that happy that meshes (or regular apples) are not able to wave in the same way as leaves.

Post Reply

Who is online

Users browsing this forum: No registered users and 4 guests