furnace: missing 'sanity' check

[rnd]

PROBLEM:
1. suppose you have item with long burn time that requires a lot of fuel.

2. put item in chest, add any fuel (1 piece of wood will do) and quickly go away so that area unloads.
wait however long is needed for smelting

3. come back.. your item is magically smelted, even though the fuel was clearly not sufficient (need to add missing FUEL CHECK here)

furnace.lua:

Code: Select all

minetest.register_node("default:furnace", {
...
on_timer = furnace_node_timer,
...
}

local function furnace_node_timer(pos, elapsed)

...
if fuel_time < fuel_totaltime then
	-- The furnace is currently active and has enough fuel
	fuel_time = fuel_time + elapsed
        if cookable then
	    src_time = src_time + elapsed
	   if src_time >= cooked.time then
               -- Place result in dst list if possible
              PROBLEM HERE, MISSING FUEL CHECK

FIX: check if fuel.time is enough to smelt item or abort smelt process.

[sfan5]

You should open an issue here.

[sorcerykid]

Thanks for the heads up rnd. I will go ahead and put a fix into place on my server. Hopefully other server operators will see this report and do the same.

[sofar]

Please take the time and share your fix, so it can be fixed in the various forks of minetest_game?

[Wuzzy]

Sorcerykid is usually not interested in sharing anything. We're on our own.