Trying to implement Shadow Mapping

For people working on the C++ code.
deleted c0a803ab

Re: is Shadow mapping desired?

by deleted c0a803ab » Post

-

User avatar
v-rob
Developer
Posts: 969
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: Trying to implement Shadow Mapping

by v-rob » Post

Say, do you have the code online anywhere? I found https://github.com/0xLiso/minetest-shadowmap, but it looks a little outdated. I would love to try out those colored shadows with my stained glass mod; I think it would look simply amazing.
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

Liso
Member
Posts: 33
Joined: Thu Feb 06, 2020 10:21
GitHub: 0xLiso
In-game: Liso
Location: Valencia - Spain.
Contact:

Re: Trying to implement Shadow Mapping

by Liso » Post

v-rob wrote:
Thu Apr 15, 2021 22:24
Say, do you have the code online anywhere? I found https://github.com/0xLiso/minetest-shadowmap, but it looks a little outdated. I would love to try out those colored shadows with my stained glass mod; I think it would look simply amazing.
Yes, it's in that repo, branch "PSM"
philipbenr wrote:
Thu Apr 15, 2021 20:26
Liso wrote:
Thu Apr 15, 2021 11:23
Just working on it :)

[ images ]
Very nice looking indeed. How does it work if you stack one behind or on top of another? ;)

Do you think that variable opacity of an element is going to be a problem?


I think it should work without problem
Liso. - My twitter -

lordawe
Member
Posts: 53
Joined: Sat Nov 12, 2011 11:13

Re: Trying to implement Shadow Mapping

by lordawe » Post

Hi, it is cool!
Can anybody compile it for windows 64bit please?

u34

Re: Trying to implement Shadow Mapping

by u34 » Post

a win build would be great.

Liso
Member
Posts: 33
Joined: Thu Feb 06, 2020 10:21
GitHub: 0xLiso
In-game: Liso
Location: Valencia - Spain.
Contact:

Re: Trying to implement Shadow Mapping

by Liso » Post

lordawe wrote:
Tue May 18, 2021 10:05
Hi, it is cool!
Can anybody compile it for windows 64bit please?
cHyper wrote:
Wed May 19, 2021 06:32
a win build would be great.
Sorry, but this is under heavy testing&development.There are changes almost every day, so if you want to test it, you should compile it from the PR.

Image
Image
Image
Image
Attachments
ex2.jpg
ex2.jpg (228.45 KiB) Viewed 2816 times
ex3.png
ex3.png (451.58 KiB) Viewed 2816 times
ex4.png
ex4.png (446.01 KiB) Viewed 2816 times
Liso. - My twitter -

lordawe
Member
Posts: 53
Joined: Sat Nov 12, 2011 11:13

Re: Trying to implement Shadow Mapping

by lordawe » Post

Beautiful screenshots!

Sadly, I have no experience in compiling.

sfan5
Moderator
Posts: 4093
Joined: Wed Aug 24, 2011 09:44
GitHub: sfan5
IRC: sfan5
Location: Germany

Re: Trying to implement Shadow Mapping

by sfan5 » Post

Someone requested a Windows build of the current state of this PR
Here's it: https://kitsunemimi.pw/tmp/minetest-5.5 ... 4-win64.7z

Briefly tested it to make sure it works and I'm very impressed with your work, thanks for doing this Liso.
Last edited by sfan5 on Thu May 27, 2021 17:34, edited 1 time in total.
Reason: Replaced with new build
Mods: Mesecons | WorldEdit | Nuke & Minetest builds for Windows (32-bit & 64-bit)

lordawe
Member
Posts: 53
Joined: Sat Nov 12, 2011 11:13

Re: Trying to implement Shadow Mapping

by lordawe » Post

THANK YOU sfan5 for Windows build!
THANK YOU Liso!
It is amazing!
Thank you!

lordawe
Member
Posts: 53
Joined: Sat Nov 12, 2011 11:13

Re: Trying to implement Shadow Mapping

by lordawe » Post

Colored shadows through rock underground...
https://pasteimg.com/image/ciKeC

twoelk
Member
Posts: 1482
Joined: Fri Apr 19, 2013 16:19
GitHub: twoelk
IRC: twoelk
In-game: twoelk
Location: northern Germany

Re: Trying to implement Shadow Mapping

by twoelk » Post

cobble seen from underneath and sheep walking around seem somewhat dark

User avatar
freshreplicant
Member
Posts: 223
Joined: Sun Aug 09, 2020 10:37
In-game: freshreplicant

Re: Trying to implement Shadow Mapping

by freshreplicant » Post

Liso, I've been following your PR very closely. Very, very impressive. Minetest looks like a whole new game/engine. Thanks for taking the time to work on this and for being so responsive to feedback. Do you have an existing way to donate to you in case we want to send something your way once/if it gets merged?

Liso
Member
Posts: 33
Joined: Thu Feb 06, 2020 10:21
GitHub: 0xLiso
In-game: Liso
Location: Valencia - Spain.
Contact:

Re: Trying to implement Shadow Mapping

by Liso » Post

Thank you for all your comments and support.

The last versions fix most of the glitches .
freshreplicant wrote:
Sat May 22, 2021 14:41
Do you have an existing way to donate to you in case we want to send something your way once/if it gets merged?
No i don't have any of that but I appreciate your offer. I just do this in my spare time just for the community and to learn something new :).
Liso. - My twitter -

twoelk
Member
Posts: 1482
Joined: Fri Apr 19, 2013 16:19
GitHub: twoelk
IRC: twoelk
In-game: twoelk
Location: northern Germany

Re: Trying to implement Shadow Mapping

by twoelk » Post

ok, I was wrong, it's not just cobble but rather any slab that looks darker from underneath and this may not be a shader only issue but an allready older minetest engine issue ... or mtg?

the sheep of mobs-redo are indeed very much darker with dynamic shaders on - which may be a mod problem as well :-(

havn't played with the newest version yet though

else, just wow!

qawsedrftgzh
Member
Posts: 32
Joined: Sat Jul 25, 2020 08:36
GitHub: qawsedrftgzh
Location: Germany

Re: Trying to implement Shadow Mapping

by qawsedrftgzh » Post

This seems to be an important improvement to minetest, I hope this will be included.
What about an AUR package?
My English is not so good, because I am german

Liso
Member
Posts: 33
Joined: Thu Feb 06, 2020 10:21
GitHub: 0xLiso
In-game: Liso
Location: Valencia - Spain.
Contact:

Re: Trying to implement Shadow Mapping

by Liso » Post

PR merged, so I guess this thread has come to its end :). Thank you all for your help and support. See you in the next PR, and in the "issues" tab xD
Liso. - My twitter -

User avatar
Linuxdirk
Member
Posts: 3216
Joined: Wed Sep 17, 2014 11:21
In-game: Linuxdirk
Location: Germany
Contact:

Re: Trying to implement Shadow Mapping

by Linuxdirk » Post

Glorious!

User avatar
philipbenr
Member
Posts: 1897
Joined: Fri Jun 14, 2013 01:56
GitHub: philipbenr
IRC: philipbenr
In-game: robinspi
Location: United States

Re: Trying to implement Shadow Mapping

by philipbenr » Post

Thank you for your hard work Liso!

User avatar
v-rob
Developer
Posts: 969
Joined: Thu Mar 24, 2016 03:19
GitHub: v-rob
IRC: v-rob
Location: Right behind you.

Re: Trying to implement Shadow Mapping

by v-rob » Post

Yes, I imagine that quite a few issues will pop up soon. However, I am super glad to see this in Minetest, even if it does have some bugs. The game takes on a whole new light with this! (pun not intended)
Core Developer | My Best Mods: Bridger - Slats - Stained Glass

User avatar
TumeniNodes
Member
Posts: 2941
Joined: Fri Feb 26, 2016 19:49
GitHub: TumeniNodes
IRC: tumeninodes
In-game: TumeniNodes
Location: in the dark recesses of the mind
Contact:

Re: Trying to implement Shadow Mapping

by TumeniNodes » Post

v-rob wrote:
Mon Jun 07, 2021 22:54
Yes, I imagine that quite a few issues will pop up soon. However, I am super glad to see this in Minetest, even if it does have some bugs. The game takes on a whole new light with this! (pun not intended)
Same.
One issue I see so far, is how water works with all of this.
While water should cast a shadow, the blue casting should not be coming through as with stained glass.
It prob should'nt cast such a strong shadow either, but then again it's reading cubic dimensions so...
A Wonderful World

User avatar
Extex
Member
Posts: 244
Joined: Wed Mar 14, 2018 23:14
GitHub: Extex101
In-game: Extex

Re: Trying to implement Shadow Mapping

by Extex » Post

TumeniNodes wrote:
Tue Jun 08, 2021 00:53
One issue I see so far, is how water works with all of this.
While water should cast a shadow, the blue casting should not be coming through as with stained glass.
It prob should'nt cast such a strong shadow either, but then again it's reading cubic dimensions so...
I've found that only flowing water does it, looks kinda cool in some circumstances but not all

Scuba Lights
Image

And this one.... Yeah idk
Image
Creator of jelys_pizzaria and motorbike, and player of persistent kingdoms. RIP

User avatar
Andrey01
Member
Posts: 2574
Joined: Wed Oct 19, 2016 15:18
GitHub: Andrey2470T
In-game: Andrey01
Location: Russia, Moscow

Re: Trying to implement Shadow Mapping

by Andrey01 » Post

It is so nice to see this is merged!

The whole game just gets drastically transformated with it if compare it with the atmosphere when disabled. And even no a need to improve the graphics in MTG because it is immediately improved in times with this feature. :)

lordawe
Member
Posts: 53
Joined: Sat Nov 12, 2011 11:13

Re: Trying to implement Shadow Mapping

by lordawe » Post

MERGED? Cool! :)
All my 5 thumbs up :P

User avatar
firefox
Member
Posts: 1709
Joined: Wed Jan 14, 2015 07:34
In-game: Red_Fox
Location: Xanadu

Re: Trying to implement Shadow Mapping

by firefox » Post

i think those water shadows are very interesting. i haven't seen any of this in-game yet, but are they animated just like the flowing water is? if yes, this could be very nice for creating a mysterious ambience in buildings.
✨🏳️‍🌈♣️✨

User avatar
Extex
Member
Posts: 244
Joined: Wed Mar 14, 2018 23:14
GitHub: Extex101
In-game: Extex

Re: Trying to implement Shadow Mapping

by Extex » Post

firefox wrote:
Tue Jun 08, 2021 11:48
i think those water shadows are very interesting. i haven't seen any of this in-game yet, but are they animated just like the flowing water is? if yes, this could be very nice for creating a mysterious ambience in buildings.
It seems to be intentional that water doesn't cast a shadow but I think the fact that flowing water does cast a shadow, is a bug
Creator of jelys_pizzaria and motorbike, and player of persistent kingdoms. RIP

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests